Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Kate Kate
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 26
    • Issues 26
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 4
    • Merge requests 4
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • UtilitiesUtilities
  • KateKate
  • Merge requests
  • !581

Only match filename by default in quickopen

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Waqar Ahmed requested to merge work/improve-quickopen into master Feb 02, 2022
  • Overview 6
  • Commits 3
  • Pipelines 8
  • Changes 2

Reasoning: Firstly, I think it was just a very poor decision to match both if filename matched. When filename got matched, it is unnecessary to match the path and can lead to worse results if we do it. Consider files:

path/to/FileView.cpp
files/views/to/FileViewModel.cpp ...

First file match will happen, which most likely gives us the first file for a pattern "fv". But then path matching which can ruin this result and give some other irrelevant match a higher score leading to worse results in quickopen

In kate, we work with files (from a user POV). User mostly sees filename and will most likely be matching against file names, and rarely against paths.

The other benefit that this gives is HUGELY better performance. This is atleast 2x faster, so with large repos quick open will be much nicer to use.

if one really wants to match a path, then specifying a pattern like:

src/fv

will do it. This is already supported, so it isn't something new.


++ other changes with explaination in respective commit descriptions

Edited Feb 02, 2022 by Waqar Ahmed
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/improve-quickopen