Commit 33dd83c9 authored by Mike Harris's avatar Mike Harris Committed by Albert Astals Cid

fixed Check single-char QString operations for efficiency [doublequote_chars].. in ebn.kde.org

Reviewers: #kate, dhaumann

Reviewed By: #kate, dhaumann

Subscribers: dhaumann

Tags: #kate

Differential Revision: https://phabricator.kde.org/D8372
parent 71d79055
......@@ -205,7 +205,7 @@ void PluginKateXMLCheckView::slotProcExited(int exitCode, QProcess::ExitStatus e
list_count++;
}
if( ! proc_stderr.isEmpty() ) {
QStringList lines = proc_stderr.split("\n", QString::SkipEmptyParts);
QStringList lines = proc_stderr.split('\n', QString::SkipEmptyParts);
QString linenumber, msg;
int line_count = 0;
for(QStringList::Iterator it = lines.begin(); it != lines.end(); ++it) {
......@@ -344,7 +344,7 @@ bool PluginKateXMLCheckView::slotValidate()
// xmllint --noout --path "/home/user/my/with:colon/" --valid "/tmp/kate.X23725"
// As workaround we can encode ':' with %3A
QString path = kv->document()->url().toString(QUrl::RemoveFilename|QUrl::PreferLocalFile|QUrl::EncodeSpaces);
path.replace(":","%3A");
path.replace(':',"%3A");
// because of such inconvinience with xmllint and pathes, maybe switch to xmlstarlet?
qDebug() << "path=" << path;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment