Commit da010b2e authored by Laurent Montel's avatar Laurent Montel 😁

Fix All support

parent b3bccc06
...@@ -36,7 +36,7 @@ CategoryTypeComboBoxTest::~CategoryTypeComboBoxTest() ...@@ -36,7 +36,7 @@ CategoryTypeComboBoxTest::~CategoryTypeComboBoxTest()
void CategoryTypeComboBoxTest::shouldHaveDefaultValue() void CategoryTypeComboBoxTest::shouldHaveDefaultValue()
{ {
CategoryTypeComboBox w(true); CategoryTypeComboBox w(true);
QCOMPARE(w.count(), 4); QCOMPARE(w.count(), 5);
CategoryTypeComboBox w2(false); CategoryTypeComboBox w2(false);
QCOMPARE(w2.count(), 6); QCOMPARE(w2.count(), 6);
......
...@@ -56,7 +56,7 @@ void ConfigureCustomSettingWidgetTest::shouldHaveDefaultValue() ...@@ -56,7 +56,7 @@ void ConfigureCustomSettingWidgetTest::shouldHaveDefaultValue()
QVERIFY(lab); QVERIFY(lab);
QComboBox *categoryType = w.findChild<QComboBox *>(QStringLiteral("categorytype_combobox")); QComboBox *categoryType = w.findChild<QComboBox *>(QStringLiteral("categorytype_combobox"));
QVERIFY(categoryType); QVERIFY(categoryType);
QCOMPARE(categoryType->count(), 4); QCOMPARE(categoryType->count(), 5);
} }
void ConfigureCustomSettingWidgetTest::shouldRestoreRules_data() void ConfigureCustomSettingWidgetTest::shouldRestoreRules_data()
......
...@@ -25,9 +25,7 @@ ...@@ -25,9 +25,7 @@
CategoryTypeComboBox::CategoryTypeComboBox(bool customType, QWidget *parent) CategoryTypeComboBox::CategoryTypeComboBox(bool customType, QWidget *parent)
: QComboBox(parent) : QComboBox(parent)
{ {
if (!customType) { addItem(i18n("All"), QVariant::fromValue(LoggingCategory::All));
addItem(i18n("All"), QVariant::fromValue(LoggingCategory::All));
}
addItem(i18n("Info"), QVariant::fromValue(LoggingCategory::Info)); addItem(i18n("Info"), QVariant::fromValue(LoggingCategory::Info));
addItem(i18n("Debug"), QVariant::fromValue(LoggingCategory::Debug)); addItem(i18n("Debug"), QVariant::fromValue(LoggingCategory::Debug));
addItem(i18n("Warning"), QVariant::fromValue(LoggingCategory::Warning)); addItem(i18n("Warning"), QVariant::fromValue(LoggingCategory::Warning));
......
...@@ -118,8 +118,12 @@ LoggingCategory::List CustomDebugSettingsPage::rules() ...@@ -118,8 +118,12 @@ LoggingCategory::List CustomDebugSettingsPage::rules()
LoggingCategory::List lst; LoggingCategory::List lst;
const int number(mListWidget->count()); const int number(mListWidget->count());
for (int i = 0; i < number; ++i) { for (int i = 0; i < number; ++i) {
const KDebugSettingsUtil::LoadLoggingCategory cat = KDebugSettingsUtil::parseLineLoggingQtCategory(mListWidget->item(i)->text());
if (cat.isValid()) {
//TODO
}
#if 0 //FIXME #if 0 //FIXME
const LoggingCategory cat = KDebugSettingsUtil::parseLineLoggingQtCategory(mListWidget->item(i)->text());
if (cat.isValid()) { if (cat.isValid()) {
lst.append(cat); lst.append(cat);
} }
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment