-
Robert Knight authored
Bug fixes for the Appearance and Key Bindings tabs in the Edit Profile dialog: * Fix selection of color schemes and key bindings not being remembered after the color scheme/key binding list is changed (eg. due to adding a new color scheme or editing an existing one). This also fixes the preview not being updated when mousing outside the list after adding a new color scheme. -> After updates to the color scheme / key bindings list the model was being deleted and a new model was created. This caused the selection model to be changed without the signal-slot connections from the selection model to the dialog being re-established. This commit changes that so that the model is not replaced but simply cleared when the color scheme / key binding list is updated. * Disable the Edit, Remove buttons on the Appearance and Key Bindings tabs when there is no selection. * Fix crash when clicking 'New' button on the Appearance tab if the color scheme list is empty. * Fix crash when loading the Appearance tab if the color scheme associated with the profile does not exist * Fix crash when loading the Key Bindings tab if the key binding associated with the profile does not exist * Fix crash when attempting to load a color scheme with no name, instead the color scheme is simply not loaded. * Fix all colors except one being set to black when making changes to a color scheme which was based on the default fallback color scheme. -> When creating a new array inside the ColorScheme class to hold color entries, initialize its elements with values from the default color array. * Use qWarning() instead of qDebug() to print out error message if attempting to delete a color scheme fails. * Minor formatting changes in Session.cpp,SessionController.h Known bugs introduced by this commit: * Attempting to create a new keyboard translator when no existing translator is selected will crash because KeyboardTranslator::defaultTranslator() has not been implemented yet. svn path=/trunk/KDE/kdebase/apps/konsole/; revision=746071
9863b550