Skip to content
  • Wolfgang Bauer's avatar
    Fix ibeam and underline cursor rendering · eccfb1f6
    Wolfgang Bauer authored and Kurt Hindenburg's avatar Kurt Hindenburg committed
    Summary:
    Since anti-aliasing was enabled in the painter, coordinates need to
    be shifted half a pixel so that they align with the pixel grid,
    otherwise the result gets "blurred" due to the anti-aliasing.
    And as parts of the blurred shape leak outside the cursor rectangle,
    this also leaves artifacts when the cursor moves or blinks as these
    parts are not cleared.
    
    This is basically the same as commit
    e7085310 for the
    standard block cursor.
    
    BUG: 402589
    
    Test Plan:
    - Switch cursor shape to "I-Beam" or "Underline" in the "Advanced"
    profile settings
    
    The cursors are a single line again now, before they were blurred by
    anti-aliasing.
    
    Screenshots:
    Before:
    {F6656366}
    {F6656370}
    
    After:
    {F6656371}
    {F6656373}
    
    Also, there are no more artifacts when the cursor is moved or
    cursor blinking is enabled.
    
    Reviewers: #konsole, hindenburg
    
    Reviewed By: #konsole, hindenburg
    
    Subscribers: hindenburg, konsole-devel
    
    Tags: #konsole
    
    Differential Revision: https://phabricator.kde.org/D19513
    eccfb1f6