TerminalDisplay: Extract copying related functions
-
Developer
Hi, I am not sure that it's this commit which breaks my konsole but I rebuild it this morning and now each time that I select to copy a text in konsole, and I use mouse middle button for pasting it paste text as "editorsendcheckplugins
" => it's not goodbut CTRL+C/CTRL+V works fine.
Regardd
-
Developer
I think the bug is clear: text (line 2181) is created with the
ConvertToHtml
flag, and used for both plain text and html. Before this commit,selectedText()
was called twice, with different options, for plain text and for html. ThecopyToX11Selection
method needs to take two QStrings as input, one for each format. I would do it, but I'm on the stable branch, not master :-) -
Author Developer
Thanks for investigating, I'll look into it.
PS: Sorry for breaking it in the first place.
-
Author Developer
@mlaurent I'm not 100% sure I understand the bug correctly, but can you test whether !421 (merged) fixes it for you?
-
Developer
IIUC, the bug happens when you select text, then go to paste it with middle click, then you get the extra html tags. But if you copy the text, the paste it with e.g. Ctrl+V then everything works as expected and the copy text as HTML config option is respected.
-
Developer
@jbbgameich I confirm that !421 (merged) fix my bug. Thanks
-
mentioned in commit df9ec0ad
-
mentioned in commit 3baa2aa8