Commit 220013df authored by Kurt Hindenburg's avatar Kurt Hindenburg
Browse files

Simplify call and add notes about API

parent 0760b7ed
Pipeline #135126 passed with stage
in 2 minutes and 21 seconds
......@@ -48,7 +48,10 @@ BookmarkHandler::BookmarkHandler(KActionCollection *collection, QMenu *menu, boo
KBookmarkManager *manager = KBookmarkManager::managerForFile(_file, QStringLiteral("konsole"));
manager->setUpdate(true);
auto *bookmarkMenu = new BookmarkMenu(manager, this, _menu, toplevel ? collection : nullptr);
// This constructor is only called with toplevel as true; regardless the
// fourth argument can not be nullptr as it will crash in BookmarkMenu
// TODO: remove the toplevel boolean argument in API
auto *bookmarkMenu = new BookmarkMenu(manager, this, _menu, collection);
bookmarkMenu->setParent(this);
}
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment