Commit 43c14e98 authored by Ahmad Samir's avatar Ahmad Samir
Browse files

FileFilterHotspot: check the mime type before opening with text editor

When activating a file filter hot spot, everything got opened with the text
editor specified in the profile settings, which is wrong e.g. with pdf or
png files. Check the mime type of the file path, based only on the extension
so as to keep things fast.

Also rename openWithSysDefaultEditor() to openWithSysDefaultApp(), which is
more accurate.

BUG: 431496
parent 3150e259
......@@ -14,6 +14,7 @@
#include <QMenu>
#include <QTimer>
#include <QToolTip>
#include <QMimeDatabase>
#include <QMouseEvent>
#include <QKeyEvent>
#include <QRegularExpression>
......@@ -53,6 +54,13 @@ void FileFilterHotSpot::activate(QObject *)
QMimeDatabase mdb;
const QMimeType mimeType = mdb.mimeTypeForFile(_filePath, QMimeDatabase::MatchExtension);
if (!mimeType.inherits(QStringLiteral("text/plain"))) {
QString editorExecPath;
int firstBlankIdx = -1;
QString fullCmd;
......@@ -81,7 +89,7 @@ void FileFilterHotSpot::activate(QObject *)
// TODO: show an error message to the user?
if (editorExecPath.isEmpty()) { // Couldn't find the specified binary, fallback
if (firstBlankIdx != -1) {
......@@ -113,11 +121,11 @@ void FileFilterHotSpot::activate(QObject *)
const QString fCmd = editorExecPath + QLatin1Char(' ') + path;
openWithEditorFromProfile(fCmd, path);
} else { // Fallback
void FileFilterHotSpot::openWithSysDefaultEditor(const QString &filePath) const
void FileFilterHotSpot::openWithSysDefaultApp(const QString &filePath) const
auto *job = new KIO::OpenUrlJob(QUrl::fromLocalFile(filePath));
job->setUiDelegate(new KIO::JobUiDelegate(KJobUiDelegate::AutoHandlingEnabled, QApplication::activeWindow()));
......@@ -142,7 +150,7 @@ void FileFilterHotSpot::openWithEditorFromProfile(const QString &fullCmd, const
i18n("Could not open file with the text editor specified in the profile settings;\n"
"it will be opened with the system default editor."));
......@@ -57,7 +57,7 @@ public:
void keyPressEvent(TerminalDisplay *td, QKeyEvent *ev) override;
void openWithSysDefaultEditor(const QString &filePath) const;
void openWithSysDefaultApp(const QString &filePath) const;
void openWithEditorFromProfile(const QString &fullCmd, const QString &path) const;
void showThumbnail(const KFileItem& item, const QPixmap& preview);
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment