Skip to content
GitLab
Projects
Groups
Snippets
/
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
Utilities
Konsole
Commits
f37fbc1a
Commit
f37fbc1a
authored
Aug 06, 2022
by
Ahmad Samir
Browse files
Remove a redundant method from EditProfileDialog
parent
364ece1d
Changes
2
Hide whitespace changes
Inline
Side-by-side
src/widgets/EditProfileDialog.cpp
View file @
f37fbc1a
...
...
@@ -378,14 +378,9 @@ void EditProfileDialog::setProfile(const Konsole::Profile::Ptr &profile, EditPro
}
}
const
Profile
::
Ptr
EditProfileDialog
::
lookupProfile
()
const
{
return
_profile
;
}
const
QString
EditProfileDialog
::
currentColorSchemeName
()
const
{
const
QString
&
currentColorSchemeName
=
lookupP
rofile
()
->
colorScheme
();
const
QString
&
currentColorSchemeName
=
_p
rofile
->
colorScheme
();
return
currentColorSchemeName
;
}
...
...
@@ -395,7 +390,7 @@ void EditProfileDialog::preparePage(KPageWidgetItem *current, KPageWidgetItem *b
Q_ASSERT
(
current
);
Q_ASSERT
(
_pages
.
contains
(
current
));
const
Profile
::
Ptr
profile
=
lookupP
rofile
()
;
const
Profile
::
Ptr
profile
=
_p
rofile
;
auto
setupPage
=
_pages
[
current
].
setupPage
;
Q_ASSERT
(
profile
);
Q_ASSERT
(
setupPage
);
...
...
@@ -509,7 +504,7 @@ void EditProfileDialog::setupGeneralPage(const Profile::Ptr &profile)
void
EditProfileDialog
::
showEnvironmentEditor
()
{
bool
ok
;
const
Profile
::
Ptr
profile
=
lookupP
rofile
()
;
const
Profile
::
Ptr
profile
=
_p
rofile
;
QStringList
currentEnvironment
;
...
...
@@ -1042,7 +1037,7 @@ void EditProfileDialog::unpreview(Profile::Property prop)
void
EditProfileDialog
::
preview
(
Profile
::
Property
prop
,
const
QVariant
&
value
)
{
const
Profile
::
Ptr
original
=
lookupP
rofile
()
;
const
Profile
::
Ptr
original
=
_p
rofile
;
// skip previews for profile groups if the profiles in the group
// have conflicting original values for the property
...
...
@@ -1370,7 +1365,7 @@ void EditProfileDialog::updateButtonApply()
void
EditProfileDialog
::
setupKeyboardPage
(
const
Profile
::
Ptr
&
/* profile */
)
{
// setup translator list
updateKeyBindingsList
(
lookupP
rofile
()
->
keyBindings
());
updateKeyBindingsList
(
_p
rofile
->
keyBindings
());
connect
(
_keyboardUi
->
keyBindingList
->
selectionModel
(),
&
QItemSelectionModel
::
selectionChanged
,
this
,
&
Konsole
::
EditProfileDialog
::
keyBindingSelected
);
connect
(
_keyboardUi
->
newKeyBindingsButton
,
&
QPushButton
::
clicked
,
this
,
&
Konsole
::
EditProfileDialog
::
newKeyBinding
);
...
...
@@ -1435,7 +1430,7 @@ void EditProfileDialog::showKeyBindingEditor(bool isNewTranslator)
editor
->
setModal
(
true
);
if
(
translator
!=
nullptr
)
{
editor
->
setup
(
translator
,
lookupP
rofile
()
->
keyBindings
(),
isNewTranslator
);
editor
->
setup
(
translator
,
_p
rofile
->
keyBindings
(),
isNewTranslator
);
}
connect
(
editor
,
&
Konsole
::
KeyBindingEditor
::
updateKeyBindingsListRequest
,
this
,
&
Konsole
::
EditProfileDialog
::
updateKeyBindingsList
);
...
...
src/widgets/EditProfileDialog.h
View file @
f37fbc1a
...
...
@@ -92,7 +92,6 @@ public:
* and make it easy for them to change it.
*/
void
selectProfileName
();
const
Profile
::
Ptr
lookupProfile
()
const
;
public
Q_SLOTS
:
// reimplemented
...
...
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment