Commit f8e44c5d authored by Jekyll Wu's avatar Jekyll Wu

Rename method to reflect what it actually does.

setupCombo was actually used to setup checkboxes for boolean property.
parent 7ab1a5d6
...@@ -1023,7 +1023,7 @@ void EditProfileDialog::editKeyBinding() ...@@ -1023,7 +1023,7 @@ void EditProfileDialog::editKeyBinding()
{ {
showKeyBindingEditor(false); showKeyBindingEditor(false);
} }
void EditProfileDialog::setupCombo( ComboOption* options , const Profile::Ptr profile ) void EditProfileDialog::setupCheckBoxes( BooleanOption* options , const Profile::Ptr profile )
{ {
while ( options->button != 0 ) while ( options->button != 0 )
{ {
...@@ -1108,7 +1108,7 @@ void EditProfileDialog::showScrollBarRight() ...@@ -1108,7 +1108,7 @@ void EditProfileDialog::showScrollBarRight()
} }
void EditProfileDialog::setupAdvancedPage(const Profile::Ptr profile) void EditProfileDialog::setupAdvancedPage(const Profile::Ptr profile)
{ {
ComboOption options[] = { { _ui->enableBlinkingTextButton , Profile::BlinkingTextEnabled , BooleanOption options[] = { { _ui->enableBlinkingTextButton , Profile::BlinkingTextEnabled ,
SLOT(toggleBlinkingText(bool)) }, SLOT(toggleBlinkingText(bool)) },
{ _ui->enableFlowControlButton , Profile::FlowControlEnabled , { _ui->enableFlowControlButton , Profile::FlowControlEnabled ,
SLOT(toggleFlowControl(bool)) }, SLOT(toggleFlowControl(bool)) },
...@@ -1124,7 +1124,7 @@ void EditProfileDialog::setupAdvancedPage(const Profile::Ptr profile) ...@@ -1124,7 +1124,7 @@ void EditProfileDialog::setupAdvancedPage(const Profile::Ptr profile)
SLOT(togglebidiRendering(bool)) }, SLOT(togglebidiRendering(bool)) },
{ 0 , 0 , 0 } { 0 , 0 , 0 }
}; };
setupCombo( options , profile ); setupCheckBoxes( options , profile );
// interaction options // interaction options
_ui->wordCharacterEdit->setText( profile->property<QString>(Profile::WordCharacters) ); _ui->wordCharacterEdit->setText( profile->property<QString>(Profile::WordCharacters) );
......
...@@ -230,13 +230,13 @@ private: ...@@ -230,13 +230,13 @@ private:
const char* slot; const char* slot;
}; };
void setupRadio(RadioOption* possible,int actual); void setupRadio(RadioOption* possible,int actual);
struct ComboOption struct BooleanOption
{ {
QAbstractButton* button; QAbstractButton* button;
int property; int property;
const char* slot; const char* slot;
}; };
void setupCombo(ComboOption* options , const Profile::Ptr profile); void setupCheckBoxes(BooleanOption* options , const Profile::Ptr profile);
const Profile::Ptr lookupProfile() const; const Profile::Ptr lookupProfile() const;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment