Nicolas Fella authored May 19, 2022 and Tomaz Canabrava committed May 23, 2022

The current name is not descriptive at all

The setting is still buried rather deep, but at least it has a somewhat better name now

BUG: 454034

Luis Javier Merino authored May 19, 2022 and Tomaz Canabrava committed May 23, 2022

Commit e2167eb0 restricted deactivating the word-wise/line-wise
selection mode to mouse presses with no modifiers.  Since in
mouse-tracking mode, the Shift key has to be pressed to not pass mouse
events to the application running on the terminal, there was no way to
end word-wise/line-wise selection mode without sending a mouse event to
the application.

Modify the logic so ending word-wise/line-wise selection mode is done by
a LMB button press with no modifiers on non-mousetracking mode, and by a
LMB button press with only the Shift modifier on mousetracking mode.

BUG: 408048

Ahmad Samir authored Apr 22, 2022 and Tomaz Canabrava committed May 23, 2022

And ensure deprecation warnings for bot Qt and KF versions higher than the
specified ones are shown when building.

Ahmad Samir authored Apr 25, 2022 and Tomaz Canabrava committed May 23, 2022

KConfigGroup::sync() calls the parent KConfig object's sync(), so running
the latter once at the end should be enough, AFAICS.

Ahmad Samir authored Apr 24, 2022 and Tomaz Canabrava committed May 23, 2022

KColorSchemeManager (from KConfigWidgets) was changed in 5.89 to handle
loading/saving the selected color scheme automatically if
KColorSchemeManager::setAutosaveChanges(true) is used (it auto saves by
default, but calling setAutosaveChanges(true) makes it easier to understand
the code).

However this is conditional on KConfigWidgets >= 5.93 because that's where
the KColorSchemeManager::createSchemeSelectionMenu() overload used here was
changed to load the previously saved color scheme.

Since KColorSchemeManager uses "ColorScheme" as the config entry name,
migrate the old config entry when KF >= 5.93.

Waqar Ahmed authored Dec 17, 2021 and Tomaz Canabrava committed May 23, 2022

When you do a selection, characters jump. This s a lot worse if
you enable "Underline Files" as then characters are jumping all the
time.

Example of such characters are, icon chars from the result of `ls-deluxe` or
`exa`.

Luis Javier Merino authored Jul 06, 2021 and Tomaz Canabrava committed May 23, 2022

After 6667d96e broke scrolling, and apparently neither c9f77e52 nor MR
!413 where able to totally fix it for all use cases, applying the
restriction to cells only when sending mouse tracking events should fix
all remaining warts.

Matan Ziv-Av authored Feb 26, 2022 and Tomaz Canabrava committed May 23, 2022

Still needs some work.

Matan Ziv-Av authored Mar 04, 2022 and Tomaz Canabrava committed May 23, 2022

It does something, actually, so fix a bug in OSC 1337 state machine: we start the machine on the first character, so process the character immediately after starting the machine.

Luis Javier Merino authored May 18, 2022 and Kurt Hindenburg committed May 23, 2022

When selecting, the last line gets an added newline if the characters
returned from copyLineToStream() are less than the cells selected on that
last line.

A weird behaviour was that after running:

printf '                   v\n'
printf '\e[KSELECT ME\n'
printf '\e[31m\e[Kselect me\n'
printf '\e[0m                   ^\n'

selecting "SELECT ME          " would add a newline, while
selecting "select me          " would not add a newline.

This is a side-effect of clearImage() resizing lines which end with
spaces with the default rendition, so selecting the "SELECT ME" line
would get a count of 9 characters, which would make selecting more than
the initial 9 characters add a newline, while the "select me" line would
have additional spaces with isRealCharacter == false and a non-default
rendition.

Solve it but making copyLineToStream() not count and not pass to
PlainTextDecoder trailing characters where isRealCharacter == false.

Luis Javier Merino authored May 18, 2022 and Kurt Hindenburg committed May 23, 2022

Otherwise, weirdness ensues.  e.g. if you do:

seq 1 $((LINES)); printf '\e[31m\ec'

and try to select the blank lines, the selection shows the previous
rendition color.

It's been split to a separate header in KConfigWidgets 5.93.

Luis Javier Merino authored May 14, 2022 and Kurt Hindenburg committed May 16, 2022

Commit c3b3ef19 introduced a regression when invoking the
clear-history-and-reset action.  While RIS (Reset to Initial State) is
specified in DEC STD-070 as homing the cursor, konsole has grown some
hacks in the name of usability to preserve the command prompt line.

For a long time, it has sent two SIGWINCH with changed sizes after clear
and reset actions to force the shell to redraw the prompt (see d346a2cc,
temporarily disabled on 5d61b69e and re-added on 82778e87), which works
for bash, zsh, ksh, ...

tcsh doesn't redraw its prompt on SIGWINCH, but commit b8e96bcd modified
Screen::refresh() so instead of clearing the entire screen and homing
the cursor, it scrolled up everything but the last (usually the prompt)
line.

So, keep that last hack when called from clear-history-and-reset, and
behave as specified on DEC STD-070 otherwise.

Note that other ways of clearing the screen don't need hacks, e.g.
Ctrl-L, if handled at all, is handled by the shell, which then redraws
its prompt.  Calling "clear" or invoking "printf '\ec'" will result in
the shell redrawing its prompt in the usual way.

BUG: 453568

When using konsoleprofile multiple settings can be specified separated by
semicolons. The usage output and documenting comments now reflect this.
Also fixes the link to Profile.h.

Ahmad Samir authored May 04, 2022 and Kurt Hindenburg committed May 08, 2022

- Default constructed Profile::Ptr is null
- QHash is empty by default

(cherry picked from commit f9058091)

Oswald Buddenhagen authored Mar 07, 2022 and Tomaz Canabrava committed May 02, 2022

... rather than using a side channel to propagate the window size.

amends 7a27f407.

Oswald Buddenhagen authored Mar 07, 2022 and Tomaz Canabrava committed May 02, 2022

also remove the redundant pty()->setWinSize() call in the fallback
case, as it does the same as the subsequent code.