- 05 May, 2021 2 commits
-
-
Commits 9ffe33a2 and 4352df00 introduce and use a getScreenLineColumns(line) method to provide support for DECDWL (Double-Width) lines. It turns out that under some conditions on resize Screen::_cuY (the current cursor Y position) and ScreenWindow::endWindowLine() can have different ideas of how many lines the terminal has. A test that asserts: - while [ true ]; do echo -e "\e[?1047h"; done - Resize the window, making it smaller BUG: 436327
-
Restore Y coordinate before X coordinate, so we make sure Y is in bounds before trying to access _lineProperties depending on Y. To test: - Go to the last line - tput sc - Shrink the terminal - tput rc
-
- 03 May, 2021 4 commits
-
-
* Using internal erase function instead of While loop. * Just clear if there is only one line.
-
Declaring it where there is no change in content and enable compiler to perform better optimizations.
-
It is removing the vector of lines storage. Now it is using a similar idea used in history file. All chars are stored in a linear way, only the line indexes are changed when reflowing. No speed problem found when removing lines.
-
Friedrich W. H. Kossebau authored
GIT_SILENT
-
- 01 May, 2021 1 commit
-
-
Carlos Alves authored
When you open settings and close it, than open a new window, than close the old window, the MainWindow with the settings will delete the configDialog. If you try to open settings againg it crashes. Fix is each MainWindow now has its own configDialog. BUG: 436366
-
- 30 Apr, 2021 1 commit
-
-
Kurt Hindenburg authored
-
- 29 Apr, 2021 1 commit
-
-
Alexander Lohnau authored
-
- 28 Apr, 2021 1 commit
-
-
Carlos Alves authored
When needed CompactHistoryBlock can now increase from 256kb to a bigger size. BUG: 436031
-
- 26 Apr, 2021 2 commits
-
-
Nicolas Fella authored
This fixes the rendering on highdpi screens
-
- 25 Apr, 2021 1 commit
-
-
Yuri Chornoivan authored
-
- 24 Apr, 2021 1 commit
-
-
Add three layouts to the toolbar; add --layout <file> to the command line. The 3 defaults layouts are 2x2, 2x1, 1x2 GUI:
-
- 21 Apr, 2021 1 commit
-
-
Script Kiddy authored
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
-
- 17 Apr, 2021 16 commits
-
-
Kurt Hindenburg authored
-
Kurt Hindenburg authored
-
Kurt Hindenburg authored
-
Kurt Hindenburg authored
-
Kurt Hindenburg authored
-
Konsole wasn't really keeping track of changes to line rendition attributes, and was just always marking for update the top line of double-height lines. This didn't account for double-width lines, changes back to single-width single-height, and did not provide proper support for separate rendering of the bottom of double-height lines. The effect can be seen on vttest "Test of known bugs" (9) -> "Erase right half of double-width lines" (8), where a line is changed from single-width to double-width and back. The line wasn't re-rendered on each change, as it should. Can also be tested with: echo -e "\e[2J\e[1;1HTEST\n"; sleep 1; echo -e "\e[1;1H\e#6\e[2;1H"
-
Double height lines are actually two lines, the first with the top part of the characters, the second with the bottom part. Reflowing could lead to situations where we render a top part, a double height line with its top and bottom parts, and a bottom part, which looks weird.
-
There is a difference with xterm behavior: when the screen width is an odd number of columns, xterm allows selecting up to columns/2+1, we just allow selecting up to columns/2.
-
While DECDHL/DECDWL lines are not wrapped at the correct column, now at least reflowing doesn't clear line rendition attributes, so resizing Konsole and going back to the original size always recovers the original content, including double-height/double-width status of each line. Reflowing double-height lines doesn't make much sense, since a double-height line actually consists of a top (T) and a bottom (B) line. Shrinking them could lead to TTBB lines, which look weird. At least now going back to the original size brings back the original content in all its glory.
-
The scrollback buffer has support for a wrapped property for every line. Extend it to support the line rendition attributes.
-
While DECHDL sequences should be used in pairs on adjacent lines, the first line drawing the top half, and the second line drawing the bottom half, apparently real VTxxx (or at least the VT220) terminals did draw only the top or bottom of characters when confronted with an isolated DECDHL line (https://retrocomputing.stackexchange.com/questions/18023/). xterm has that same behavior. So behave likewise.
-
TerminalDisplay::getCharacterPosition() should take double-width lines into account to return the right column.
-
EL (Erase Line) should not reset the line rendition attribute to single-width. ED (Erase Display) should only reset it for completely cleared lines. ECH (Erase CHaracters) should obviously not reset it. DECSED and DECSEL (Selective Erase, not supported by Konsole) should not reset it. This fixes a vttest test where a line is set to double-height-top and then EL before writing its text and the double-height-bottom line below. Can also be tested with: echo -e "\e[2J\e[4;1HNormal\n\e#6DOUBLE\n\e#6DOUBLE\nNormal" && sleep 2; echo -e "\e[5;3H\e[1J\e[8;1H"
-
Some control functions special case the last column. When a line has been set to double-width via DECDWL or DECDHL (double-height and double-width), the correcr last column for that line should be used. Control functions which special case the last column include TAB, CUF, ICH and DECRC. Can be tested with: perl -E '$r=join "", map{$_%10}1..80; say "\e<\e[?40h\e[?3l\e[?7l$r"; $s="L"."\tx"x4 ."\t\tR"; say "\e#3$s\n\e#4$s"' The above tests that tabs don't travel beyond the last column in double-width lines. The last column (below columns 79 and 80 of the previous line) should have an "R". perl -E '$r=join "", map{$_%10}1..80; say "\e<\e[?40h\e[?3l\e[?7h$r"; $s="L"."X"x36 ."\e[6C"."R"; say "\e#3$s\n\e#4$s"' The above tests that CUF (Cursor Forward) doesn't travel beyond the last column in double-width lines. The last column (below columns 79 and 80 of the previous line) should have an "R". perl -E '$r=join "", map{$_%10}1..80; say "\e<\e[?40h\e[?3l\e[?7h$r"; $s="L"."X"x22 ."R"."x"x8 ."r"."\e[17D\e[16@"; say "\e#3$s\n\e#4$s"' The above tests that ICH (Insert CHaracters; VT200+) doesn't write past the last column, visible on repaints (switch to another window and back). perl -E '$r=join "", map{$_%10}1..80; say "\e<\e[?40h\e[?3l\e[?7h$r"; $s="L"."X"x38 ."r\e7\e[H\e8R"; say "\e#3$s\n\e#4$s"' The above tests that DECRC (Restore Cursor) doesn't restore the cursor to a position beyond the last column on double-width lines. The last column should have an "R", "r" should not be visible. perl -E '$r=join "", map{$_%10}1..80; say "\e<\e[?40h\e[?3l\e[?7l$r"; $s="L"."X"x38 ."R"; print "\e#6$s"'; sleep 5; echo The above tests that the cursor stays at the rightmost column. The cursor should stay over the "R" for 5 seconds.
-
Since double-width/double-height lines have room for just half the characters, take that into account. Can be tested with: perl -E '$r=join "", map{$_%10}1..80; say "\e<\e[?40h\e[?3l\e[?7h$r"; $s="L"."X"x38 ."RL"; say "\e#6$s"' The above tests that appending characters to double-width lines in DECAWM (Auto Wrap Mode) wraps at the correct last column. There should appear a second line (single-width) with a single "L". perl -E '$r=join "", map{$_%10}1..80; say "\e<\e[?40h\e[?3l\e[?7l$r"; $s="L"."X"x42 ." TEST FAILED OUTOFBOUNDS R"; say "\e#6$s"' The above tests that appending characters to double-width lines in non-DECAWM (Auto Wrap Mode) doesn't write past the last column (visible on repaints - switch to another window and back). The last column (below columns 79 and 80 of prev line) should have an "R".
-
When there were several runs of double width/double height runs with differing color/rendition/line draw/..., the second and subsequent runs were positioned wrong. Fix the calculation of the starting x position to account for double width, and fix a bug were the y position was incremented for every run instead of for every line. Can be tested with: perl -E '$s="\e[0mTEST\e[32mTEST\e[0m"; say "\e#3$s\n\e#4$s"'
-
- 16 Apr, 2021 2 commits
-
-
Kurt Hindenburg authored
-
-
- 14 Apr, 2021 1 commit
-
-
Heiko Becker authored
(cherry picked from commit f4fad3bb)
-
- 12 Apr, 2021 2 commits
-
-
Laurent Montel authored
-
Laurent Montel authored
-
- 06 Apr, 2021 1 commit
-
-
Ahmad Samir authored
KPageDialog already creates the accepted()/rejected() connections, since the code here created another connection, the accept() slot was being called twice for each OK button click, with e.g. the profile name empty, clicking Ok: - the first time isProfileNameValid() would return false, and the saving would abort, as it should - the second time around, isProfileNameValid() would return true since the name has been reverted to the original value in the Name line edit The same goes for the reject() slot. Also use a lambda instead of apply(), it's a very small method and this was the code is more readable, since we don't need to jump back and forth.
-
- 05 Apr, 2021 2 commits
-
-
Nate Graham authored
It needed a few more tweaks to be fully consistent and gramatically correct in English.
-
Nate Graham authored
-
- 04 Apr, 2021 1 commit
-
-
- If the QObject has a parent, the parent will take care of deleting it - Use std::unique_ptr to manage pointer member variable - Use '= default' with empty destructors - Fix initialization of QTimer in constructor initialization list
-