1. 23 Dec, 2019 1 commit
  2. 18 Apr, 2019 1 commit
  3. 16 May, 2018 1 commit
    • Mariusz Glebocki's avatar
      Change internal character type size to 32 bit · 5128781a
      Mariusz Glebocki authored
      Summary:
      Currently Unicode uses 0x10FFFF code points. It is possible to represent
      all of them with up to two 16 bit values (UTF-16), but this makes it
      harder to e.g. check for their width.
      
      Some test cases were changed. Originally they were added with an
      assumption that the code point will be truncated to 16 bit value and
      as a result changed to another code point.
      
      Test Plan:
      * All code points <= 0xFFFF should work as before
        * Start the same tmux session in two Konsoles
        * Change background to fully transparent in one of them and put it in
          front of the other one, so that all text will overlap
        * Generate characters with (you can pipe it to `fold -s | less -r`):
      ```
      perl -XCSDL -e 'print map{chr($_), " "} 1..0xffff'
      ```
        * Compare output visually.
      
      * Code points > 0xFFFF should not be truncated to 16 bits
        * "𝐀" and "퐀" should be different characters
      
      * Some code points > 0xFFFF should have single width
        * Vertical lines below should align:
      ```
      |𝐀 |
      |𠀋|
      ```
      
      Reviewers: #konsole, hindenburg
      
      Reviewed By: #konsole, hindenburg
      
      Subscribers: konsole-devel, hindenburg, #konsole
      
      Tags: #konsole
      
      Differential Revision: https://phabricator.kde.org/D12236
      5128781a
  4. 10 May, 2018 1 commit
    • Ahmad Samir's avatar
      Fix scoping issues with Screen::DecodingOptions · a78d525e
      Ahmad Samir authored
      Summary:
      Move the Q_DECLARE_OPERATORS_FOR_FLAGS macro declaration for the
      DecodingOption enum to the Konsole namespace. This should fix a bug that
      happens when KeyboardTranslator.h is included in Screen.h (either
      directly or indirectly), where the compiler doesn't find the |() operator
      of the QFlags class.
      
      I haven't pinpointed where the conflicting |() operator is coming from
      exactly, but moving the macro declaration to the Konsole namespace
      matches how other QFlags are used through out the code (and matches
      upstream doc examples).
      
      Test Plan:
      - Add this include to Screen.h and try to compile:
        #include "KeyboardTranslator.h"
      
      - The compilation fails in SessionController.cpp:
      error: invalid conversion from 'int' to 'Konsole::Screen::DecodingOption'
      The line it fails on is 1200:
      QString selectedText = _view->screenWindow()->selectedText(Screen::PreserveLineBreaks | Screen::TrimLeadingWhitespace | Screen::TrimTrailingWhitespace);
      
      - Apply the diff and build again, the build should complete
      
      I tested the options from the DecodingOption enum from the Screen class and they still work as before
      
      Reviewers: #konsole, hindenburg
      
      Reviewed By: #konsole, hindenburg
      
      Subscribers: hindenburg, konsole-devel
      
      Tags: #konsole
      
      Differential Revision: https://phabricator.kde.org/D12797
      a78d525e
  5. 07 Feb, 2018 1 commit
  6. 04 Feb, 2018 1 commit
  7. 13 Jan, 2018 1 commit
  8. 06 Jan, 2018 1 commit
  9. 25 Dec, 2017 1 commit
  10. 11 Jun, 2017 1 commit
  11. 30 May, 2017 1 commit
  12. 27 Apr, 2017 1 commit
  13. 11 Apr, 2017 1 commit
  14. 22 Jan, 2017 1 commit
  15. 16 Jul, 2016 2 commits
    • Kurt Hindenburg's avatar
      Add rendition flags SGRs 2, 8, 9, 53 · c8da8f3b
      Kurt Hindenburg authored
      Adds faint intensity, strikeout, conceal and overline support.
      
      echo -e 'D\e[2mD\e[9mD\e[53mD\e[8mD'
      
      Thanks to Antonio Russo antonio e russo gmail com for patch
      
      REVIEW: 128405
      BUG: 362171
      (cherry picked from commit 84b43dfb)
      c8da8f3b
    • Kurt Hindenburg's avatar
      Add rendition flags SGRs 2, 8, 9, 53 · 84b43dfb
      Kurt Hindenburg authored
      Adds faint intensity, strikeout, conceal and overline support.
      
      echo -e 'D\e[2mD\e[9mD\e[53mD\e[8mD'
      
      Thanks to Antonio Russo antonio e russo gmail com for patch
      
      REVIEW: 128405
      BUG: 362171
      84b43dfb
  16. 07 Jul, 2016 1 commit
    • Martin Tobias Holmedahl Sandsmark's avatar
      Preserve current line when resetting · b8e96bcd
      Martin Tobias Holmedahl Sandsmark authored
      Reset was always called with clearScreen = true, so no point in having
      that variable. We can probably also remove Screen::clear() and
      Screen::home(), they're not used anymore, and weren't really useful
      before this either.
      
      We still preserve the scrollback history when resetting, which is not
      what other terminal emulators do (http://stackoverflow.com/a/5367075),
      but we do have a separate action for it, so I think it is a nice extra
      feature to preserve it.
      
      REVIEW: 128389
      b8e96bcd
  17. 29 May, 2016 1 commit
  18. 11 Oct, 2015 1 commit
  19. 04 Oct, 2014 1 commit
  20. 17 May, 2013 1 commit
  21. 10 Jan, 2013 1 commit
  22. 20 Dec, 2012 1 commit
  23. 09 Sep, 2012 1 commit
    • Kurt Hindenburg's avatar
      Allow option to trim spaces at end of line · ca9dd11b
      Kurt Hindenburg authored
      In the ongoing issue with spaces at the end of lines, this allows for
      an option to trim the spaces.  By default, it is disabled so only
      people who need this will be affected.
      
      Many thanks to David Smid <david@smidovi.eu>
      
      CCBUG: 188528
      ca9dd11b
  24. 23 May, 2012 1 commit
  25. 13 May, 2012 1 commit
  26. 29 Mar, 2012 1 commit
  27. 17 Mar, 2012 1 commit
  28. 04 Mar, 2012 1 commit
  29. 20 Feb, 2012 1 commit
  30. 24 Dec, 2011 1 commit
    • Kurt Hindenburg's avatar
      Apply astyle-kdelibs · 30a4fa66
      Kurt Hindenburg authored
      Over the years, the coding style is all over the place.
      
      Use 'git diff -w --ignore-all-space' to see non-whitespace changes.
      30a4fa66
  31. 05 Nov, 2011 3 commits
  32. 04 Nov, 2011 1 commit
  33. 02 Nov, 2011 1 commit
  34. 01 Nov, 2011 1 commit
  35. 14 Oct, 2011 1 commit
  36. 26 Jun, 2011 1 commit
  37. 14 Apr, 2011 1 commit