GitLab

REVIEW: 129914
Signed-off-by: Anthony Fieroni <bvbfan@abv.bg>
(cherry picked from commit d8b242f3)

container-anti-pattern, detaching-temporary, incorrect-emit

All the other loops use foreach - keep them constant for when they
are converted from Q_FOREACH - clang range-loop issues

This setting is intended to be used to workaround fonts that lack some
characters that are taller than _fontAscent

REVIEW: 129901

Thanks to Maximiliano Curia for spotting it.

clazy-container-anti-pattern clazy-range-loop

Treat "\e]0;<title>\e\\" (set window title) the same way
it interprets "\e]0;<title>\007".

It seems that Konsole does not recognize the standard string terminator
sequence "\e\\" (ESC \). Everything works fine if I use "\007" (BEL).

<http://invisible-island.net/xterm/xterm.faq.html#how2_title>

Thanks to Aniketh Girish anikethgireesh gmail com and Martin Sandsmark
martin sandsmark kde org for patch/review

BUG:231405
REVIEW:129895

Make sure we re-use the process if the user wants a new tab.

BUG: 373440
REVIEW: 129886

Special case parsing of -e, to avoid parsing parameters intended for the
command to be executed.

REVIEW: 129677

This seems to be the limit in all the test files I've been trying.
Without this we get an issue with too many combining characters where
Konsole will eventually just hang.

REVIEW: 129874

BUG: 199381
REVIEW: 129837

Without this it doesn't correctly detect word boundaries e. g. in
arabic.

REVIEW: 129840

For our own sanity we (falsely) assume that all surrogate characters are
double width, otherwise we have to go back and reflow the line.

This makes it work better with emojis in vim at least.

REVIEW: 129841

CCBUG:373440

Other masterFd() have checks and it might prevent certain crashes in
Session::isForegroundProcessActive().

frameworks/konsole/src/Session.cpp:839:5: warning: 'not' is not defined,
evaluates to 0 [-Wundef]