1. 31 Mar, 2008 1 commit
    • Robert Knight's avatar
      BUG: 149626 - Use the KDE shortcut editor widget to edit shortcuts in the Manage Profiles dialog. · 2c9e073c
      Robert Knight authored
      (Requires recent kdelibs rv. 792234 for the 'Clear' button to work)
      
      Squashed commit of the following:
      
      commit d60cba88cc4c4027220558cf6fe5487022beb767
      Author: Robert Knight <robertknight@gmail.com>
      Date:   Mon Mar 31 19:05:00 2008 +0100
      
          Make the Favorite column toggle respond to double click events as well so that quick clicks in succession are not ignored.
      
      commit 5dd0730a2a838a88d50a91dc7a70ec2ffda23c4b
      Author: Robert Knight <robertknight@gmail.com>
      Date:   Mon Mar 31 19:02:33 2008 +0100
      
          Allow more width for the Shortcut column in the Manage Profiles dialog so that the shortcut editor has enough room.
      
      commit 2271b154b1d3c03442827b7553a827ab0b199344
      Author: Robert Knight <robertknight@gmail.com>
      Date:   Mon Mar 31 17:58:14 2008 +0100
      
          Do not draw shortcut text whilst a shortcut is being edited.  Move styled background drawing into new class.
      
      commit 4b06713f63d41b0df22fa2e03ab3f7e90be8ab9f
      Author: Robert Knight <robertknight@gmail.com>
      Date:   Mon Mar 31 17:35:57 2008 +0100
      
          Prevent profile shortcut being cleared as soon as editing starts - do not connect to the keySequenceChanged() signal until after the existing shortcut has been applied to the editor.  Change edit triggers for table view to start editing when a selected item is clicked.
      
      commit 84ff71e40a1e6b9993c45d8fc17c6aba3a5e25a5
      Author: Robert Knight <robertknight@gmail.com>
      Date:   Mon Mar 31 17:09:07 2008 +0100
      
          Use KDE shortcut edit widget to edit shortcuts in Manage Profiles dialog.  Rename ProfileItemDelegate to FavoriteItemDelegate and introduce a new ShortcutItemDelegate for the shortcut column which uses KKeySequenceWidget to edit shortcuts.
      
      svn path=/trunk/KDE/kdebase/apps/konsole/; revision=792245
      2c9e073c
  2. 30 Mar, 2008 8 commits
  3. 29 Mar, 2008 1 commit
    • Diego Iastrubni's avatar
      New backport (??) from KDE3: now each profile can enable/disable BiDi... · 60f0a0a5
      Diego Iastrubni authored
      New backport (??) from KDE3: now each profile can enable/disable BiDi rendering in the display. We need this since many console based application (vim, emacs, fribidi etc)
      implement their own BiDi algorithm. There is also another reason: comatibility. All terminals are *not* aware of the BiDi issue and do not re-order the chars
      (gnome-terminal, xterm, konsole, etc). It is possible to enable the BiDi rendering on each profile, so this is not a huge lost. I am still missing the keyboard shortcut to
      quickly enable/disable it (alt+control+b in konsole3), but I am not sure what is the best way for doing it.
      
      A quick note about the implementation:
      In QPainter3, there was an option to draw a text and tell the painter "please do not implement BiDi". In QPainter4 (up to 4.4) there is no such option. I am forcing it by
      drawing  "painter.drawText(rect,0,QChar(0x202D)+text)" (that is &LRO;), and it does seem to work, but I find it kinda "hackish". I will open a task in Trolltech and
      request that new feature. Hopefully by Qt4.5/KDE4.2 I will be able to change the implementation.
      
      
      svn path=/trunk/KDE/kdebase/apps/konsole/; revision=791374
      60f0a0a5
  4. 28 Mar, 2008 1 commit
  5. 27 Mar, 2008 2 commits
  6. 26 Mar, 2008 2 commits
  7. 25 Mar, 2008 1 commit
  8. 24 Mar, 2008 3 commits
  9. 23 Mar, 2008 2 commits
  10. 22 Mar, 2008 3 commits
    • Robert Knight's avatar
      Close tabs when clicked with middle mouse button. · 18a5c86a
      Robert Knight authored
      BUG: 137938
      
      svn path=/trunk/KDE/kdebase/apps/konsole/; revision=788960
      18a5c86a
    • Robert Knight's avatar
      Squashed commit of the following: · 5036d8cb
      Robert Knight authored
      commit 99d61f9bdfe29347050162a5a675bb0c276bc1bf
      Author: Robert Knight <robertknight@gmail.com>
      Date:   Sat Mar 22 20:45:45 2008 +0000
      
          Allow a normal frame around the table view in ManageProfilesDialog.  Works better with Oxygen style.
      
      commit 7075de00d8cc88568e108e868e08d071d5aa7bcb
      Author: Robert Knight <robertknight@gmail.com>
      Date:   Sat Mar 22 20:37:38 2008 +0000
      
          Change base class of ProfileItemDelegate from QItemDelegate to QStyledItemDelegate for better rendering.  Fix updates of favorite / non-favorite status in ManageProfilesDialog.  QVariant equality comparisons are not properly supported for custom types so QAbstractItemModel::match() has to be replaced with manual iteration through the rows.
      
      commit 3baa3307473e037efd500ade7df37d2fd62c60d9
      Author: Robert Knight <robertknight@gmail.com>
      Date:   Sat Mar 22 20:09:27 2008 +0000
      
          Remove unecessary deleteProfile() call.  Explicitly add new profiles to the SessionManager.  Mark the temporary profile in the EditProfileDialog as hidden.
      
      commit 53d1e3515d3408c08ba4b019b5faceffae6b0f8a
      Author: Robert Knight <robertknight@gmail.com>
      Date:   Sat Mar 22 20:02:28 2008 +0000
      
          Do not track deletion of temporary un-named profiles.
      
      commit 55c69e15a4247319b0cff73691f072fef39684c9
      Author: Robert Knight <robertknight@gmail.com>
      Date:   Sat Mar 22 20:01:25 2008 +0000
      
          Make SessionManager::addProfile() public.  Call it automatically in SessionManager::setFavorite() if the profile is not already known to the manager.  When a profile is deleted via SessionManager::deleteProfile() mark it as hidden so that it is not recreated on disk if later changed.  Add debugging in ~Profile to track deletion of profiles.
      
      commit 7a028bac5846cd3689e3351ab139c6f372ca173e
      Author: Robert Knight <robertknight@gmail.com>
      Date:   Sat Mar 22 19:41:22 2008 +0000
      
          Fix several signal/slot connections in ManageProfilesDialog after the SessionManager changes.
      
      commit da7c7b4f939c17885cf0fbaa1fb93d2655021b83
      Author: Robert Knight <robertknight@gmail.com>
      Date:   Sat Mar 22 19:36:57 2008 +0000
      
          Use a helper class to pop elements from recursion guard stack when a call to loadProfile() returns rather than requiring a manual call to recursionGuard.pop()
      
      commit 14a993d15722ec5270de708154408896fd7418b8
      Author: Robert Knight <robertknight@gmail.com>
      Date:   Sat Mar 22 19:12:20 2008 +0000
      
          Fix profiles not being loaded properly if their parent was a profile which had already been loaded.  Profile paths were not being taken off the recursion guard stack at one exit from loadProfile().
      
      commit f946fc0cbde26cd816e3f1d172a5e5327ff3295b
      Author: Robert Knight <robertknight@gmail.com>
      Date:   Sat Mar 22 19:01:06 2008 +0000
      
          Adapt Part to the SessionManager/Profile changes.
      
      commit d3155ba0f6dc9ec0ca34a45b5787488c055dc4bf
      Author: Robert Knight <robertknight@gmail.com>
      Date:   Sat Mar 22 18:55:05 2008 +0000
      
          Update MainWindow API documentation to reflect string key -> ref counted pointer change for profiles.
      
      commit 5d546054c031ae6ee6915f2cc6bcf61dd4e03520
      Author: Robert Knight <robertknight@gmail.com>
      Date:   Sat Mar 22 18:53:16 2008 +0000
      
          Update SessionManager API documentation to reflect string key -> ref counted pointer change for profiles.
      
      commit 856fdf37a5bd81711ff0db1b307b8736ef4ae34e
      Author: Robert Knight <robertknight@gmail.com>
      Date:   Thu Mar 20 23:43:53 2008 +0000
      
          Fix assert.  Fall back to current locale's codec if a null pointer is passed to Emulation::setCodec()
      
      commit 127e894d076061b991934adf84256b651bf31724
      Author: Robert Knight <robertknight@gmail.com>
      Date:   Thu Mar 20 22:45:11 2008 +0000
      
          Replace string key for profiles with ref-counted profile pointer.
      
      commit 53246e5bd4ffcec56ca0ff94730f9ef3946e3f4c
      Author: Robert Knight <robertknight@gmail.com>
      Date:   Thu Mar 20 20:50:17 2008 +0000
      
          First step towards removing string keys as a means to reference profiles.  Change Profile base class from QObject to QSharedData and replace all usage of Profile* with KSharedPtr<Profile>
      
      svn path=/trunk/KDE/kdebase/apps/konsole/; revision=788936
      5036d8cb
    • Robert Knight's avatar
      Do not print a warning if the shell exits with a non-zero exit code. Only... · ede5253a
      Robert Knight authored
      Do not print a warning if the shell exits with a non-zero exit code.  Only print a warning if the program actually crashed.  Non-zero exits happen frequently for shells whoose exit code is the exit code from the last command executed in them.
      
      svn path=/trunk/KDE/kdebase/apps/konsole/; revision=788666
      ede5253a
  11. 20 Mar, 2008 1 commit
  12. 19 Mar, 2008 9 commits
  13. 18 Mar, 2008 6 commits