GitLab

Adriaan de Groot authored Oct 18, 2021 and Kurt Hindenburg committed Oct 29, 2021

- the foreground informaton **is** not updated by this function
- not all callers call updateForegroundProcessInfo() afterwards
- other functions have a call to updateForegroundProcessInfo()
  inside, so the whole thing is moot
- this commit message is 5x as long as the comment it removes

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

CCBUG: 373440

Ahmad Samir authored Sep 23, 2021 and Kurt Hindenburg committed Oct 25, 2021

TerminalColor::onColorsChanged() used to be called updateScrollbarColors(),
now that KColorSchemeManager is integrated in Konsole, users can choose a
colour scheme for the whole window widget style, where tabs, scrollbar,
findbar, right-click context menu are all the same colour as you'd expect
from any KDE application.

This removes dimming of the scrollbar when the "dim when inactive" option is
disabled, the scrollbar is part of the window GUI, it should follow the same
color scheme.

2a71f063
25e07b7e
72d604c6

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

From !510

Luis Javier Merino Morán <ninjalj@gmail.com>

Luis Javier Merino authored Oct 20, 2021 and Tomaz Canabrava committed Oct 22, 2021

Commit 8de0e6c7 mistakenly removed code to cancel the pending wrap flag
(which in konsole is implemented as having the cursor one past the width
of the screen) before the cursor controls CUU, CUD, CUB and BS.

While the behavior may seem counter-intuitive (specially BS and CUB,
where `printf "A\bB"` at the last column results in `BA`), this is the
behavior of VT100, xterm (without reverse-wraparound mode), and, most
importantly, is expected by ncurses.

CCBUG: 399615

Ahmad Samir authored Oct 07, 2021 and Kurt Hindenburg committed Oct 21, 2021

- Call ProfileSettings::slotAccepted() when the parent ConfigurationDialog
  is accepted, so that ProfileManager::saveSettings() is called
- don't delete the ProfileSettings dialog on accept, it'll be destroyed when
  the parent ConfigurationDialog is destroyed
- save the profiles' shorcuts if they were actually changed

With this commit and the previous one, there is no need for ~Part() or
~Application() to call saveSettings(), shorcuts settings are saved when
the ProfileSettings dialog is accepted and saving the default profile is
done in setDefaultProfile(). This fixes an issue where changing e.g. the
default profile is only saved to the konsolerc file when the main window is
closed.

Ahmad Samir authored Oct 07, 2021 and Kurt Hindenburg committed Oct 21, 2021

It doesn't seem useful to delay saving to when the the MainWindow destructor
calls ProfileManager::saveSettings().

This seems to be fallout from a previous refactor to put all the global
settings dialogs in one parent dialog (ConfigurationDialog), because now
nothing actually calls ProfileSettings::slotAccepted().

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Instead use a vector of struct, this expands to less code, and the overhead
of a hash table isn't needed here.

Adriaan de Groot authored Oct 18, 2021 and Kurt Hindenburg committed Oct 20, 2021

CSI 28 ; <c> t is a pre-KDE4-era (from the comments) extension to
the control codes, where <c> was supposed to set the text-color
on a tab. It is unimplemented since KDE4, and only generated
a debug-message when used. Remove its implementation and the
TODO's associated with "document the meaning of this parameter".
Because there's no point in documenting an unimplemented thing.

Ahmad Samir authored Oct 09, 2021 and Kurt Hindenburg committed Oct 19, 2021

Cheaper than constructing a QFileInfo.

Ahmad Samir authored Oct 06, 2021 and Kurt Hindenburg committed Oct 19, 2021

- Don't use a QHash to hold a few profile shortcuts-related items, instead
use a vector of struct.

- Load profile shortcuts after loading the profiles; after commit
50041fd0, all the profiles are loaded in the ProfileManager constructor.
Now there is no need to store the profile path as a member in ShortcutData;
and when saving the shortcut settings we can use profile->name(), since the
way the ProfileWriter works results in the filename being the
profile name + ".profile". When loading shortcuts, keep backwards
compatibility by checking for both "profile name" and "profile name.profile".

Ahmad Samir authored Oct 09, 2021 and Kurt Hindenburg committed Oct 19, 2021

To differentiate between it and the ProfileList class.

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

This lets people find Konsole with some common-seeming words that they
might search for if they need to run a script or CLI program and they
aren't super familiar with Konsole or CLI stuff in general.

Ahmad Samir authored Oct 06, 2021 and Kurt Hindenburg committed Oct 12, 2021

- More range-for
- Reverse iterators instead of java-style ones with toBack/hasPrevious
- Don't use a QSet (which is based on QHash) to hold a few items

James Beddek authored Oct 10, 2021 and Kurt Hindenburg committed Oct 12, 2021

Convert std::array to a static const built-in array

BUG: 443420

Signed-off-by: James Beddek <telans@posteo.de>

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Now all the profiles are loaded in the constructor; I didn't see any
noticeable difference in loading times.

Also all the profiles are loaded anyway because ProfileList calls
ProfileManager::allProfiles() to populate the profiles menu ...etc.

Nathan Sprangers authored Oct 07, 2021 and Kurt Hindenburg committed Oct 07, 2021

Avoid referencing an empty string
Initialize _isDefault

Prior commit:
ce18a9c8

There is an inconsistence in "Find Next/Previous" icons in Edit menu and
the search bar. Make sure they are consistent whenever "Search backwards"
is checked or not.

BUG: 443244

(cherry picked from commit c6e0e5ff)

Nathan Sprangers authored Sep 29, 2021 and Kurt Hindenburg committed Sep 29, 2021

Add a checkbox to the Edit Profile dialog to set/unset the profile as
the default profile. Responds to the Apply and Ok buttons like other
dialog settings. Unchecking (and clicking Apply/Ok) sets the fallback
profile as the default.

Ahmad Samir authored Sep 16, 2021 and Kurt Hindenburg committed Sep 27, 2021

When parsing keytab files, the title line is simple enough, so we can
handle it with string operations, which are usually faster than using a
regex.