1. 29 Oct, 2021 1 commit
    • Adriaan de Groot's avatar
      Remove misleading comment · 3b3dd14d
      Adriaan de Groot authored and Kurt Hindenburg's avatar Kurt Hindenburg committed
      - the foreground informaton **is** not updated by this function
      - not all callers call updateForegroundProcessInfo() afterwards
      - other functions have a call to updateForegroundProcessInfo()
        inside, so the whole thing is moot
      - this commit message is 5x as long as the comment it removes
  2. 20 Oct, 2021 1 commit
    • Adriaan de Groot's avatar
      Remove pre-KDE4-era unimplemented Konsole-specific extension · 79efe5ce
      Adriaan de Groot authored and Kurt Hindenburg's avatar Kurt Hindenburg committed
      CSI 28 ; <c> t is a pre-KDE4-era (from the comments) extension to
      the control codes, where <c> was supposed to set the text-color
      on a tab. It is unimplemented since KDE4, and only generated
      a debug-message when used. Remove its implementation and the
      TODO's associated with "document the meaning of this parameter".
      Because there's no point in documenting an unimplemented thing.
  3. 06 Sep, 2021 1 commit
  4. 13 Aug, 2021 1 commit
    • Christoph Cullmann's avatar
      improve session closing behavior · 3d967a59
      Christoph Cullmann authored and Ahmad Samir's avatar Ahmad Samir committed
      the new session close behavior is again the old
      - first send SIGHUP and wait one second if that works
      - then hard kill
      before we tried to send an EOF character
      this needed workaround to not kill "non shell" programs
      unexpected and doesn't work e.g. if
      - you have some not finished command input in your shell
      - on e.g. FreeBSD in general
      When closing the session with some background process still running:
      - using Ctrl+D (which sends EOF) will leave that background process running
        (which is the expected behaviour with e.g. BASH:
      - using e.g. the close button on the titlebar will close the session and kill any background processes
      You can also use 'somecommand & disown', if you want to ensure background processes
      aren't killed when you close a konsole window.
      BUG: 401898
      CCBUG: 185140
  5. 08 Jul, 2021 1 commit
  6. 01 Jun, 2021 1 commit
    • Adriaan de Groot's avatar
      Allow sessions with /bin/sh · 5871a53c
      Adriaan de Groot authored
      The existing code scans through `programs` to find an acceptable
      shell to start; `_program` is the shell that is configured for
      the session (line 456). The first shell to be found from that
      list, is assigned to `exec` and we'll run that shell.
      If the shell found wasn't the one configured (e.g. one of the
      other ones from the list) then a warning is printed, but we carry on.
      **However**, if the shell found is the **last** one in the list
      (i.e. `/bin/sh`) then a warning is printed and the shell does
      not start.
      If the configured shell is `/bin/sh` this obviously breaks down:
      it is found (as the first one in the list!) but still equals the
      last one; the warning is printed and nothing runs.
      It is unclear **why** `/bin/sh` is not allowed as a shell:
      it exists, it's an executable, and it's an interactive shell.
      Curiously, configuring the shell as `sh` for the session runs
      `/bin/sh` in the end, but just tricks the logic here:
       - `checkProgram("sh")` returns `sh` as string,
       - so the comparison against `/bin/sh` fails,
       - and we can run `sh` .. which is `/bin/sh`.
      There's no good reason to forbid `/bin/sh`, so change the check to
      **only** fail if no shell was found at all (`exec` stayed empty)
      or if the found shell behaves weirdly (is not equal to itself).
  7. 31 Mar, 2021 1 commit
  8. 15 Feb, 2021 1 commit
  9. 09 Feb, 2021 1 commit
  10. 16 Jan, 2021 1 commit
  11. 05 Jan, 2021 1 commit
  12. 03 Jan, 2021 1 commit
    • Carlos Alves's avatar
      Adding version checks to deprecated functions · 5bbb4334
      Carlos Alves authored
      Macros to check frameworks versions and switch from deprecated functions
      to newer versions.
      KProcess: pid -> processId
      KCodecAction: setDelayed -> setPopupMode
      KActionMenu: triggered -> codecTriggered
  13. 13 Dec, 2020 1 commit
  14. 12 Dec, 2020 1 commit
    • Oswald Buddenhagen's avatar
      ensure that window size is correct before starting session (again) · 2a6e520a
      Oswald Buddenhagen authored
      commit b84c0f49 replaced the previous hack, clearly failing to notice
      that in-thread qobject conections are direct by default. we need to make
      the competing connection queued instead.
      this remains a hack; a proper solution would be avoiding the instant
      resize by skipping the initialization to 80x25, but i'm not going to
      touch any of that mess.
      BUG: 412598
  15. 21 Nov, 2020 1 commit
  16. 19 Nov, 2020 1 commit
  17. 13 Nov, 2020 2 commits
  18. 23 Oct, 2020 1 commit
  19. 11 Oct, 2020 1 commit
  20. 07 Oct, 2020 1 commit
  21. 04 Oct, 2020 1 commit
  22. 03 Oct, 2020 1 commit
    • Martin Tobias Holmedahl Sandsmark's avatar
      Add possibility of peeking primary screen · e45cda95
      Martin Tobias Holmedahl Sandsmark authored
      Good explanation from Tomaz (he's better with words than me):
          I think he wants to quick swap the text from primary and secondary screens:
              ls folder
              vim somefile.txt
              - mmm, what's the name of the file I need, I just did the LS for that reason -
              peek into primary screen, note the file name, go back to secondary screen
      Merge request:
  23. 28 Sep, 2020 1 commit
  24. 26 Sep, 2020 1 commit
    • Martin Hostettler's avatar
      Match OSC reply sequence terminator to OSC request terminator. · f4bc91f1
      Martin Hostettler authored and Kurt Hindenburg's avatar Kurt Hindenburg committed
      Traditionally konsole only was able to parse OSC sequences terminated with
      non-standard BEL. In 324d78c0 konsole was extended to parse sequences
      terminated by 7-bit ST (ESC \) as well. But the OSC responses were still
      hardcoded to reply only with sequences with BEL. But replying to 7-bit ST
      terminated sequences with a reply terminated by a non-standard terminator
      is wrong.
      This commit passes the terminator along and changes the response to match
      the original request.
      printf "\033]10;?\a" replies with "^[]10;rgb:fcfc/fcfc/fcfc^G"
      printf "\033]10;?\033\\" replies with "^[]10;rgb:fcfc/fcfc/fcfc^[\"
  25. 27 Jul, 2020 1 commit
  26. 24 Jul, 2020 1 commit
  27. 22 Jul, 2020 2 commits
  28. 15 Jul, 2020 1 commit
  29. 12 Jul, 2020 3 commits
  30. 29 May, 2020 1 commit
    • Ahmad Samir's avatar
      [SessionController] Fix crash caused by text encoding menu · e7e8e9d1
      Ahmad Samir authored and Kurt Hindenburg's avatar Kurt Hindenburg committed
      QMenu since 5.15 is hidden when an action is triggered, this caused a
      crash in Konsole when trying to access the text encoding menu.
      Now Session emits a signal when the text encoding is changed, the
      SessionController can connect to that singal to set the current codec in
      the KCodecAction object.
      Also fix the EditProfileDialog so that when the KCodecAction menu is
      shown the currently set codec is selected.
      BUG: 419526
      FIXED-IN: 20.08
  31. 28 May, 2020 1 commit
  32. 22 May, 2020 1 commit
  33. 20 May, 2020 1 commit
  34. 10 May, 2020 1 commit
  35. 27 Apr, 2020 1 commit
  36. 11 Apr, 2020 1 commit
    • Sebastian Badur's avatar
      Add openTeletype option for use without shell · 9ceae8d1
      Sebastian Badur authored
      The user might want to open a teletype in a Session or a Part without an additional shell interfering / in background (e.g. pty to /bin/vi).
      Therefore, a new optional argument is introduced to run a pty process standalone. Consistency is held with legacy method calls.