1. 01 Dec, 2021 1 commit
  2. 29 Nov, 2021 2 commits
  3. 28 Nov, 2021 1 commit
  4. 26 Nov, 2021 1 commit
  5. 23 Nov, 2021 3 commits
    • snooxx's avatar
      Fix changing non-Breeze scrollbar colors at runtime · 564ae1fa
      snooxx authored and Tomaz  Canabrava's avatar Tomaz Canabrava committed
      72d604c6 refactored terminal color handling. This breaks changing
      scrollbar colors at runtime for non-Breeze widget styles, since the
      relevant `QEvents` will only be handled by `QWidget`-based classes, but
      not by the `QObject`-based class the code was moved to.
      
      Moving the event handling back will fix the issue.
      
      Test Plan:
      - start Konsole with Fusion widget style
      - change application color scheme from dark to light: scrollbar color
        should match widget colors, without having to restart Konsole
      564ae1fa
    • snooxx's avatar
      Adapt scrollbar to terminal color scheme for Breeze widget style again · 8d2582b0
      snooxx authored and Tomaz  Canabrava's avatar Tomaz Canabrava committed
      2a71f063 changed the scrollbar background to match the terminal color
      scheme. This looks fine for the Breeze widget style, but fails for
      non-Breeze styles such as Fusion or Plastique. Sometimes scrollbars
      would be only barely visible, in other cases the scrollbar would look
      really out of place (e.g. very dark scrollbar on white terminal
      background with light widget colors).
      
      92e19c63 then unconditionally removed the color matching functionality,
      so scrollbars would always use the (as of dc8ad830 application-specific)
      widget color scheme. This solves the accessibily issues, but might be
      considered a step backwards for Breeze trying to blend into the app's content.
      
      In !402 adding a configuration toggle to let users disable color
      matching was turned down. Instead, automatically switching behavior
      depending on the current widget style was suggested. Obviously this is
      less than ideal from a maintenance perspective and might look like magic
      for users, but seems like the best option left at this point.
      
      After this patch, Breeze users will get scrollbar colors matched to the
      terminal color scheme as intended in 2a71f063. Scrollbars of non-Breeze
      users will be colored according to the widget color scheme as
      implemented in 92e19c63, which is also how it looked before 2a71f063
      landed. Changing widget styles at runtime is fully supported.
      
      Implementation-wise, note that `MenuStyle` is a `QProxyStyle` applied to
      the whole application, which slightly affects how to determine the
      current widget style in use.
      
      In the future, styles shall only be added to the allowlist if they look
      good with both light and dark terminal background colors (e.g Fusion
      currently does not qualify, because while the scrollbar might look
      acceptable with a dark background, the coloring algorithm in Konsole
      does not provide adequate scrollbar coloring with light backgrounds).
      
      Test Plan:
      - start Konsole with Breeze widget style
      - change background color in terminal profile from black to white:
        scrollbar color should match terminal background
      - change application color scheme from light to dark: scrollbar color
        should be unaffected
      - change widget style to Fusion in "kcmshell5 kcm_style"
      - change background color in terminal profile from white to black:
        scrollbar color should be unaffected
      - change application color scheme from dark to light: scrollbar color
        should match widget colors
      (The last step will only work without restarting Konsole once the third
      patch in this series has been applied.)
      8d2582b0
    • snooxx's avatar
      Revert "Let the scrollbar follow the app color scheme" · 3e652002
      snooxx authored and Tomaz  Canabrava's avatar Tomaz Canabrava committed
      This reverts commit 92e19c63.
      
      The code to adapt the scrollbar color to the terminal color scheme will
      still be needed in a subsequent patch. There it will be restricted to
      the Breeze widget style and thus retain the behavior of the reverted
      patch for non-Breeze styles.
      3e652002
  6. 22 Nov, 2021 1 commit
  7. 12 Nov, 2021 1 commit
  8. 08 Nov, 2021 1 commit
  9. 02 Nov, 2021 1 commit
  10. 31 Oct, 2021 1 commit
  11. 30 Oct, 2021 1 commit
  12. 29 Oct, 2021 4 commits
  13. 28 Oct, 2021 1 commit
  14. 27 Oct, 2021 1 commit
  15. 26 Oct, 2021 1 commit
  16. 25 Oct, 2021 3 commits
  17. 24 Oct, 2021 1 commit
  18. 22 Oct, 2021 3 commits
  19. 21 Oct, 2021 4 commits
    • Ahmad Samir's avatar
      Define a KSharedConfigPtr as a member and re-use it · ccfed788
      Ahmad Samir authored and Kurt Hindenburg's avatar Kurt Hindenburg committed
      ccfed788
    • Ahmad Samir's avatar
      Optimise saving profile shortcuts · c24a0876
      Ahmad Samir authored and Kurt Hindenburg's avatar Kurt Hindenburg committed
      - Call ProfileSettings::slotAccepted() when the parent ConfigurationDialog
        is accepted, so that ProfileManager::saveSettings() is called
      - don't delete the ProfileSettings dialog on accept, it'll be destroyed when
        the parent ConfigurationDialog is destroyed
      - save the profiles' shorcuts if they were actually changed
      
      With this commit and the previous one, there is no need for ~Part() or
      ~Application() to call saveSettings(), shorcuts settings are saved when
      the ProfileSettings dialog is accepted and saving the default profile is
      done in setDefaultProfile(). This fixes an issue where changing e.g. the
      default profile is only saved to the konsolerc file when the main window is
      closed.
      c24a0876
    • Ahmad Samir's avatar
      Save the config when setDefaultProfile() is called · 4a64904a
      Ahmad Samir authored and Kurt Hindenburg's avatar Kurt Hindenburg committed
      It doesn't seem useful to delay saving to when the the MainWindow destructor
      calls ProfileManager::saveSettings().
      
      This seems to be fallout from a previous refactor to put all the global
      settings dialogs in one parent dialog (ConfigurationDialog), because now
      nothing actually calls ProfileSettings::slotAccepted().
      4a64904a
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · ca7842a6
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      ca7842a6
  20. 20 Oct, 2021 2 commits
    • Ahmad Samir's avatar
      Don't use a QHash to hold a few items · 19c33b4d
      Ahmad Samir authored
      Instead use a vector of struct, this expands to less code, and the overhead
      of a hash table isn't needed here.
      19c33b4d
    • Adriaan de Groot's avatar
      Remove pre-KDE4-era unimplemented Konsole-specific extension · 79efe5ce
      Adriaan de Groot authored and Kurt Hindenburg's avatar Kurt Hindenburg committed
      CSI 28 ; <c> t is a pre-KDE4-era (from the comments) extension to
      the control codes, where <c> was supposed to set the text-color
      on a tab. It is unimplemented since KDE4, and only generated
      a debug-message when used. Remove its implementation and the
      TODO's associated with "document the meaning of this parameter".
      Because there's no point in documenting an unimplemented thing.
      79efe5ce
  21. 19 Oct, 2021 5 commits
  22. 18 Oct, 2021 1 commit