GitLab

Its correspoding UI in the EditProfileDialog is changed from
checkbox to combobox.

REVIEW:102742

The current behaviro is any mofification is applied immediately and
can't be canceled. So 'Ok' and 'Apply' are duplicated/unnecessary and
'Cancel' doesn't do what its name implies.

REVIEW: 102707

setupCombo was actually used to setup checkboxes for boolean property.

Maybe QCombobox is enough for such task, but just use KComboBox for
consistency for now.

Block *var ==> Block* var

erase()    ==> eraseChar()
setErase() ==> setEraseChar()

"if (enable)"  is more natural than " if (!enable)" .

Ctrl+Shift+A is already taken by 'monitor-activity', and Ctrl+Shift+S
is already taken by 'close-active-view'.

No functionality change. Just make it more readable.

CCBUG:276872
REVIEW:102685

tabmode ==> tabBarMode
tabPosition ==> tabBarPosition

BUG: 186561
FIXED-IN: 4.8
REVIEW: 102502

- Rename it into 'Switch Profile' to avoid potential confusion.
- Also put it under the 'Settings' menu.

TODO: rename related methods which use 'change' in their names.

BUG: 245795
FIXED-IN:4.8
REVIEW: 102686

When user selects only 1 profile to be listed in menu, it makes the
'New Tab->' list unnecessary.  No profile will listed if the only
selected profile is the default one.

Patch by Francesco Cecconi <francesco.cecconi@gmail.com>

BUG: 245478
REVIEW: 102670
FIXED-IN: 4.8

In SessionManger, rename info to profile to better show what's going on.

Patch by Gu Rui <chaos.proton@gmail.com>
REVIEW: 102603

Allows user to select a shortcut to jump to the far right tab.  There
is no default shortcut.

Patch by Francesco Cecconi <francesco.cecconi@gmail.com>
REVIEW: 102687
BUG: 279166
FIXED-IN: 4.8

KDE's menuBar()->isTopLevelMenu() hasn't worked for a while.  Without a
replacement, let's just put the menus inside the main window.  This
also makes the keyboard shortcut to show menus look reasonable (instead
of floating).

However, some KDE headers are still only available in the form of
"#include <ksomething.h>"

krun.h              ==>     KRun
kicon.h             ==>     KIcon
kdebug.h            ==>     KDebug
kshell.h            ==>     KShell
kdialog.h           ==>     KDialog
kconfig.h           ==>     KConfig
klocale.h           ==>     KLocale
kglobal.h           ==>     KGlobal
kcolorutils.h       ==>     KColorUtils
kconfiggroup.h      ==>     KConfigGroup
kdesktopfile.h      ==>     KDesktopFile
kcolorscheme.h      ==>     KColorScheme
kstandarddirs.h     ==>     KStandardDirs
ktemporaryfile.h    ==>     KTemporaryFile
klocalizedstring.h  ==>     KLocalizedString

This is a simple one-line patch, so it can be reverted easily if
unfortunately needed.

BUG:192221
FIXED-IN:4.8
REVIEW:102177