GitLab

This effectively reverts the change which was made to ask for
confirmation when powering off. That issue needs to be reworked in
next feature release, but for now just revert it since the current
implementation should cause more annoyance than benefit.

BUG: 301458
FIXED-IN: 4.9.0
CCBUG: 127194

    Previously, the count could be a huge negative number which could
    exceed what an int can handle.  Also, there's no reason to calculate
    this number if it will be negative.

    CCBUG: 246484

BUG: 301476
FIXED-IN: 4.9.0

The old cold is copied from kio/kurlcompletion.cpp, which is not
very suitable for detecting and expanding environment variables. For
example, it only sees ' ' and '/' as the end point of an environment
variable. That assumption fails easily with the common example of
"PATH=$PATH:~/bin"

It feels strange that those properties are set again in Pty::start()
after they (should) have already been set before Pty::start() is called

I was stupid enough to assuem zsh was everywhere. But I really hope
that would become the reality some day.

It is more natural to use column x line.

TODO: The current code is inconsistent with itself regarding this issue

This is mostly extra safeguard, since they alreayd do not get keyboard focus
in the current code.

Thanks to Lindsay Roberts<linds.r@gmail.com> for the research and patch

BUG: 168769
FIXED-IN: 4.9.0
REVIEW: 105121

Another stupid mistake by me. Wonder why it goes unnoticed for
such a long time.

CCMAIL: lueck@hube-lueck.de

@ Kurt andJekyll: in 4.9 konsole lost the default shortcut F3 for findNext?
CCMAIL:adaptee@gmail.com
CCMAIL:kurt.hindenburg@gmail.com

See https://git.reviewboard.kde.org/r/105028/

This might feel like slight de-optimization of current code. However, it
helps abstracting and refactoring the code for the future.