1. 19 Sep, 2021 1 commit
    • Harald Sitter's avatar
      log into category · 7383c16d
      Harald Sitter authored
      otherwise every focus switch spams the journal if qdebug is routed to
      journald
      7383c16d
  2. 15 Sep, 2021 5 commits
  3. 10 Sep, 2021 1 commit
  4. 09 Sep, 2021 1 commit
  5. 08 Sep, 2021 1 commit
  6. 06 Sep, 2021 3 commits
  7. 05 Sep, 2021 1 commit
  8. 03 Sep, 2021 1 commit
  9. 02 Sep, 2021 5 commits
  10. 01 Sep, 2021 1 commit
    • Ahmad Samir's avatar
      The default navigation method should be TabbedNavigation · e693f2d7
      Ahmad Samir authored
      TabbedNavigation is when we have a MainWindow, i.e. the typical use case;
      whereas NoNavigation is when using Konsole Part. The code in Part calls
      setNavigationMethod(NoNavigation), so things should work as before.
      
      I made a wrong assumption that TabbedNavigation was already the default.
      
      CCBUG: 432077
      e693f2d7
  11. 31 Aug, 2021 3 commits
  12. 30 Aug, 2021 1 commit
  13. 27 Aug, 2021 1 commit
  14. 22 Aug, 2021 1 commit
    • Ahmad Samir's avatar
      Only emit empty() in SessionFinished() when in TabbedNavigation mode · 2684bc7f
      Ahmad Samir authored
      empty() is emitted so that MainWindow calls close() and we get rid of the
      colours-flashing bug when closing the last session/tab in a window, see
      commit bbec7225. However all that isn't relevant when we are in
      konsole Part mode, where there are no tabs or MainWindows.
      
      This fixes a crash in Dolphin when closing its window while the embedded
      Konsole Part is open. The crash would happen as calling
      ViewContainer::currentTabViewCount() would end up in the ViewSplitter code
      path, which is no-op in Konsole Part.
      
      To test:
      - Open dolphin, make sure the terminal panel isn't open to begin with
      - open the terminal panel
      - close the dolphin window while the terminal panel is open
      
      BUG: 441206
      FIXED-IN: 21.08.1
      2684bc7f
  15. 20 Aug, 2021 1 commit
  16. 15 Aug, 2021 1 commit
  17. 13 Aug, 2021 2 commits
    • Christoph Cullmann's avatar
      improve session closing behavior · 3d967a59
      Christoph Cullmann authored and Ahmad Samir's avatar Ahmad Samir committed
      the new session close behavior is again the old
      
      - first send SIGHUP and wait one second if that works
      - then hard kill
      
      before we tried to send an EOF character
      this needed workaround to not kill "non shell" programs
      unexpected and doesn't work e.g. if
      
      - you have some not finished command input in your shell
      - on e.g. FreeBSD in general
      
      When closing the session with some background process still running:
      - using Ctrl+D (which sends EOF) will leave that background process running
        (which is the expected behaviour with e.g. BASH:
        https://lists.gnu.org/archive/html/bug-bash/2009-03/msg00091.html)
      - using e.g. the close button on the titlebar will close the session and kill any background processes
      
      You can also use 'somecommand & disown', if you want to ensure background processes
      aren't killed when you close a konsole window.
      
      BUG: 401898
      CCBUG: 185140
      3d967a59
    • Jonathan Esk-Riddell's avatar
      set soversion manually rather than use year · c65a8c5b
      Jonathan Esk-Riddell authored and Tomaz  Canabrava's avatar Tomaz Canabrava committed
      c65a8c5b
  18. 12 Aug, 2021 1 commit
    • Ahmad Samir's avatar
      Prevent window "flashing" when closing the last session · bbec7225
      Ahmad Samir authored
      There are two scenarios when closing a window:
      A) clicking the close button on the title bar (or Ctrl+Shift+Q):
      ~MainWindow()
      ~ViewManager()
      ~TabbedViewContainer()
      ~TerminalDisplay()
      ~Session()
      
      B) closing the last session/tab in a window:
      SessionController::sessionFinished()
      ~Session()
      ~TerminalDisplay()
      ~TabbedViewContainer()
      ~MainWindow()
      ~ViewManager()
      
      the issue with the second case is that the TerminalDisplay is torn down
      first, which exposes the TabbedViewContainer widget, the latter has the same
      Qt::Window colour as the system colour scheme window background colour, if
      you're using a dark terminal colour scheme and a light-coloured system colour
      scheme, you could see some "flashing" when you close the last session with
      e.g. Ctrl+D.
      
      To fix this, in sessionFinished() check if TabbedViewContainer::count() is
      1 (i.e. closing last tab/session), and emit the empty() signal in that case,
      which is connected to MainwWindow::close(), then the order of tear down
      becomes:
      SessionController::sessionFinished()
      ~Session()
      ~MainWindow()
      ~ViewManager()
      ~TabbedViewContainer()
      ~TerminalDisplay()
      
      BUG: 432077
      FIXED-IN: 21.12
      bbec7225
  19. 06 Aug, 2021 2 commits
  20. 05 Aug, 2021 2 commits
    • Ahmad Samir's avatar
      Add an option to disable thumbnails generation · aba8bb03
      Ahmad Samir authored and Tomaz  Canabrava's avatar Tomaz Canabrava committed
      aba8bb03
    • Ahmad Samir's avatar
      Fix crash when closing a tab using the close button · 39d3437d
      Ahmad Samir authored and Tomaz  Canabrava's avatar Tomaz Canabrava committed
      Looking at the crash backtraces from the bug reports, it seems this is what
      happens, when you have two tabs open, then click the close button on the
      non-current tab:
        - QTabBar::currentChanged() is emitted, the TerminalDisplay pointer is
          still not null at this point (the code checks for that)
        - TabbedViewContainer::currentTabChanged()
        - TabbedViewContainer::activeViewChanged()
        - ViewManager::activateView(), at this point the TerminalDisplay pointer
          could be null, which then crashes when we call Widget::setFocus()
      
      BUG: 411962
      FIXED-IN: 21.12
      39d3437d
  21. 04 Aug, 2021 1 commit
  22. 03 Aug, 2021 1 commit
  23. 02 Aug, 2021 3 commits