1. 07 Jun, 2021 6 commits
  2. 05 Jun, 2021 1 commit
  3. 01 Jun, 2021 1 commit
    • Adriaan de Groot's avatar
      Allow sessions with /bin/sh · 5871a53c
      Adriaan de Groot authored
      The existing code scans through `programs` to find an acceptable
      shell to start; `_program` is the shell that is configured for
      the session (line 456). The first shell to be found from that
      list, is assigned to `exec` and we'll run that shell.
      
      If the shell found wasn't the one configured (e.g. one of the
      other ones from the list) then a warning is printed, but we carry on.
      **However**, if the shell found is the **last** one in the list
      (i.e. `/bin/sh`) then a warning is printed and the shell does
      not start.
      
      If the configured shell is `/bin/sh` this obviously breaks down:
      it is found (as the first one in the list!) but still equals the
      last one; the warning is printed and nothing runs.
      
      It is unclear **why** `/bin/sh` is not allowed as a shell:
      it exists, it's an executable, and it's an interactive shell.
      
      Curiously, configuring the shell as `sh` for the session runs
      `/bin/sh` in the end, but just tricks the logic here:
       - `checkProgram("sh")` returns `sh` as string,
       - so the comparison against `/bin/sh` fails,
       - and we can run `sh` .. which is `/bin/sh`.
      
      There's no good reason to forbid `/bin/sh`, so change the check to
      **only** fail if no shell was found at all (`exec` stayed empty)
      or if the found shell behaves weirdly (is not equal to itself).
      5871a53c
  4. 25 May, 2021 1 commit
  5. 24 May, 2021 2 commits
    • Luis Javier Merino's avatar
      Fix crash when using a color scheme with random colors · 8c24953b
      Luis Javier Merino authored and Kurt Hindenburg's avatar Kurt Hindenburg committed
      A new assert in GCC 11.1.0 std::piecewise_linear_distribution fails in
      the case that the lower and upper boundaries are equal.  So, make sure
      to not construct a std::piecewise_linear_distribution when minSaturation
      equals maxSaturation and when minLightness equals maxLightness.
      
      BUG: 434892
      8c24953b
    • Ahmad Samir's avatar
      Fix type of randomSeed parameter · b7f6849d
      Ahmad Samir authored
      It should be uint. I am not sure this fixes the mentioned bug, but it's
      correct anyway, std::mt19937 and co. unsigned types; and we shouldn't mix
      signed with unsigned.
      
      CCBUG: 434892
      b7f6849d
  6. 23 May, 2021 1 commit
  7. 16 May, 2021 1 commit
    • Ahmad Samir's avatar
      Don't override profile icon in "New Tab" menu · e03a4680
      Ahmad Samir authored
      We only need to set the favourite emblem for the default profile icon, for
      other profiles, the profile icon is already set on the menu action.
      
      Rename a lambda to a more meaningful name.
      
      BUG: 437200
      FIXED-IN: 21.08
      e03a4680
  8. 07 May, 2021 1 commit
  9. 06 May, 2021 1 commit
  10. 05 May, 2021 3 commits
  11. 03 May, 2021 4 commits
  12. 01 May, 2021 1 commit
    • Carlos Alves's avatar
      Fix crash showing Settings Dialog · 49692c0f
      Carlos Alves authored
      When you open settings and close it, than open a new window, than
      close the old window, the MainWindow with the settings will
      delete the configDialog. If you try to open settings againg it crashes.
      
      Fix is each MainWindow now has its own configDialog.
      
      BUG: 436366
      49692c0f
  13. 30 Apr, 2021 1 commit
  14. 29 Apr, 2021 1 commit
  15. 28 Apr, 2021 1 commit
  16. 26 Apr, 2021 2 commits
  17. 25 Apr, 2021 1 commit
  18. 24 Apr, 2021 1 commit
  19. 21 Apr, 2021 1 commit
  20. 17 Apr, 2021 9 commits