1. 22 Jan, 2021 6 commits
    • Carlos Alves's avatar
      Small changes to STL and qBound · 8c57c842
      Carlos Alves authored
      Where it was possible:
      - 'For' to STL copy or fill (it is like using memcpy and memset, faster
      than for, the compiler decides the best algo to perform the task);
      - qMin(qMax) to qBound.
      Changes in: TeminalDisplay and TerminalColor
    • Carlos Alves's avatar
      Test HistoryType change · 8cf4601b
      Carlos Alves authored
      Unlimited to Fixed Size must have the fixed size information preserved.
      Fixed Size to Unlimited must have all the information preserved.
      All types to None all information must be erased.
    • Carlos Alves's avatar
      Add Reflow test to HistoryTest · 4cee7e23
      Carlos Alves authored
      While testing I found a bug in CompactHistoryScroll add function, it
      should append before check the vector size and not after, it was
      returning a Size > Max Size, not equal.
      Another Bug found in fixed size history scroll, it was not properly
      reflowing the last line, a position problem when adding and removing
      lines to keep a fixed size.
    • Carlos Alves's avatar
      Limit the history reflow · f4643a0d
      Carlos Alves authored
      Set a limit to 20,000 lines
    • Carlos Alves's avatar
      Reflow unlimited scroll lines · 9e745ea5
      Carlos Alves authored
      Reflow the unlimited scroll lines with no limits.
    • Carlos Alves's avatar
      Move fixed size reflow · e4a0c208
      Carlos Alves authored
      Moving the fixed size history reflow code to compactHistoryScroll file.
      Screen file will not handle history reflow, unlimited scroll is
      completely different from fixed size scroll reflow.
  2. 21 Jan, 2021 1 commit
  3. 20 Jan, 2021 2 commits
    • Ahmad Samir's avatar
      FileFilterHotSpot: check the mime type of the file after cleaning the path · a5f29806
      Ahmad Samir authored
      QMimeDataBase will return "application/octet-stream" as the mime type
      of something like "path/to/some/textfile.txt:123:123:", because we are
      using methods from it that check only the file extension. That meant
      some valid text files with line/column suffixes couldn't be opened.
      Instead move the mime type check _after_ the file path has been cleaned.
      Also account for mime types that aren't recognized, e.g. a text file with
      no extension.
      BUG: 431601
    • Nate Graham's avatar
      Fix "Remember window size" not working when unchecked · d22236c3
      Nate Graham authored
      When this feature is turned off, it deletes some keys from Konsole's
      config file. However this broke recently for two reasons:
      1. The key names changed a few Frameworks releases ago
      2. There are new keys that need to be deleted or else position gets
         restored too
      This commit fixes that bug by updating the condition to delete all the
      config keys required to make the off state for this feature work again.
      BUG: 427610
      FIXED-IN: 20.12.2
      (cherry picked from commit 8fa1c4b5)
  4. 16 Jan, 2021 1 commit
  5. 15 Jan, 2021 1 commit
    • Carlos Alves's avatar
      Fix unlimited history reflow bug · 0f8d4e0c
      Carlos Alves authored
      It was joinning the reflowed lines in history but in compact history it
      does reflow again. It will now just ignore it and add to history.
      BUG: 431624
  6. 12 Jan, 2021 1 commit
    • Ahmad Samir's avatar
      FileFilterHotspot: check the mime type before opening with text editor · 43c14e98
      Ahmad Samir authored
      When activating a file filter hot spot, everything got opened with the text
      editor specified in the profile settings, which is wrong e.g. with pdf or
      png files. Check the mime type of the file path, based only on the extension
      so as to keep things fast.
      Also rename openWithSysDefaultEditor() to openWithSysDefaultApp(), which is
      more accurate.
      BUG: 431496
  7. 11 Jan, 2021 1 commit
  8. 10 Jan, 2021 1 commit
    • Carlos Alves's avatar
      Converts HistoryScrollFile to CompactHistoryScroll · 51e58e6d
      Carlos Alves authored
      When using unlimited history and change to fixed history size, it will
      move, limited by the fixed size, the history.
      It will create a new CompactHistoryScroll, get the lines from the old
      HistoryScrollFile, and delete the old HistoryScrollFile structure.
  9. 07 Jan, 2021 1 commit
  10. 06 Jan, 2021 5 commits
  11. 05 Jan, 2021 1 commit
  12. 03 Jan, 2021 1 commit
    • Carlos Alves's avatar
      Adding version checks to deprecated functions · 5bbb4334
      Carlos Alves authored
      Macros to check frameworks versions and switch from deprecated functions
      to newer versions.
      KProcess: pid -> processId
      KCodecAction: setDelayed -> setPopupMode
      KActionMenu: triggered -> codecTriggered
  13. 02 Jan, 2021 6 commits
    • Ahmad Samir's avatar
      FileFilterHotspot: fix a couple of issues · 5cb21217
      Ahmad Samir authored
      - Handle `grep -n` output with long lines, where there is no space
        after "path/to/file:123:", we can send "path/to/file:123:bla" to
        a text editor and it seems most of them just ignore the text after
        the last ":"
      - If the session pointer is null, there is nothing to do
      - Guard against editorCmd not having any spaces in it, which it could
        be with the "Custom" entry (from the combobox)
      - Even when the file URL doesn't match the /path/to/file:line:column
        pattern try to use the editor specified in the profile settings
    • Ahmad Samir's avatar
      EditProfileDialog: add combobox to select custom text editor · bf75cfa9
      Ahmad Samir authored
      The functionality to open a file at a certain line/column in a text editor
      was added in commit 923f8d14. Here some preset text editors are added
      to make it easier to select your preferred text editor to use; the syntax
      for each editor is hard-coded, however there is a "custom" entry in the
      combobox where the user can set a different text editor (or a different
      This combobox is inspired by the "Code Navigation" menu in Heaptrack.
    • Edwin Pujols's avatar
      terminalDisplay: Remove unused `fixedFont` code. · 9d188aac
      Edwin Pujols authored
      The `fixedFont` related code is currently not effectual. So with this
      commit I remove it.
    • Christian Schärf's avatar
      Move connecting and disconnecting TerminalDisplays into separate function to... · c695c9b2
      Christian Schärf authored
      Move connecting and disconnecting TerminalDisplays into separate function to avoid code duplication.
    • Carlos Alves's avatar
      Remove deprecated functions · 343d8595
      Carlos Alves authored
      Konsole minimum required version is QT 5.14 and KF5 5.71, there is no
      need to keep support for those deprecated functions.
    • Christoph Feck's avatar
      GIT_SILENT Update Appstream for new release · 3438b94e
      Christoph Feck authored
      (cherry picked from commit 50afea59)
  14. 31 Dec, 2020 12 commits