1. 18 Mar, 2021 4 commits
    • Ahmad Samir's avatar
      ProfileSettings: use generateUniqueName() when creating new profiles · 9cab1758
      Ahmad Samir authored and Kurt Hindenburg's avatar Kurt Hindenburg committed
      This makes new profile name generation consistent everywhere.
      9cab1758
    • Ahmad Samir's avatar
      ProfileManager: remove some fallback-profile-related code · 238a8b45
      Ahmad Samir authored and Kurt Hindenburg's avatar Kurt Hindenburg committed
      After the previous commit the Fallback profile shouldn't be editable
      at all.
      238a8b45
    • Ahmad Samir's avatar
      Don't edit the Fallback profile, instead create a new one · 5ab84231
      Ahmad Samir authored and Kurt Hindenburg's avatar Kurt Hindenburg committed
      This is a first step in simplifying the code; since the Fallback profile
      doesn't have a file on disk, it's basically a corner-case that we have to
      babysit in various places in the code.
      
      Now when the user tries to "Edit current profile", if it's the Fallback
      profile, a new profile is created, with a unique name "Profile 1",
      "Profile 2" ...etc. This is similar to using the "New" button in the
      ProfileSettings dialog.
      5ab84231
    • Ahmad Samir's avatar
      Clean up some more "favourite profile"-related code · 646408dd
      Ahmad Samir authored and Kurt Hindenburg's avatar Kurt Hindenburg committed
      - Since the favourite profile feature was removed in commit 28ba920c,
      there is no need to sort profiles by menu index, this simlifies the code
      some more.
      
      - Remove Profile::menuIndexAsInt() method, now it's not used anywhere
      
      - This also fixes an issue with sorting the the Default/fallback profile,
      since commit ce31d0e2 it would be always sorted at the top of the
      list (to signify that it's a special, read-only profile...etc), sorting
      by menu index breaks that behaviour:
       - create a new profile by editing the Defualt/fallback profile, and give
         the new profile a name (Defualt is reserved of course)
       - open the profile manager dialog, you'll find the Default/fallback
         profile not at the top of the list, until you restart Konsole
      
      This issue was reported by Kurt in
      !351 (comment 197432)
      646408dd
  2. 15 Mar, 2021 2 commits
  3. 13 Mar, 2021 1 commit
  4. 10 Mar, 2021 1 commit
  5. 07 Mar, 2021 3 commits
  6. 06 Mar, 2021 1 commit
  7. 02 Mar, 2021 2 commits
    • Ahmad Samir's avatar
      ProfileManager dialog: improve handling profiles · 6cb301bd
      Ahmad Samir authored and Kurt Hindenburg's avatar Kurt Hindenburg committed
      - Differentiate between a profile being deleteable and writable:
        - Disable the Edit key for read-only profiles, i.e. a '.profile' that
          doesn't have write permissions for the user
        - Disable the Delete key for a '.profile' that is in a directory that
          isn't writable for the user (i.e. a .profile can be read-only, but
          still deleteable by the user)
      
      - Change the model selection mode to single selection, that simplifies
        the code, besides it looks like editing more than one profile at the
        same time hasn't worked for a while, and there are no complaints AFAICS;
        remove the now redundant selectedProfiles() method.
      6cb301bd
    • Ahmad Samir's avatar
      Tweak the profile manager dialog · 91122e53
      Ahmad Samir authored and Kurt Hindenburg's avatar Kurt Hindenburg committed
      - Show profile path as tooltip, for the fallback profile show
        "Built-in/hardcoded"
      - Add " [Read-only]" to the Default/fallback profile name
      - Make the font of the current default profile bold to match the menu
        in 'File -> New Tab'
      - Change the text added to the current default profile to " default", i.e.
        lowercase, to differentiate between it and the fallback profile, which
        is called Default
      
      Fix indentation in switch/case statements.
      91122e53
  8. 01 Mar, 2021 1 commit
    • Ahmad Samir's avatar
      Update the profiles list menu when the default profile is changed · a59d9b8d
      Ahmad Samir authored
      Now the 'File->New Tab' menu is updated when the default profile is
      changed, i.e. the action font is made bold and the favourites icon
      emblem is added to the profile icon.
      
      A call to menu()->setDefaultAction() has been removed, as I don't see
      what it serves exactly in the current code.
      
      Reported by khindenburg in:
      !351
      a59d9b8d
  9. 24 Feb, 2021 1 commit
  10. 23 Feb, 2021 1 commit
  11. 21 Feb, 2021 1 commit
    • Jonathan Marten's avatar
      Fix view splitter actions not being updated when a view is closed · a3c318dc
      Jonathan Marten authored
      This happens because in ViewManager::sessionFinished(),
      the 'view' is delayed deleted which means that it is not removed
      from its containing splitter until the next event.  However,
      toggleActionsBasedOnState() is called immediately which makes its
      decisions based on the current splitter state with the view still
      present.
      
      In order to avoid any possible object lifetime issues caused by
      changing the way the view is deleted, or trying to remove it from the
      view immediately, the call of toggleActionsBasedOnState() is instead
      delayed until the view has been destroyed (and therefore removed from
      its splitter).
      a3c318dc
  12. 20 Feb, 2021 2 commits
    • Carlos Alves's avatar
      Fix zsh reflow · 25a24bf3
      Carlos Alves authored and Kurt Hindenburg's avatar Kurt Hindenburg committed
      This will fix most of the zsh themes reflow, still working on other
      themes.
      zsh command line position is different from other shells, it is not
      where the cursor line is. Konsole is correcting this position.
      25a24bf3
    • Carlos Alves's avatar
      Fix ReFlow bug while Splitting View · 9d041222
      Carlos Alves authored
      History content was changing when splitting the view.
      9d041222
  13. 19 Feb, 2021 2 commits
  14. 18 Feb, 2021 2 commits
  15. 17 Feb, 2021 1 commit
  16. 15 Feb, 2021 4 commits
  17. 10 Feb, 2021 1 commit
  18. 09 Feb, 2021 1 commit
  19. 08 Feb, 2021 4 commits
  20. 06 Feb, 2021 1 commit
  21. 02 Feb, 2021 1 commit
  22. 31 Jan, 2021 1 commit
  23. 29 Jan, 2021 2 commits