The compiler may produce a false positive -Wconditional-uninitialized compiler warning.

Luis Javier Merino authored May 21, 2022 and Tomaz Canabrava committed May 26, 2022

When selecting past the last character, extend the selection to the last
column.  This allows the user to know when the selection has extended
past the last character on a line, even in the presence of trailing
spaces, and will get a newline added to the last line.

This is the behavior of xterm, VTE and rxvt.  mlterm doesn't allow
selections to extend past the last non-space character on a line.

BUG: 413426
CCBUG: 158726

Luis Javier Merino authored May 23, 2022 and Tomaz Canabrava committed May 26, 2022

Commit e8f77101 did this for screen lines.  Do it also for lines in the
history buffer.

Luis Javier Merino authored May 22, 2022 and Tomaz Canabrava committed May 26, 2022

The TrimTrailingSpacesInSelectedText profile option was not being
respected when selecting text in the history buffer.

Use cleanupTestCase() to free up memory allocations.  This also fixes
an old coverity issue.

ivan tkachenko authored Sep 02, 2021 and Tomaz Canabrava committed May 25, 2022

* Rename everything related to built-in profile both in code and UI.

* Unified style for [Read-only] and [Default] badges in profile
  manager's list model.

* Change --fallback-profile option to --builtin-profile.

* Backward compatibility: yes. If a user happened to name their
  profile "Built-in", it would continue to work as normal, and even
  load with `--profile "Built-in"` command line flag. It will let them
  modify any property including Name; but changing the name back
  to "Built-in" shows a warning and reverts the change as usual.

* Remove "This option is a shortcut for" sentence. While it is still
  technically possible to pass built-in profile's magic path, this
  option is not a shortcut, nor implemented as such.

* Delete extra naming conditions in ProfileManager::changeProfile,
  because they could never be triggered anyway, due to pre-flight
  checks in EditProfileDialog::isProfileNameValid. Automatic unique
  profile names generation has been done even earlier in either
  SessionController or ProfileSettings. Just as before, users will
  continue experiencing a generic "A profile with the name \"%1\"
  already exists." message.

Tests:

* Improve test for uncreatable file name of built-in profile.

* Add backward compatibility test for loading existing profile
  named "Built-in" which also references real built-in as its parent.

BUG: 438309

Ahmad Samir authored May 04, 2022 and Tomaz Canabrava committed May 24, 2022

This is inherently faster than the singal/slot round trip.

Having a signal that returns anything other than void is an indication it
should be a method not a signal.

Note that nothing outside of TerminalDisplay emits/uses those signals.

Ahmad Samir authored May 04, 2022 and Tomaz Canabrava committed May 24, 2022

This way we can use it directly in the code, instead of QObject::sender()
and casting.

Ahmad Samir authored May 03, 2022 and Tomaz Canabrava committed May 24, 2022

By passing the sender object as an arg to the signal/slot.

Commit d37d3ac1 "CompactHistoryScroll: Remove _maxLineCount + 5 lines at
a time" caused a regression: addHistLine queried the number of lines in
history before and after adding a line, and if it had not incremented it
assumed one line entered history and another was dropped at the other
end.  Now, lines are dropped from history in batches, so take care of
that.

Very similar to the regression fixed at 7a1e4768, only this one is about
keeping the scroll position on the presence of scroll, and that other
one is about keeping the selection.

Thanks to the bug reporters Michael and Luke-Jr for the heads-up.

BUG: 452955
BUG: 453112

Also, free memory before comparing in case of failure. This fixes a
really old coverity issue.

Kamay Xutax authored May 23, 2022 and Tomaz Canabrava committed May 23, 2022

Here how it looks like: https://imgur.com/a/uaMQvT6

Before, it was impossible to resize the splits
with the same size in case they were manually resized.

I have added a new button menu for doing so:
in View -> Split View -> Equal size to all views.

First I wanted to make this as a plugin,
but since I thought it could make splits a bit more useful,
I decided to merge it not as a plugin but internally.

GUI: Menu -> View -> Split View -> Equal size to all views
CHANGELOG: Added equal size to all split views.

Tomaz Canabrava authored May 02, 2022 and Tomaz Canabrava committed May 23, 2022

We could re-utilize the text we wrote on the command pallete

Nicolas Fella authored May 19, 2022 and Tomaz Canabrava committed May 23, 2022

The current name is not descriptive at all

The setting is still buried rather deep, but at least it has a somewhat better name now

BUG: 454034