1. 06 Jun, 2020 4 commits
  2. 05 Jun, 2020 2 commits
  3. 04 Jun, 2020 1 commit
  4. 03 Jun, 2020 4 commits
    • Tomaz  Canabrava's avatar
      Fix SearchTask memleak · 9372cf71
      Tomaz Canabrava authored
      There's a `autoDelete` option for a task, but it's up to the
      task to implement how it will delete itself. For SearchHistoryTask
      this never happened.
      
      I tested holding the `search` button for around one minute and the
      memory was slowly growing and never freed. Adding a destructor with a
      debug to remove any doubt made me realize: The search task was only
      removed when konsole closed.
      
      This is not just about the Memory Management, as the search was also
      connected to multiple objects and could potentially mishandle searches.
      9372cf71
    • Tomaz  Canabrava's avatar
      Only recalculate the directories when we change dirs · e713c90c
      Tomaz Canabrava authored
      Whenever we trigger something that redraws the screen we trigger
      all the filters, and the FileFilter - that looks for files and folders
      in the current directory - is constantly re-triggered to.
      
      The creation of the vector / set containing all files takes now around
      30msec, but searching takes just 3 - 4 msec. If we only generate the
      list of files when we change directories, this goes down from 34 msec
      to just 4, making konsole consume less cpu, spend less energy and help
      with battery when we are selecting text or updating the screen with new
      data.
      
      This fails to highlight a file if the file is created after we read the
      files in the directory, as we are not updating the list of files
      anymore. Not an acceptable loss, we need to fix this, but not by
      re-reading all of the files in folders and subfolders on every mouse
      move.
      e713c90c
    • Tomaz  Canabrava's avatar
      Use QSet to search for strings instead of QStringList · 0b489b0c
      Tomaz Canabrava authored
      The time that it takes to search a collection of just too many strings
      can take up to 48msec - tested triggering the code on /usr/lib with
      around 7000 files.
      
      changing to QSet this went down to 35msec. This is not a lot but
      it's triggered at *every* mouse move event, so the gain is cummulative
      
      The whole experience is a bit smoother.
      0b489b0c
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · ba0b3bfe
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      ba0b3bfe
  5. 02 Jun, 2020 2 commits
  6. 01 Jun, 2020 1 commit
  7. 31 May, 2020 2 commits
  8. 29 May, 2020 2 commits
    • Ahmad Samir's avatar
      [SessionController] Fix crash caused by text encoding menu · e7e8e9d1
      Ahmad Samir authored
      QMenu since 5.15 is hidden when an action is triggered, this caused a
      crash in Konsole when trying to access the text encoding menu.
      
      Now Session emits a signal when the text encoding is changed, the
      SessionController can connect to that singal to set the current codec in
      the KCodecAction object.
      
      Also fix the EditProfileDialog so that when the KCodecAction menu is
      shown the currently set codec is selected.
      
      BUG: 419526
      
      FIXED-IN: 20.08
      e7e8e9d1
    • Maximilian Schiller's avatar
      Fix konsolepart segfault when closing after showing context menu · 1d7142ed
      Maximilian Schiller authored
      Assign the _view as the parent to the KXMLGuiFactory because the
      factory is referencing the view widget as its associated widget. Since
      the TerminalDisplay gets destructed first this is now a dangling
      pointer. If the view is set as the parent the factory gets cleaned up
      correctly.  Also cleanup the created clientBuilder after destruction
      because it can't have a parent and would probably leak memory.
      
      BUG: 415762
      FIXED-IN: 20.08.0
      See also !87
      1d7142ed
  9. 28 May, 2020 2 commits
  10. 23 May, 2020 2 commits
  11. 22 May, 2020 1 commit
  12. 21 May, 2020 11 commits
  13. 20 May, 2020 1 commit
  14. 15 May, 2020 5 commits