1. 15 Feb, 2021 2 commits
    • Ahmad Samir's avatar
      FileFilter: don't create a hotspot for '................' · ac0b5ef4
      Ahmad Samir authored
      Only '.' and '..' could be valid hotspots, but '..........' isn't. The
      latter is used by some CLI tools to indicate progress ...etc.
      
      To test, in any dir use `ls -a`, Ctrl + clicking '.' and '..' should
      open the current dir and parent of the current dir respectively.
      
      Type .......... at the prompt, before it would get underlined, after no
      hotspot will be created for it.
      
      BUG: 432779
      ac0b5ef4
    • Ahmad Samir's avatar
      FileFilterHotspot: use QMimeDataBase::mimeTypeForFile() · f5be10b1
      Ahmad Samir authored and Kurt Hindenburg's avatar Kurt Hindenburg committed
      It seems there is no way around checking for the extension then falling
      back to letting QMimeDataBase examine the file contents; e.g. a file
      named konsolerc, doesn't have an extension, but it is still a text file.
      f5be10b1
  2. 10 Feb, 2021 1 commit
  3. 09 Feb, 2021 1 commit
  4. 08 Feb, 2021 4 commits
  5. 06 Feb, 2021 1 commit
  6. 02 Feb, 2021 1 commit
  7. 31 Jan, 2021 1 commit
  8. 29 Jan, 2021 3 commits
  9. 26 Jan, 2021 1 commit
    • Carlos Alves's avatar
      Fix moveImage error · 986aed09
      Carlos Alves authored
      While changing some functions with STL, I though it was possible to move
      the line from source to destination, but it is causing a problem with
      console programs status line (ex: htop).
      
      BUG: 432005
      986aed09
  10. 25 Jan, 2021 1 commit
  11. 24 Jan, 2021 4 commits
  12. 22 Jan, 2021 7 commits
    • Carlos Alves's avatar
      Small change do STL · 62ffda33
      Carlos Alves authored and Kurt Hindenburg's avatar Kurt Hindenburg committed
      Where it was possible:
      - 'For' to STL copy or fill (it is like using memcpy and memset, faster
      than for, the compiler decides the best algo to perform the task);
      - 'For' + 'if' to 'where', it is faster and cleanner to read.
      
      Changes in: PlainTextDecoder.cpp, HTMLDecoder.cpp, ColorScheme.cpp and
      ExtendedCharTable.cpp
      62ffda33
    • Carlos Alves's avatar
      Small changes to STL and qBound · 8c57c842
      Carlos Alves authored and Kurt Hindenburg's avatar Kurt Hindenburg committed
      Where it was possible:
      - 'For' to STL copy or fill (it is like using memcpy and memset, faster
      than for, the compiler decides the best algo to perform the task);
      - qMin(qMax) to qBound.
      
      Changes in: TeminalDisplay and TerminalColor
      8c57c842
    • Carlos Alves's avatar
      Test HistoryType change · 8cf4601b
      Carlos Alves authored and Kurt Hindenburg's avatar Kurt Hindenburg committed
      Unlimited to Fixed Size must have the fixed size information preserved.
      Fixed Size to Unlimited must have all the information preserved.
      All types to None all information must be erased.
      8cf4601b
    • Carlos Alves's avatar
      Add Reflow test to HistoryTest · 4cee7e23
      Carlos Alves authored and Kurt Hindenburg's avatar Kurt Hindenburg committed
      While testing I found a bug in CompactHistoryScroll add function, it
      should append before check the vector size and not after, it was
      returning a Size > Max Size, not equal.
      Another Bug found in fixed size history scroll, it was not properly
      reflowing the last line, a position problem when adding and removing
      lines to keep a fixed size.
      4cee7e23
    • Carlos Alves's avatar
      Limit the history reflow · f4643a0d
      Carlos Alves authored and Kurt Hindenburg's avatar Kurt Hindenburg committed
      Set a limit to 20,000 lines
      f4643a0d
    • Carlos Alves's avatar
      Reflow unlimited scroll lines · 9e745ea5
      Carlos Alves authored and Kurt Hindenburg's avatar Kurt Hindenburg committed
      Reflow the unlimited scroll lines with no limits.
      9e745ea5
    • Carlos Alves's avatar
      Move fixed size reflow · e4a0c208
      Carlos Alves authored and Kurt Hindenburg's avatar Kurt Hindenburg committed
      Moving the fixed size history reflow code to compactHistoryScroll file.
      Screen file will not handle history reflow, unlimited scroll is
      completely different from fixed size scroll reflow.
      e4a0c208
  13. 21 Jan, 2021 1 commit
  14. 20 Jan, 2021 2 commits
    • Ahmad Samir's avatar
      FileFilterHotSpot: check the mime type of the file after cleaning the path · a5f29806
      Ahmad Samir authored and Kurt Hindenburg's avatar Kurt Hindenburg committed
      QMimeDataBase will return "application/octet-stream" as the mime type
      of something like "path/to/some/textfile.txt:123:123:", because we are
      using methods from it that check only the file extension. That meant
      some valid text files with line/column suffixes couldn't be opened.
      
      Instead move the mime type check _after_ the file path has been cleaned.
      Also account for mime types that aren't recognized, e.g. a text file with
      no extension.
      
      BUG: 431601
      a5f29806
    • Nate Graham's avatar
      Fix "Remember window size" not working when unchecked · d22236c3
      Nate Graham authored and Kurt Hindenburg's avatar Kurt Hindenburg committed
      When this feature is turned off, it deletes some keys from Konsole's
      config file. However this broke recently for two reasons:
      
      1. The key names changed a few Frameworks releases ago
      2. There are new keys that need to be deleted or else position gets
         restored too
      
      This commit fixes that bug by updating the condition to delete all the
      config keys required to make the off state for this feature work again.
      
      BUG: 427610
      FIXED-IN: 20.12.2
      (cherry picked from commit 8fa1c4b5)
      d22236c3
  15. 16 Jan, 2021 1 commit
  16. 15 Jan, 2021 1 commit
  17. 12 Jan, 2021 1 commit
    • Ahmad Samir's avatar
      FileFilterHotspot: check the mime type before opening with text editor · 43c14e98
      Ahmad Samir authored
      When activating a file filter hot spot, everything got opened with the text
      editor specified in the profile settings, which is wrong e.g. with pdf or
      png files. Check the mime type of the file path, based only on the extension
      so as to keep things fast.
      
      Also rename openWithSysDefaultEditor() to openWithSysDefaultApp(), which is
      more accurate.
      
      BUG: 431496
      43c14e98
  18. 11 Jan, 2021 1 commit
  19. 10 Jan, 2021 1 commit
    • Carlos Alves's avatar
      Converts HistoryScrollFile to CompactHistoryScroll · 51e58e6d
      Carlos Alves authored and Kurt Hindenburg's avatar Kurt Hindenburg committed
      When using unlimited history and change to fixed history size, it will
      move, limited by the fixed size, the history.
      It will create a new CompactHistoryScroll, get the lines from the old
      HistoryScrollFile, and delete the old HistoryScrollFile structure.
      51e58e6d
  20. 07 Jan, 2021 1 commit
  21. 06 Jan, 2021 4 commits