1. 21 May, 2020 6 commits
  2. 27 Apr, 2020 1 commit
  3. 20 Apr, 2020 8 commits
  4. 14 Apr, 2020 1 commit
  5. 22 Mar, 2020 1 commit
    • Ahmad Samir's avatar
      [FileFilter] Create HotSpot's for files in child dirs too · 26f4a221
      Ahmad Samir authored
      When creating HotSpot's for local files, create them for files in the
      current dir and for files in sub-directories too.
      
      Re-format the code used to build the regex pattern for more readability
      (easier for seeing what the regex pattern will look like, I hope).
      
      Use a static QRegularExpression object, so as to only construct it once,
      the pattern doesn't change and this should help with performance. Also
      make createFileRegex() not static.
      
      Don't convert QList<QString> to QSet<QString>, without actual benchmarking
      it could be that QList is actually efficient here.
      
      Use const where appropriate.
      
      BUG: 416376
      26f4a221
  6. 30 Jan, 2020 1 commit
    • Tomaz  Canabrava's avatar
      Fix context menu actions when search bar is enabled · 96cda154
      Tomaz Canabrava authored
      The actions are destroyed during a focusIn / focusOut, and recreated
      with the same content but different memory positions, and that
      killed the QActions inside of the menu.
      
      To trigger this is simple, open the search bar, type some url in
      konsole, and right click on it: you will not see the actions
      to copy and go to url.
      
      moving the related code to QSharedPointer fixes this by delaying
      the destruction of the pointer untill the menu is closed.
      96cda154
  7. 17 Dec, 2019 1 commit
  8. 24 Nov, 2019 1 commit
  9. 16 Nov, 2019 1 commit
  10. 28 Aug, 2019 1 commit
  11. 23 Aug, 2019 1 commit
  12. 13 Mar, 2019 1 commit
    • David Hallas's avatar
      Fix memory leak of HotSpot · 7265be97
      David Hallas authored
      Summary:
      Fixes memory leaf of HotSpots. This is caused by the Filter::reset()
      function failing to delete the allocated HotSpots before clearing the
      list.
      
      Test Plan:
      Compile konsole with address sanitizer
      Select a link in the terminal
      Close konsole
      
      Reviewers: #konsole, hindenburg
      
      Reviewed By: #konsole, hindenburg
      
      Subscribers: hindenburg, konsole-devel
      
      Tags: #konsole
      
      Differential Revision: https://phabricator.kde.org/D19636
      7265be97
  13. 11 Jan, 2019 1 commit
  14. 27 Oct, 2018 1 commit
  15. 03 Oct, 2018 1 commit
    • Mariusz Glebocki's avatar
      Use new character width code based on Unicode 11 · e74cf6c3
      Mariusz Glebocki authored
      Summary:
      Adds a code for getting character width togeter with LUTs generated
      using uni2characterwidth from Unicode 11 lists.
      
      Skin tone, flags, gender, and other emoji with and modifer are not
      joined (you will see e.g. a skin tone square + generic yellow emoji).
      I think joining them would cause problems in most editors, command line
      prompts, and other programs which use character width data, as the
      characters would behave as combining or emoji depending on context (like
      ligatures).
      
      Examples:
      * light thumb up: 👍🏻
      * dark thumb up:  👍🏿
      * Polish flag:    🇵🇱
      
      This behavior is allowed:
      * https://unicode.org/reports/tr51/#Emoji_Modifiers_Display
      * https://unicode.org/reports/tr51/#Emoji_ZWJ_Sequences
      
      It is possible to add support for sequences, but those would work
      only for a string width functions.
      
      Some characters which can be presented as emoji are narrow (e.g. ️, ©️).
      Those characters are listed without "presentation" mode, which means
      they should be rendered as text by default (real presentation depends on
      renderer and/or font). Noto Sans Color Emoji renders them as wide,
      DejaVu Sans as narrow. Vim, bash and zsh treat them as narrow, so I made
      them narrow.
      
      https://unicode.org/reports/tr51/#Presentation_Style
      
      BUG: 396435
      BUG: 378124
      BUG: 392171
      BUG: 339439
      
      FIXED-IN: 18.12
      
      Depends on D15757
      
      Test Plan:
      * Look at emoji_test.txt - emojis should look "normal" (two characters
      width).
      * Look at GLASS.txt - characters width should look correct.
      * CharacterWidthTest should pass.
      * perl -XCSDL -e 'print map{chr($_), " "} 1..0xffff'
      
      Reviewers: #konsole, #vdg, hindenburg
      
      Reviewed By: #konsole, hindenburg
      
      Subscribers: hindenburg, broulik, ngraham, konsole-devel
      
      Tags: #konsole
      
      Differential Revision: https://phabricator.kde.org/D15758
      e74cf6c3
  16. 27 Sep, 2018 1 commit
    • Mariusz Glebocki's avatar
      Move character width functions to Character class · 0f33ee50
      Mariusz Glebocki authored
      Summary:
      Replaces direct konsole_wcwidth() calls with Character object property
      and the class static function, which internally still use
      konsole_wcwidth().
      
      The change also prepares the codebase for a new code for determining
      character width. This way the change will barely touch existing code.
      
      CCBUG: 396435
      
      Test Plan:
      konsole_wcwidth() is still used, just in one central place. Passed
      compilation and CharacterWidthTest should be enough.
      
      Reviewers: #konsole, hindenburg
      
      Reviewed By: #konsole, hindenburg
      
      Subscribers: hindenburg, konsole-devel
      
      Tags: #konsole
      
      Differential Revision: https://phabricator.kde.org/D15756
      0f33ee50
  17. 01 Apr, 2018 1 commit
  18. 14 Feb, 2018 1 commit
  19. 13 Feb, 2018 1 commit
  20. 13 Jan, 2018 1 commit
  21. 04 Jan, 2018 1 commit
  22. 02 Jan, 2018 1 commit
  23. 01 Jan, 2018 1 commit
  24. 25 Dec, 2017 1 commit
  25. 16 Jul, 2017 1 commit
  26. 03 Jun, 2017 1 commit
    • Martin Tobias Holmedahl Sandsmark's avatar
      Improve file matching · 2322c560
      Martin Tobias Holmedahl Sandsmark authored
      Match files with known prefixes and full names.
      
      Also cache known files instead of looking up and creating a QDir and
      QFileInfo for every file, to improve performance massively.
      
      REVIEW: 128396
      2322c560
  27. 28 May, 2017 1 commit
  28. 27 Apr, 2017 1 commit