Tomaz Canabrava authored Aug 20, 2020 and Kurt Hindenburg committed Sep 15, 2020

This was harder than I tought. Because of the static initialization
static linkage order, we ended up having two different values of
a static variable on the code, that where supposedly only one.

https://stackoverflow.com/questions/26547454/static-variable-is-initialized-twice

The choosen change: Use OBJECT instead of STATIC for linking also
made me fix a few other profile headers to use the correct folder.

Tomaz Canabrava authored Aug 16, 2020 and Kurt Hindenburg committed Sep 15, 2020

The only real thing a favorite profile does is to be accessible
from the Settings -> Profile menu. This simplifies a lot of code
and makes the flow of settings more what the user expects.

Next: Merge ProfileManager & ProfileModel

Tomaz Canabrava authored Aug 07, 2020 and Kurt Hindenburg committed Sep 15, 2020

The code that managed the profile model currently is done
inside of the ProfileSettings, and thus unusable out
of it. Since I want to make it easier to select a profile
this needs to split.

It's also a bad code style to mix interface and code