1. 25 Mar, 2018 2 commits
    • Mariusz Glebocki's avatar
      Allow view-controlling keys in read-only mode · b94162c1
      Mariusz Glebocki authored
      Summary:
      Allow to use scrolling (Shift+Up/Down/PgUp/PgDown/Home/End) and a key
      for showing URL hints when the view is in read-only mode.
      
      Test Plan:
      * Prepare
        * Turn on scrollback
        * Set at least one modifier key for "Show URL hints" (edit profile → advanced)
        * Generate a few screens of text in Konsole
        * Display some URL (e.g. `echo 'www.kde.org'`)
        * Display current time every second: `while sleep 1; do printf '\r%s' "$(date)"; done`
        * Turn on read-only mode
      * Patch tests
        * Scroll the view with Shift+Up/Down/PgUp/PgDown/Home/End - the view should scroll
        * Hold down URL hint key - the URL should be underlined with square and a digit on the left
        * Press <URL-hint-key>+1 - the URL should open in a web browser
      * Regressions tests
        * Press different keys (including Ctrl+C, Ctrl+Z, etc; skip those mapped to Konsole actions) - nothing in terminal should happen
        * Press Ctrl+S - the time should not stop updating
      
      Reviewers: #konsole, hindenburg
      
      Reviewed By: #konsole, hindenburg
      
      Subscribers: hindenburg, #konsole
      
      Tags: #konsole
      
      Differential Revision: https://phabricator.kde.org/D11668
      
      (cherry picked from commit 6635190c)
      b94162c1
    • Joshua Noack's avatar
      Disable menu actions when read-only/locked · 429ad275
      Joshua Noack authored
      Summary:
      This patch addresses the following points:
      
      - Ignore most DBus methods
      - Disable the following actions:
      clear-history, clear-history-and-reset, edit-current-profile, switch-profile
      adjust-history, send-signal, zmodem-upload, edit-rename (tab bar)
      
      - Session updates all views correctly when readonly changes
      
      {F5754353}
      
      Test Plan:
      - Actions do not show when locked
      - DBus methods are ignored when locked
      - Multiple views in one session get correctly updated
      
      Reviewers: hindenburg, #konsole
      
      Reviewed By: hindenburg, #konsole
      
      Subscribers: ngraham, hindenburg, #konsole
      
      Tags: #konsole
      
      Differential Revision: https://phabricator.kde.org/D11341
      
      (cherry picked from commit 3a1d350b)
      429ad275
  2. 16 Mar, 2018 1 commit
    • Ahmad Samir's avatar
      Preserve tab titles set by the user, when applying profile changes · 78beb596
      Ahmad Samir authored
      Summary:
      When applying profile changes don't touch tab titles explicilty set by
      the user (via the rename tab dialog); the same goes when previewing
      color schemes.
      
      Update the tab text only if the user actually changed the the tab title
      fomart in the rename tab dialog.
      
      BUG: 354403
      FIXED-IN: 18.04
      
      Test Plan:
      - In a konsole window with 2 or more tabs, rename a tab using the
        rename-tab dialog
      - Open the Edit Profile dialog and change some settings and save, also
        try previewing some color schemes; note that the tab title changes
        are kept
      - In the Edit Profile dialog, change the tab format on the Tabs page,
        and apply; note that the tab title the was renamed by the user isn't
        changed but the tab(s) whose name wasn't changed are affected by the
        tab title format setting change
      
      - Open the rename-tab dialog, don't change anything and click OK; now
        konsole doesn't count that as a tab title change
      
      Reviewers: #konsole, hindenburg
      
      Reviewed By: #konsole, hindenburg
      
      Subscribers: #konsole
      
      Tags: #konsole
      
      Differential Revision: https://phabricator.kde.org/D11363
      78beb596
  3. 12 Mar, 2018 1 commit
  4. 10 Mar, 2018 1 commit
    • Ahmad Samir's avatar
      Only emulate up/down key presses for mouse scrolls on alternate screen · 17c77a87
      Ahmad Samir authored
      Summary:
      Konsole sends up/down key press events for mouse scrolls for apps that
      aren't interested in mouse events, such as less. Only do this when the
      terminal is using the alternate screen.
      
      Now scrolling up/down will be translated to up/down key presses only
      when the terminal is using the alternate screen but scrolling in a terminal
      using the primary screen will only scroll using the scrollbar, now it does
      not cycle through the shell history.
      Now the behavior matches xterm and and gnome-terminal.
      
      BUG: 355106
      FIXED-IN: 18.04
      
      Reviewers: hindenburg
      
      Reviewed By: hindenburg
      
      Subscribers: rkflx, ngraham, #konsole
      
      Tags: #konsole
      
      Differential Revision: https://phabricator.kde.org/D11146
      17c77a87
  5. 08 Mar, 2018 1 commit
  6. 07 Mar, 2018 1 commit
    • Joshua Noack's avatar
      Konsole: Use KMessageWidget in TerminalDisplay · bcbaf5d3
      Joshua Noack authored
      Summary:
      Depends on D10862
      
      Before:
      
      {F5734372}
      
      After:
      {F5734369}
      
      Read-only:
      {F5734370}
      
      Both:
      {F5734371}
      
      This also fixes the overlapped scrollbar (see first screenshot).
      
      Test Plan: Tested before and after, behaviour is the same.
      
      Reviewers: #konsole, hindenburg
      
      Reviewed By: #konsole, hindenburg
      
      Subscribers: herrold, hindenburg, ngraham
      
      Tags: #konsole
      
      Differential Revision: https://phabricator.kde.org/D10935
      bcbaf5d3
  7. 06 Mar, 2018 1 commit
    • Kurt Hindenburg's avatar
      Konsole: Add read-only mode · 4f555265
      Kurt Hindenburg authored
      Summary:
      This patch adds a read-only option for TerminalDisplays. When active,
      all keyboard events are eaten. Mouse input is not affected and works like before.
      The setting is not persisted and only lasts for the duration of the session.
      
      Screenshots:
      {F5730786}
      {F5730788}
      {F5730789}
      
      VDG input is highly appreciated. Also, I'm not sure if I can just change the rc-files without bumping the version?
      
      FEATURE: 126930
      
      Test Plan:
      - Shortcuts still work
      - Paste and drop actions are disabled when readonly
      - Switching between read-only and normal tabs works as expected
      - Mouse input works like before
      
      Reviewers: #konsole, hindenburg
      
      Reviewed By: #konsole, hindenburg
      
      Subscribers: hindenburg, ngraham, #konsole
      
      Tags: #konsole
      
      Differential Revision: https://phabricator.kde.org/D10862
      4f555265
  8. 19 Feb, 2018 1 commit
  9. 04 Jan, 2018 1 commit
  10. 03 Jan, 2018 1 commit
  11. 02 Jan, 2018 1 commit
  12. 25 Dec, 2017 1 commit
  13. 16 Jul, 2017 1 commit
  14. 15 Jun, 2017 1 commit
  15. 08 May, 2017 1 commit
  16. 27 Apr, 2017 1 commit
  17. 21 Apr, 2017 1 commit
  18. 11 Apr, 2017 1 commit
  19. 01 Apr, 2017 3 commits
  20. 29 Mar, 2017 1 commit
  21. 28 Mar, 2017 1 commit
  22. 18 Feb, 2017 2 commits
  23. 05 Feb, 2017 1 commit
  24. 24 Nov, 2016 2 commits
  25. 20 Nov, 2016 1 commit
  26. 09 Nov, 2016 1 commit
  27. 18 Oct, 2016 1 commit
  28. 04 Sep, 2016 1 commit
  29. 28 Aug, 2016 1 commit
  30. 16 Jul, 2016 2 commits
    • Martin Tobias Holmedahl Sandsmark's avatar
      Improve filter updating · 252e52c2
      Martin Tobias Holmedahl Sandsmark authored
      This should update filters less often, and also hopefully fix the issue
      where underlined links get stuck while scrolling.
      
      The idea is to not to do it on all mouse updates, only when needed on
      mouse updates, and also not display the filters if they are out of date.
      The only thing that should happen on screen changes now is setting the
      _filterUpdateRequired variable to true, which leads to the filters not
      being displayed until re-processed, which happens the next time the
      mouse moves, unless I fucked something up.
      
      REVIEW: 128393
      (cherry picked from commit f3ce85b9)
      252e52c2
    • Martin Tobias Holmedahl Sandsmark's avatar
      Improve filter updating · f3ce85b9
      Martin Tobias Holmedahl Sandsmark authored
      This should update filters less often, and also hopefully fix the issue
      where underlined links get stuck while scrolling.
      
      The idea is to not to do it on all mouse updates, only when needed on
      mouse updates, and also not display the filters if they are out of date.
      The only thing that should happen on screen changes now is setting the
      _filterUpdateRequired variable to true, which leads to the filters not
      being displayed until re-processed, which happens the next time the
      mouse moves, unless I fucked something up.
      
      REVIEW: 128393
      f3ce85b9
  31. 07 Jul, 2016 1 commit
    • Martin Tobias Holmedahl Sandsmark's avatar
      Port to QRegularExpression · 1d20e43e
      Martin Tobias Holmedahl Sandsmark authored
      Port away from using QRegExp to QRegularExpression. The result is a bit
      better performance, a bit more readable code (imho) and also no more
      relying on mutable state in static objects (like in the keyboard
      translator parser).
      
      REVIEW: 128346
      1d20e43e
  32. 06 Jul, 2016 1 commit
    • Martin Tobias Holmedahl Sandsmark's avatar
      Implement a file filter similar to URL filter. · 9d2fd9a3
      Martin Tobias Holmedahl Sandsmark authored
      An updated version of the patch by Adam Treat <treat@kde.org>:
          Implement a new file filter using POSIX Portable Filename Character
          Set along with KDE's mimetype database of file extension blobs that
          filters text matching a POSIX portable pathname and underlines it
          very much like links.
      
      REVIEW: 128241
      REVIEW: 114376
      9d2fd9a3
  33. 11 Jun, 2016 1 commit
  34. 04 Jun, 2016 1 commit