1. 25 Mar, 2018 2 commits
    • Mariusz Glebocki's avatar
      Allow view-controlling keys in read-only mode · b94162c1
      Mariusz Glebocki authored
      Summary:
      Allow to use scrolling (Shift+Up/Down/PgUp/PgDown/Home/End) and a key
      for showing URL hints when the view is in read-only mode.
      
      Test Plan:
      * Prepare
        * Turn on scrollback
        * Set at least one modifier key for "Show URL hints" (edit profile → advanced)
        * Generate a few screens of text in Konsole
        * Display some URL (e.g. `echo 'www.kde.org'`)
        * Display current time every second: `while sleep 1; do printf '\r%s' "$(date)"; done`
        * Turn on read-only mode
      * Patch tests
        * Scroll the view with Shift+Up/Down/PgUp/PgDown/Home/End - the view should scroll
        * Hold down URL hint key - the URL should be underlined with square and a digit on the left
        * Press <URL-hint-key>+1 - the URL should open in a web browser
      * Regressions tests
        * Press different keys (including Ctrl+C, Ctrl+Z, etc; skip those mapped to Konsole actions) - nothing in terminal should happen
        * Press Ctrl+S - the time should not stop updating
      
      Reviewers: #konsole, hindenburg
      
      Reviewed By: #konsole, hindenburg
      
      Subscribers: hindenburg, #konsole
      
      Tags: #konsole
      
      Differential Revision: https://phabricator.kde.org/D11668
      
      (cherry picked from commit 6635190c)
      b94162c1
    • Joshua Noack's avatar
      Disable menu actions when read-only/locked · 429ad275
      Joshua Noack authored
      Summary:
      This patch addresses the following points:
      
      - Ignore most DBus methods
      - Disable the following actions:
      clear-history, clear-history-and-reset, edit-current-profile, switch-profile
      adjust-history, send-signal, zmodem-upload, edit-rename (tab bar)
      
      - Session updates all views correctly when readonly changes
      
      {F5754353}
      
      Test Plan:
      - Actions do not show when locked
      - DBus methods are ignored when locked
      - Multiple views in one session get correctly updated
      
      Reviewers: hindenburg, #konsole
      
      Reviewed By: hindenburg, #konsole
      
      Subscribers: ngraham, hindenburg, #konsole
      
      Tags: #konsole
      
      Differential Revision: https://phabricator.kde.org/D11341
      
      (cherry picked from commit 3a1d350b)
      429ad275
  2. 17 Mar, 2018 1 commit
    • Mariusz Glebocki's avatar
      Fix search result rectangle position · 6b8cf60a
      Mariusz Glebocki authored
      Summary:
      Include top margin in the rectangle's vertical position, so it will
      be drawn in correct position when TerminalCenter is set and/or
      TerminalMargin is larget than 0.
      
      Preview:
      {F5756612}
      
      Test Plan:
        - Run `konsole -p TerminalMargin=8`
        - Display something
        - Run search and search for something
        - The blue rectangle should cover current result line
      
      Reviewers: #konsole, hindenburg
      
      Reviewed By: #konsole, hindenburg
      
      Subscribers: hindenburg, #konsole
      
      Tags: #konsole
      
      Differential Revision: https://phabricator.kde.org/D11412
      6b8cf60a
  3. 15 Mar, 2018 1 commit
  4. 11 Mar, 2018 2 commits
    • Kurt Hindenburg's avatar
      separate 'if' to return earlier · 9872925b
      Kurt Hindenburg authored
      9872925b
    • Joshua Noack's avatar
      Use default close button of KMessageWidget · c442d223
      Joshua Noack authored
      Summary:
      D10935 introduced KMessageWidgets in TerminalDisplay for the "resume"
      and "read-only" messages. This patch restores the default close button
      and makes use of animateShow/animateHide. A nice plus is that I also
      removed some code which has become obsolete AND that the messages
      are now animated.
      
      {F5749781}
      
      Test Plan:
      Show/hide works like before.
      Also still works if readonly and suspended at the same time.
      Detaching works.
      
      Reviewers: ach, #konsole, hindenburg
      
      Reviewed By: #konsole, hindenburg
      
      Subscribers: hindenburg, ach, #konsole
      
      Tags: #konsole
      
      Differential Revision: https://phabricator.kde.org/D11241
      c442d223
  5. 10 Mar, 2018 2 commits
    • Ahmad Samir's avatar
      Only emulate up/down key presses for mouse scrolls on alternate screen · 17c77a87
      Ahmad Samir authored
      Summary:
      Konsole sends up/down key press events for mouse scrolls for apps that
      aren't interested in mouse events, such as less. Only do this when the
      terminal is using the alternate screen.
      
      Now scrolling up/down will be translated to up/down key presses only
      when the terminal is using the alternate screen but scrolling in a terminal
      using the primary screen will only scroll using the scrollbar, now it does
      not cycle through the shell history.
      Now the behavior matches xterm and and gnome-terminal.
      
      BUG: 355106
      FIXED-IN: 18.04
      
      Reviewers: hindenburg
      
      Reviewed By: hindenburg
      
      Subscribers: rkflx, ngraham, #konsole
      
      Tags: #konsole
      
      Differential Revision: https://phabricator.kde.org/D11146
      17c77a87
    • Marco Martin's avatar
      use the terminal color scheme for the scrollbar · 2a71f063
      Marco Martin authored
      Summary:
      As discussed with VDG, color the scrollbar with the same colors as
      the terminal color scheme itself. It looks way cleaner and modern
      
      Test Plan: tested with several color schemes and several styles
      
      Reviewers: #konsole, #vdg, hindenburg
      
      Reviewed By: #konsole, #vdg, hindenburg
      
      Subscribers: hindenburg, zzag, ngraham
      
      Tags: #konsole
      
      Differential Revision: https://phabricator.kde.org/D11184
      2a71f063
  6. 07 Mar, 2018 1 commit
    • Joshua Noack's avatar
      Konsole: Use KMessageWidget in TerminalDisplay · bcbaf5d3
      Joshua Noack authored
      Summary:
      Depends on D10862
      
      Before:
      
      {F5734372}
      
      After:
      {F5734369}
      
      Read-only:
      {F5734370}
      
      Both:
      {F5734371}
      
      This also fixes the overlapped scrollbar (see first screenshot).
      
      Test Plan: Tested before and after, behaviour is the same.
      
      Reviewers: #konsole, hindenburg
      
      Reviewed By: #konsole, hindenburg
      
      Subscribers: herrold, hindenburg, ngraham
      
      Tags: #konsole
      
      Differential Revision: https://phabricator.kde.org/D10935
      bcbaf5d3
  7. 06 Mar, 2018 1 commit
    • Kurt Hindenburg's avatar
      Konsole: Add read-only mode · 4f555265
      Kurt Hindenburg authored
      Summary:
      This patch adds a read-only option for TerminalDisplays. When active,
      all keyboard events are eaten. Mouse input is not affected and works like before.
      The setting is not persisted and only lasts for the duration of the session.
      
      Screenshots:
      {F5730786}
      {F5730788}
      {F5730789}
      
      VDG input is highly appreciated. Also, I'm not sure if I can just change the rc-files without bumping the version?
      
      FEATURE: 126930
      
      Test Plan:
      - Shortcuts still work
      - Paste and drop actions are disabled when readonly
      - Switching between read-only and normal tabs works as expected
      - Mouse input works like before
      
      Reviewers: #konsole, hindenburg
      
      Reviewed By: #konsole, hindenburg
      
      Subscribers: hindenburg, ngraham, #konsole
      
      Tags: #konsole
      
      Differential Revision: https://phabricator.kde.org/D10862
      4f555265
  8. 15 Feb, 2018 1 commit
  9. 14 Feb, 2018 3 commits
  10. 21 Jan, 2018 1 commit
    • Kurt Hindenburg's avatar
      Reverts: Fix double click can only select text within visible region · f98c752b
      Kurt Hindenburg authored
      Partial revert of 914067d1
      
      Change to use old code while leaving (not used) new code in.
      
      Fixes reproduciable crashes:
      Konsole::TerminalDisplay::findWordEnd()
      Konsole::TerminalDisplay::charClass(image[j]); -> invalid location
      
      I was not able to get the triple click code to crash which was the
      previous patch to this.
      
      BUG: 338997
      FIXED-IN: 18.04
      f98c752b
  11. 03 Jan, 2018 3 commits
  12. 01 Jan, 2018 3 commits
  13. 25 Dec, 2017 1 commit
  14. 16 Jul, 2017 1 commit
  15. 17 Jun, 2017 2 commits
  16. 15 Jun, 2017 1 commit
  17. 08 May, 2017 1 commit
  18. 27 Apr, 2017 1 commit
  19. 22 Apr, 2017 1 commit
  20. 21 Apr, 2017 3 commits
  21. 12 Apr, 2017 1 commit
  22. 01 Apr, 2017 1 commit
  23. 31 Mar, 2017 1 commit
  24. 30 Mar, 2017 1 commit
  25. 29 Mar, 2017 1 commit
  26. 28 Mar, 2017 1 commit
  27. 18 Feb, 2017 2 commits