Luis Javier Merino authored May 26, 2022 and Tomaz Canabrava committed Jul 03, 2022

GCC complains of enumeration values Vt52Escape, Vt52CupRow and
Vt52CupColumn not being handled in switch, but they cannot occur on
non-VT52 mode.

Luis Javier Merino authored May 24, 2022 and Tomaz Canabrava committed Jul 03, 2022

Case ranges is a GNU extension. Use if-elseif-else constructs instead.

Luis Javier Merino authored May 22, 2022 and Tomaz Canabrava committed Jul 03, 2022

This adds supports for sub-parameters in control sequences. For now, it
supports the colon-separated variants of SGR 38 and SGR 48 for RGB and
indexed colours:

CSI 38 : 2 : <id> : <red> : <green> : <blue> [ : ... ] m
CSI 38 : 2 : <red> : <green> : <blue> m
CSI 38 : 5 : <index8> m

and likewise for SGR 48. <id> is ignored (it's supposed to be a colour
space id, to support different kinds of RGB).

Luis Javier Merino authored Mar 03, 2022 and Tomaz Canabrava committed Jul 03, 2022

Substitute konsole's old vt102 parser with one based on the diagram at
vt100.net.

Williams, Paul Flo. “A parser for DEC’s ANSI-compatible video
terminals.” VT100.net. https://vt100.net/emu/dec_ansi_parser

Liu Bodong authored Jun 24, 2022 and Tomaz Canabrava committed Jul 03, 2022

close #32

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Matan Ziv-Av authored Jun 25, 2022 and Tomaz Canabrava committed Jul 02, 2022

QRect::MoveLeft is the wrong operation. We really want QRect:setX,
in order to leave the right edge of the rectangle in the same position.

Marius Pa authored Jun 26, 2022 and Tomaz Canabrava committed Jul 02, 2022

The "return" in "#define QCOMPARE(actual, expected)" does not allow us
to delete the new-ed objects. This raises clangd "konsole/src/autotests/TerminalTest.cpp:28:5:
Potential leak of memory pointed to by 'display' [clang-analyzer-cplusplus.NewDeleteLeaks]"
and PVS-Studio V773.

Marius Pa authored Jun 26, 2022 and Tomaz Canabrava committed Jul 02, 2022

The "return" in "#define QCOMPARE(actual, expected)" does not allow us
to delete the new-ed objects.
This raises clangd
"Potential leak of memory pointed to by 'X' [clang-analyzer-cplusplus.NewDeleteLeaks]"
and PVS-Studio V773.

Georg Gadinger authored Jun 28, 2022 and Tomaz Canabrava committed Jul 02, 2022

The split-view actions define a shortcut using `Konsole::ACCEL`, which
since !609 expands to `Qt::CTRL | Qt::SHIFT` on systems that aren't
macOS.  This breaks the shortcut for the split-view actions however as
`Qt::Key_ParenLeft` and `Qt::Key_ParenRight` do not work with the
`Qt::SHIFT` modifier.

Using `Qt::CTRL` (Cmd on macOS, Ctrl everywhere else) as the base
accelerator for these two actions makes splitting views work again as
expected.

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

(cherry picked from commit 9da53bc0)

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

ecm_set_disabled_deprecation_versions() in versions < 5.96 was brokwn
when it comes to SHOW_DEPRECATIONS, warnings for newer deprecations
were disabled if the flag was set or not.
Starting with ECM 5.96 the macro now enables warnings by default,
so the flag is no longer needed.

GIT_SILENT

Matan Ziv-Av authored Jun 11, 2022 and Tomaz Canabrava committed Jun 24, 2022

QStringView is in QT-5.15.0, which is the minimum version, so no need for ifdefs.

Georg Gadinger authored Jun 21, 2022 and Kurt Hindenburg committed Jun 21, 2022

This change removes some application attributes that are not necessary anymore (like disabling the global menu bar) or make Konsole behave slightly different when used from a KPart (e.g. inside Kate), and changes some keyboard shortcuts around (mainly using Command instead of Ctrl+Shift now.)

Unfortunately this does not resolve the requirement for the special keytab file for macOS; it looks like Qt does something funny with the QKeyEvents here: on Linux these have a `text` attribute set to e.g. `\u0003` for `^C`, that attribute is empty on macOS.

Note this could impact shortcut changes on non-macOS systems.

Matan Ziv-Av authored Jun 17, 2022 and Kurt Hindenburg committed Jun 20, 2022

This flag is used for cells where the background is not drawn
unlike RE_CONCEAL, which draws background, but not foreground.

This flag is used for cells where an unmanaged image is placed.

Matan Ziv-Av authored Jun 17, 2022 and Kurt Hindenburg committed Jun 20, 2022

It is not used anywhere.

Ahmad Samir authored Jun 09, 2022 and Kurt Hindenburg committed Jun 20, 2022

These two QTimer members were initilized in-class, since they aren't
pointers, and then assigned to in the constructor initializer list.

Ahmad Samir authored Jun 10, 2022 and Kurt Hindenburg committed Jun 20, 2022

And rename DefaultPropertyNames to DefaultProperties.

Default profile properties are now specified in the DefaultProperties
container directly, which simplifies creating the Built-in profile, and
keeps the properties info in one place.
- Name, Path: are empty by default, and set to the special values of the
  built-in profile in useBuiltin()
- Some properties have to be set at runtime, rather than compile time e.g.
  Command, Font, DefaultEncoding.

Al Williams authored Jun 17, 2022 and Tomaz Canabrava committed Jun 18, 2022

BUG:455290

Luis Javier Merino authored Jun 14, 2022 and Kurt Hindenburg committed Jun 16, 2022

To prevent URIs inside parentheses from getting extended to the closing
parenthesis, only recognize URIs with balanced parentheses in regname,
path, query and/or fragment.  We still allow unbalanced parenthesis in
userInfo, since the postfix @ should prevent most ambiguous situations,
and the parenthesis can be part of a password.

CCBUG: 455166

Ahmad Samir authored Jun 12, 2022 and Kurt Hindenburg committed Jun 16, 2022

CCBUG: 455166
FIXED-IN: 22.08

This way we get a build time warning if the var isn't defined at all, e.g.
a missing check_include_files() CMake call.