1. 06 Sep, 2021 1 commit
  2. 02 Sep, 2021 1 commit
  3. 01 Sep, 2021 1 commit
  4. 31 Aug, 2021 1 commit
  5. 27 Aug, 2021 3 commits
  6. 20 Aug, 2021 1 commit
  7. 18 Aug, 2021 1 commit
  8. 17 Aug, 2021 1 commit
  9. 13 Aug, 2021 3 commits
    • Ahmad Samir's avatar
      Fix KXmlGUI toolbars; and Konsole MainWindow size · fb7f838f
      Ahmad Samir authored
      Call setupGUI(), which will call createGUI (since we set the
      KXmlGuiWindow::Create flag), omit the StatusBar flag since we don't have a
      statusbar and don't want the "Show StatusBar" menu action.
      
      TabbedViewContainer::sizeHint() calculates an optimum size for itself,
      including the sizes of its child widgets; added in efb621d0 by
      Mariusz Glebocki; following the code:
      MainWindow creates a ViewManager
      ViewManager creates a TabbedViewContainer and then a TerminalDisplay
      
      which means that the first time TabbedViewContainer::sizeHint() is called
      the TerminalDisplay widget size is 0, then TabbedViewContainer::sizeHint()
      would return 0.
      
      Which is why calling resize() in MainWindow was delayed to the showEvent(),
      (and even delayed more by a QTimer::singleShot() call in Application),
      at which point all the child widgets have been created and
      MainWindow::sizeHint() (which logically takes into account the sizeHint()
      of its child widgets) would return a sensible size.
      
      CCBUG: 430036
      CCBUG: 439339
      BUG: 436471
      
      
      (cherry picked from commit 09035666)
      fb7f838f
    • Ahmad Samir's avatar
      Fix crash when setting blur effect · f24dd6ac
      Ahmad Samir authored
      Basically to use QWidget::windowHandle() to get a QWindow*, we need to first
      set the Qt::WA_NativeWindow attribute on the QWidget. See:
      https://phabricator.kde.org/D23108
      
      BUG: 439871
      FIXED-IN: 21.12
      (cherry picked from commit a6b2bd53)
      f24dd6ac
    • Ahmad Samir's avatar
      Prevent window "flashing" when closing the last session · c8d60923
      Ahmad Samir authored
      There are two scenarios when closing a window:
      A) clicking the close button on the title bar (or Ctrl+Shift+Q):
      ~MainWindow()
      ~ViewManager()
      ~TabbedViewContainer()
      ~TerminalDisplay()
      ~Session()
      
      B) closing the last session/tab in a window:
      SessionController::sessionFinished()
      ~Session()
      ~TerminalDisplay()
      ~TabbedViewContainer()
      ~MainWindow()
      ~ViewManager()
      
      the issue with the second case is that the TerminalDisplay is torn down
      first, which exposes the TabbedViewContainer widget, the latter has the same
      Qt::Window colour as the system colour scheme window background colour, if
      you're using a dark terminal colour scheme and a light-coloured system colour
      scheme, you could see some "flashing" when you close the last session with
      e.g. Ctrl+D.
      
      To fix this, in sessionFinished() check if TabbedViewContainer::count() is
      1 (i.e. closing last tab/session), and emit the empty() signal in that case,
      which is connected to MainwWindow::close(), then the order of tear down
      becomes:
      SessionController::sessionFinished()
      ~Session()
      ~MainWindow()
      ~ViewManager()
      ~TabbedViewContainer()
      ~TerminalDisplay()
      
      BUG: 432077
      FIXED-IN: 21.12
      (cherry picked from commit bbec7225)
      c8d60923
  10. 04 Aug, 2021 2 commits
  11. 27 Jul, 2021 1 commit
  12. 26 Jul, 2021 1 commit
  13. 22 Jul, 2021 1 commit
  14. 21 Jul, 2021 1 commit
  15. 19 Jul, 2021 3 commits
  16. 12 Jul, 2021 1 commit
  17. 11 Jul, 2021 1 commit
  18. 10 Jul, 2021 1 commit
  19. 09 Jul, 2021 4 commits
  20. 08 Jul, 2021 2 commits
  21. 07 Jul, 2021 3 commits
  22. 06 Jul, 2021 3 commits
  23. 05 Jul, 2021 2 commits
  24. 03 Jul, 2021 1 commit