The code assumes one environment variable per line, but users may
not guess out that assumption without prompt.

This is a common misspelling.

This commit is purely about style and layourt. No functionality changes.

This avoids potential doubt about its type and memory leak.

The patch(slightly modified) is from Gu Rui <chaos.proton@gmail.com>

REVIEW: 102507

The patch is provied by Gu Rui <chaos.proton@gmail.com>

REVIEW: 102506

Use the right command value instead of a duplicated.

This is a follow-up of 2dcd5842.

BUG: 280931

Since libkonq is required, it makes little sense to optionally find it.

Reported by:	krop

(cherry picked from commit 95e30b58)

Follow-up to 2dcd5842.

konsole is not in the same repository as libkonq anymore, so we need
to check if it is installed before using it, and it is also better to
use the whole library path when linking instead of hardcoding "konq".

CCMAIL: konsole-devel@kde.org

It is possible that users invoke konsole from terminal in the form of
'konsole &> /dev/null' to get rid of warning messages. Checking stdout
won't give expected result.

On the other hand, 'konsole < ....' is almost never used. So checking
stdin should be more reliable.

That function just reports whether new konsole process should be use. It
has no side effect and does not create new process, while the old name
may give the impression that it does.

FEATURE: 203768
FIXED-IN: 4.8

BUG:204741
FIXED-IN: 4.8

The old code will delete & create decoder twice if the argument is
NULL.

It is generally a good idea to pass more keyboard actions into terminal
process, instead of intercepting them. Anyway, Uses can still define the
alternative shortcuts themselfes if they want.

BUG: 188941
FIXED-IN: 4.8

That change causes crash when detaching session. Weird.

This reverts commit 458095e8.