1. 22 Nov, 2018 1 commit
    • Andrew Smith's avatar
      Remove option to hide application name from titlebar · d1e5296e
      Andrew Smith authored
      Summary:
      Since the application name is added by Qt, it is no longer
      possible to remove the trailing '- Konsole' so the GUI
      option is obsolete.
      
      BUG: 364391
      FIXED-IN: 19.03
      
      Test Plan:
      Change settings for existing Konsole and notice that the checkbox
      doesn't change anything. After applying this the checkbox should
      be removed.
      
      Reviewers: #konsole, konsole-devel, hindenburg
      
      Reviewed By: #konsole, hindenburg
      
      Subscribers: konsole-devel
      
      Tags: #konsole
      
      Differential Revision: https://phabricator.kde.org/D17049
      d1e5296e
  2. 20 Nov, 2018 2 commits
  3. 16 Nov, 2018 1 commit
    • David Edmundson's avatar
      Re-add DBus test · 3eb9a34f
      David Edmundson authored
      Summary:
      Ported from KProcess::startDetached to a QProcess we can kill should the
      window not exit when closed.
      
      On the KDE CI where the window isn't quitting on close the test might
      fail, but it will give us output where we can investigate.
      
      Test Plan: Passes locally
      
      Reviewers: #konsole, #frameworks, hindenburg
      
      Reviewed By: #konsole, hindenburg
      
      Subscribers: hindenburg, konsole-devel
      
      Tags: #konsole
      
      Differential Revision: https://phabricator.kde.org/D16919
      3eb9a34f
  4. 13 Nov, 2018 2 commits
  5. 11 Nov, 2018 3 commits
    • Kurt Hindenburg's avatar
      Add three missing tests for tokens · 274214f4
      Kurt Hindenburg authored
      For completeness, add more tests for the macro->constexpr changes from
      earlier.  At some point, these tests can be disabled.
      274214f4
    • David Hallas's avatar
      Add StartupWMClass to .desktop file · 1506ecdf
      David Hallas authored
      The org.kde.konsole.desktop file is missing a StartupWMClass setting.
      
      BUG: 372441
      FIXED-IN: 18.12
      
      Differential Revision: https://phabricator.kde.org/D16546
      1506ecdf
    • Glenn Coombs's avatar
      Preserve double/triple click mode when extending the selection · e2167eb0
      Glenn Coombs authored
      Summary:
      When extending the selection using the mouse the double or triple click
      mode that initiated the selection should be preserved.  If the user double
      clicked to select a word, then extending the selection should extend
      "word at a time" rather than "character at a time". Similarly if the user
      triple clicked to select a whole line initially, then extending the selection
      should extend "line at a time" rather than "character at a time".
      
      BUG: 374454
      FIXED-IN: 18.12
      
      Reviewers: #konsole, hindenburg
      
      Reviewed By: #konsole, hindenburg
      
      Subscribers: konsole-devel
      
      Tags: #konsole
      
      Differential Revision: https://phabricator.kde.org/D16660
      e2167eb0
  6. 10 Nov, 2018 2 commits
  7. 09 Nov, 2018 1 commit
  8. 08 Nov, 2018 3 commits
  9. 07 Nov, 2018 3 commits
  10. 03 Nov, 2018 1 commit
  11. 02 Nov, 2018 2 commits
    • Kurt Hindenburg's avatar
      473461f0
    • Nate Graham's avatar
      Don't consider a colon before whitespace to be part of a word · 9ce05137
      Nate Graham authored
      Summary:
      Currently, colons are considered to be part of words for the purpose of
      double-click selection. This allows, for example, URLs to be selected
      with a double click. This is good.
      
      However, including colons works less well for paths that end with a colon
      and whitespace--such as `grep` output. Removing the colon from the list
      of word characters isn't a great solutionsince then URLs can no longer be
      selected by double-clicking.
      
      This patch resolves that particular issue by always omitting a colon from
      double-click selection when it's immediately followed by whitespace.
      
      BUG: 399291
      FIXED-IN: 18.12.0
      
      Test Plan:
      `grep -ri charClass .`
      Then double-click on one of the paths in the output. The trailing colon
      is not included in the selection.
      
      Reviewers: #konsole, hindenburg
      
      Reviewed By: #konsole, hindenburg
      
      Subscribers: konsole-devel
      
      Tags: #konsole
      
      Differential Revision: https://phabricator.kde.org/D16578
      9ce05137
  12. 01 Nov, 2018 2 commits
  13. 28 Oct, 2018 13 commits
  14. 27 Oct, 2018 4 commits