GitLab

Mariusz Glebocki authored Oct 11, 2019 and Kurt Hindenburg committed Oct 23, 2019

File name was just passed around and has been always initialized to
default value in outside code.

Mariusz Glebocki authored May 16, 2018 and Kurt Hindenburg committed May 16, 2018

Summary:
Currently Unicode uses 0x10FFFF code points. It is possible to represent
all of them with up to two 16 bit values (UTF-16), but this makes it
harder to e.g. check for their width.

Some test cases were changed. Originally they were added with an
assumption that the code point will be truncated to 16 bit value and
as a result changed to another code point.

Test Plan:
* All code points <= 0xFFFF should work as before
  * Start the same tmux session in two Konsoles
  * Change background to fully transparent in one of them and put it in
    front of the other one, so that all text will overlap
  * Generate characters with (you can pipe it to `fold -s | less -r`):
```
perl -XCSDL -e 'print map{chr($_), " "} 1..0xffff'
```
  * Compare output visually.

* Code points > 0xFFFF should not be truncated to 16 bits
  * "𝐀" and "퐀" should be different characters

* Some code points > 0xFFFF should have single width
  * Vertical lines below should align:
```
|𝐀 |
|𠀋|
```

Reviewers: #konsole, hindenburg

Reviewed By: #konsole, hindenburg

Subscribers: konsole-devel, hindenburg, #konsole

Tags: #konsole

Differential Revision: https://phabricator.kde.org/D12236

s/0/nullptr/

Revamp the file-based "unlimited" scrollback code to remove limits
caused by 32bit file offsets. Use Qt's I/O functions which are
buffered and use 64bit offsets. Use Qt's map instead of direct mmap
to ensure consistency. Prevent wrap-around of readWriteBalance.

Patch from FreeBSD committed by rezny

https://github.com/freebsd/freebsd-ports-kde/blob/master/x11/konsole/files/patch-src_History.cpp
https://github.com/freebsd/freebsd-ports-kde/blob/plasma5/x11/konsole/files/patch-fix_infinite_scrollback

CCBUG: 374259

Adds faint intensity, strikeout, conceal and overline support.

echo -e 'D\e[2mD\e[9mD\e[53mD\e[8mD'

Thanks to Antonio Russo antonio e russo gmail com for patch

REVIEW: 128405
BUG: 362171
(cherry picked from commit 84b43dfb)

Adds faint intensity, strikeout, conceal and overline support.

echo -e 'D\e[2mD\e[9mD\e[53mD\e[8mD'

Thanks to Antonio Russo antonio e russo gmail com for patch

REVIEW: 128405
BUG: 362171

REVIEW: 123881

(cherry picked from commit ed4c55c0)

(cherry picked from commit ec03567f)

(cherry picked from commit 0b947727)

Apparently I didn't take a close look at the implementation detail of
memory-based history when I added the 'isRealCharacter' flag. That
missing information causes some wrong behaviors randomly when using
memory-based history.

This is a follow up of commit dc2b64d33(for BUG 188528)

BUG: 294330
BUG: 299252
FIXED-IN: 4.8.4