GitLab

Konsole has builtin code to manually write out line characters.  There
are certain reasons why this might not be desired.  This adds a profile
option to use the fonts line characters.  The default is as-is today
using the builtin code.

BUG: 364992
(cherry picked from commit a4de3feb)

Implements a feature from e. g. good old Konqueror/KHTML, where you got
a number overlaid all links when pressing ctrl, and then you could press
ctrl+number to activate that link.

REVIEW: 128348

This patch allows the dnd menu to be disabled, making it possible to
drag and drop URLs as text by default.

Thanks to Peter Wu peter lekensteyn nl for patch

REVIEW: 124908
BUG: 304290

Crash research/fix by Alexander Richardson arichardson kde gmail com

FIXED-IN: 3.0.0
REVIEW: 121108
(cherry picked from commit 1826b91d)

REVIEW: 120493

Move code responsible for 'forgetting' a view outside of code responding to the
TerminalDisplay deletion.

This avoids a loop like this:

~MainWindow
=> ~QStackedWidget
=> ~TerminalDisplay
=> QObject::destroyed
=> ViewContainer::viewDestroyed
=> ViewContainer::removeViewWidget
   - internal cleanup
   - try to remove TerminalDisplay from QStackedWidget which is being deleted and
crash

Instead the code now does:

~MainWindow
=> ~QStackedWidget
=> ~TerminalDisplay
=> QObject::destroyed
=> ViewContainer::viewDestroyed
=> ViewContainer::forgetView (does the internal clean up)

And if one tries to explicitly remove a view, sequence is:

ViewContainer::removeView
=> ViewContainer::forgetView
=> ViewContainer::removeViewWidget

The patch also removes ViewManager::focusActiveView() because it causes a crash
when closing a TerminalDisplay as it tries to put the focus on the deleted
TerminalDisplay. I initially called it through a queued connection, but realized
it is actually not needed for focus to be passed to the correct view, so just
removed it.

BUG: 331724
REVIEW: 118839

REVIEW: 117482

New feature in 2.13 allows columns/rows in profiles; however, the
rows would be incorrect depending on if tabbar was visible.  Ideally,
this should not be needed but I would guess this won't get fixed
correctly until frameworks timeframe.
This calculation can still be wrong if ShowNavigationAsNeeded and
perhaps other times depending on height of tabbar.

FIXED: 2.13
(cherry picked from commit 73e1db3e)

New feature in 2.13 allows columns/rows in profiles; however, the
rows would be incorrect depending on if tabbar was visible.  Ideally,
this should not be needed but I would guess this won't get fixed
correctly until frameworks timeframe.
This calculation can still be wrong if ShowNavigationAsNeeded and
perhaps other times depending on height of tabbar.

FIXED: 2.13

With the recent new code, profiles can have the terminal col/rows.
Everyone will notice that the rows won't match what Konsole uses.

(cherry picked from commit 90691643)

This removes the profile setting to 'Save window size upon exit'.  Now
it is in the Konsole settings; each profile can now set desired column
and row size.

Konsole Settings->Configure Konsole->General->Use current window size
on next startup:
Enabled - ignores all profile size settings - uses previous window size
Disabled - profile size settings are used - set via Edit Current
 Profile 1st tab

Only new windows will use "new" col/row/size settings.

BUG: 152385
REVIEW: 115628
FIXED-IN: 2.13
(cherry picked from commit 931d64df)

With the recent new code, profiles can have the terminal col/rows.
Everyone will notice that the rows won't match what Konsole uses.

This removes the profile setting to 'Save window size upon exit'.  Now
it is in the Konsole settings; each profile can now set desired column
and row size.

Konsole Settings->Configure Konsole->General->Use current window size
on next startup:
Enabled - ignores all profile size settings - uses previous window size
Disabled - profile size settings are used - set via Edit Current
 Profile 1st tab

Only new windows will use "new" col/row/size settings.

BUG: 152385
REVIEW: 115628
FIXED-IN: 2.13

(cherry picked from commit 43f7d5b3)

TerminalDisplayAccessible is disabled for Qt5 currently since I don't
have any experience with accessible stuff and it is more complicated
than just changing a few includes

REVIEW: 111937

Too many issues/crashes for too long when detaching on MacOSX.  You
can still some strange things but I can't get it to crash now.

BUG: 210871
REVIEW: 107640
FIXED-IN: 4.12

This reverts commit 4adfbe84.

This work will go into a new branch instead

To build for KF5 pass the option -DQT5_BUILD=ON to CMake

TerminalDisplayAccessible is disabled for Qt5 currently since I don't
have any experience with accessible stuff and it is more complicated
than just changing a few includes

REVIEW: 111937

Instead of keeping track of constants and +1 -1, use a QRect to handle
the terminal margins.  There is no GUI for this currently and the
margins are hard-coded to what they are now.  Code to center the
terminal is also include (w/o GUI).

This patch comes from review 109891 w/ a few changes from me.
Thanks to Mariusz Glebocki mglb@arccos-1.net

The current was 10; Ingo Molnar suggested 14 via email.  I have a
keyboard with 19 so that seems a reasonable limit.

The default is still half page - there is no GUI to change this;
either use konsoleprofile or change the .profile manually.

CCBUG: 280637

All these are in the comments - no code changes

The built-in behavior of Ctrl+<Mouse Wheel> to zoom in/out the terminal
can not be disabled. This patch adds an option to disable this
behavior. (Default to the original behavior).

Original patch by Yichao Yu yyc1992@gmail.com
I made some changes - bugs are mine as usual
REVIEW: 107281
FIXED-IN: 4.11
GUI:

In the ongoing issue with spaces at the end of lines, this allows for
an option to trim the spaces.  By default, it is disabled so only
people who need this will be affected.

Many thanks to David Smid <david@smidovi.eu>

CCBUG: 188528

So if someone notices later some Qt header is included in the form
of "#include <Class>" instead of the more common form of "#include
<Module/Class>", do not rush changing it.

REVIEW: 105819

use git diff -w --ignore-all-space to see non-space changes

Thanks to Asko Eronen<asko.eronen@gmail.com> for the idea and patch

REVIEW: 105282
FEATURE:
DIGEST: