GitLab

Friedrich W. H. Kossebau authored Jun 22, 2021 and Kurt Hindenburg committed Jun 22, 2021

GIT_SILENT

The recent change of blending the background/foreground colours for text
selection doesn't work everywhere, users with vision impairment or
colour-blindness would probably find it hard to distinguish text selection
colours; and the current code can't possibly cover all variations of colour
schemes out there. The same goes with certain displays and viewing angles,
some display types are notoriously awful when viewed at an angle.

BUG: 435309
FIXED-IN: 21.08

- Add a type alias for QPointer<Session>
- Use TerminalDisplay::setSessionController() as early as possible
- Use Screen::setCurrentTerminalDisplay() in TerminalDisplay::mousePressEvent(),
  this matches what's being done in keyPressEvent()
- Add convenience function TerminalDisplay::currentSession()
- More const

Tomaz Canabrava authored Jun 15, 2021 and Tomaz Canabrava committed Jun 18, 2021

This test currently is bogus, as soon as I reflow the Screen
object, the data is not correct. If anyone can check what I'm
doing wrong here it's appreciated.

The idea is that I pass a large string "aaa bbb ccc ddd" then
force a reflow for:

"aaa bbb
ccc ddd"

then I could copy only the column

bbb
ddd

Because the setSize did not work for that, the test is bogus.
but it's a start.

Carlos Alves authored Jun 10, 2021 and Kurt Hindenburg committed Jun 15, 2021

Avoid deep copy using 'at()' and '++' before variable instead of after.

Carlos Alves authored Jun 08, 2021 and Kurt Hindenburg committed Jun 15, 2021

Added access changes using 'at()' at reflow code to avoid deep copy.

Carlos Alves authored Jun 08, 2021 and Kurt Hindenburg committed Jun 15, 2021

Added access changes using 'at()' at reflow code to avoid deep copy.

This will make it possible to snap the splitters when you
resize (to be configurable)

Luis Javier Merino authored Mar 23, 2021 and Tomaz Canabrava committed Jun 07, 2021

AutoScrollHandler generates synthetic mouse moves to allow extending the
selection by dragging the mouse ouside the display area.  The synthetic
events it generates didn't carry any modifiers, so they were not
properly working when an application had requested mouse tracking
reports.  In that case, generate the events with ShiftModifier, so they
work properly.

Luis Javier Merino authored Mar 23, 2021 and Tomaz Canabrava committed Jun 07, 2021

As gumix explains in the bug below, "Konsole keeps sending mouse-drag
reports in ESC[?1003h mode after releasing button outside window [...]
The only way to stop it is to get mouse back over Konsole window."

These mouse-drag reports are actually generated by AutoScrollHandler, to
support the use case of extending the selection by dragging the mouse
outside the display area.

So, only generate those reports while selecting.

Can be tested by playing around in vttest:

 - 11. Test non-VT100 (e.g., VT220, XTERM) terminals
 - 8. Test XTERM special features
 - 5. Mouse features
 - 7. Mouse Button-Event Tracking (XFree86 xterm)

BUG: 391975

Luis Javier Merino authored Mar 23, 2021 and Tomaz Canabrava committed Jun 07, 2021

AutoScrollHandler allows to extend the selection by dragging the mouse
outside the display.  It does this by generating synthetic mouse move
events when the left mouse button is held down and the mouse is moved
outside of the display area.  This improves the user experience of
extending the selection to cover text that is scrolled outside the
display area.

Unfortunately, this was broken by commit
6667d96e, which filters out mouse move
events if they don't change the character cell position.  So, modify the
filtering a bit, allowing mouse movements outside the display area to
pass through.

Luis Javier Merino authored Mar 22, 2021 and Tomaz Canabrava committed Jun 07, 2021

Something was swallowing mouse moves on the top left 100x30 pixels of
TerminalDisplay.  As it turns out, it was the widgets for TerminalFonts
and TerminalColor.  Neither of them really needs to be a QWidget.

TerminalColor emits the onPalette(const QPalette &) signal, has slots,
and overrides event(QEvent &), so turn it into a QObject.

TerminalFonts doesn't do any of the above, turn it into a plain C++
object.

Now that TerminalFonts is no longer a QObject, manage it with a
std::unique_ptr.

TerminalFonts::fontChange(const QFont &) was calling update(), which was
probably a leftover from when it was split from TerminalDisplay.  Get
rid of it.  Trivial testing using keyboard shortcuts to change font size
(Ctrl++, Ctrl+-, Alt+Ctrl+0), and previewing font changes on "Edit
Current Profile..." seem to indicate that it isn't needed.

Luis Javier Merino authored Mar 21, 2021 and Tomaz Canabrava committed Jun 07, 2021

Mode 1003 reports all mouse movement.  Support it in Konsole.

BUG: 391967
BUG: 416530
BUG: 423333

Luis Javier Merino authored Mar 18, 2021 and Tomaz Canabrava committed Jun 07, 2021

xterm's DECSET 1000 requests justs press and release notifications, so
do not send move events on this mode.

BUG: 302731

Luis Javier Merino authored Mar 18, 2021 and Tomaz Canabrava committed Jun 07, 2021

On xterm, modes 9 (X10 legacy, button press), 1000 (button press and
release), 1001 (mouse highlight tracking), 1002 (mouse drag) 1003 (mouse
move) and DECELR (DEC Locator) are mutually exclusive.

So are 1005 (extended coordinates mode), 1006 (SGR extended
coordinates), 1015 (urxvt extended coordinates) and 1016 (use pixel
coordinates).

On xterm, disabling any of the 9, 1000, 1001, 1002, 1003, DECELR modes
disables mouse tracking.  To disable the extended coordinate modes
(1005, 1006, 1015, 1016), the current mode should be disabled.

So, do the same for the modes Konsole supports.

Luis Javier Merino authored Mar 16, 2021 and Tomaz Canabrava committed Jun 07, 2021

The read-only property wasn't being respected for mouse move and mouse
release events.

Luis Javier Merino authored Mar 15, 2021 and Tomaz Canabrava committed Jun 07, 2021

As explained by magiblot at the bug below, "When double clicking with
the right button, the sequences sent to the application in the terminal
are DOWN-UP-UP instead of DOWN-UP-DOWN-UP."

BUG: 425926

CCBUG: 432376
CCMAIL: cbc.alves@gmail.com

Tomaz Canabrava authored May 28, 2021 and Tomaz Canabrava committed Jun 07, 2021

When a Splitter has only one child, it can be removed, and the
child can be united with the widget above, unless it's the only
splitter - as that holds the main widget.

(cherry picked from commit 1a62df92)