1. 13 Apr, 2008 1 commit
  2. 12 Apr, 2008 1 commit
    • Robert Knight's avatar
      Use a new warning box widget for the 'transparency not supported' warning labels. · 366f9eaa
      Robert Knight authored
      The new widget respects the current KDE color scheme.
      
      BUG: 156119
      
      Squashed commit of the following:
      
      commit c7d81f7c65d2be87a4b70f485da6ec1b91be76b9
      Author: Robert Knight <robertknight@gmail.com>
      Date:   Sat Apr 12 11:05:11 2008 +0100
      
          Use the warning box for the 'transparency not supported' warning display in the color scheme and profile editors.
      
      commit e4149b67588123540144f0496257194058c92fe4
      Author: Robert Knight <robertknight@gmail.com>
      Date:   Sat Apr 12 11:04:25 2008 +0100
      
          Add WarninBox to build.
      
      commit d82adc02b9aad6cb99660a9b2d48cce2e3c42418
      Author: Robert Knight <robertknight@gmail.com>
      Date:   Sat Apr 12 11:04:02 2008 +0100
      
          Add a generic warning box widget which uses colors from the current KDE color scheme.
      
      svn path=/trunk/KDE/kdebase/apps/konsole/; revision=796014
      366f9eaa
  3. 29 Mar, 2008 1 commit
    • Diego Iastrubni's avatar
      New backport (??) from KDE3: now each profile can enable/disable BiDi... · 60f0a0a5
      Diego Iastrubni authored
      New backport (??) from KDE3: now each profile can enable/disable BiDi rendering in the display. We need this since many console based application (vim, emacs, fribidi etc)
      implement their own BiDi algorithm. There is also another reason: comatibility. All terminals are *not* aware of the BiDi issue and do not re-order the chars
      (gnome-terminal, xterm, konsole, etc). It is possible to enable the BiDi rendering on each profile, so this is not a huge lost. I am still missing the keyboard shortcut to
      quickly enable/disable it (alt+control+b in konsole3), but I am not sure what is the best way for doing it.
      
      A quick note about the implementation:
      In QPainter3, there was an option to draw a text and tell the painter "please do not implement BiDi". In QPainter4 (up to 4.4) there is no such option. I am forcing it by
      drawing  "painter.drawText(rect,0,QChar(0x202D)+text)" (that is &LRO;), and it does seem to work, but I find it kinda "hackish". I will open a task in Trolltech and
      request that new feature. Hopefully by Qt4.5/KDE4.2 I will be able to change the implementation.
      
      
      svn path=/trunk/KDE/kdebase/apps/konsole/; revision=791374
      60f0a0a5
  4. 28 Mar, 2008 1 commit
  5. 22 Mar, 2008 1 commit
    • Robert Knight's avatar
      Squashed commit of the following: · 5036d8cb
      Robert Knight authored
      commit 99d61f9bdfe29347050162a5a675bb0c276bc1bf
      Author: Robert Knight <robertknight@gmail.com>
      Date:   Sat Mar 22 20:45:45 2008 +0000
      
          Allow a normal frame around the table view in ManageProfilesDialog.  Works better with Oxygen style.
      
      commit 7075de00d8cc88568e108e868e08d071d5aa7bcb
      Author: Robert Knight <robertknight@gmail.com>
      Date:   Sat Mar 22 20:37:38 2008 +0000
      
          Change base class of ProfileItemDelegate from QItemDelegate to QStyledItemDelegate for better rendering.  Fix updates of favorite / non-favorite status in ManageProfilesDialog.  QVariant equality comparisons are not properly supported for custom types so QAbstractItemModel::match() has to be replaced with manual iteration through the rows.
      
      commit 3baa3307473e037efd500ade7df37d2fd62c60d9
      Author: Robert Knight <robertknight@gmail.com>
      Date:   Sat Mar 22 20:09:27 2008 +0000
      
          Remove unecessary deleteProfile() call.  Explicitly add new profiles to the SessionManager.  Mark the temporary profile in the EditProfileDialog as hidden.
      
      commit 53d1e3515d3408c08ba4b019b5faceffae6b0f8a
      Author: Robert Knight <robertknight@gmail.com>
      Date:   Sat Mar 22 20:02:28 2008 +0000
      
          Do not track deletion of temporary un-named profiles.
      
      commit 55c69e15a4247319b0cff73691f072fef39684c9
      Author: Robert Knight <robertknight@gmail.com>
      Date:   Sat Mar 22 20:01:25 2008 +0000
      
          Make SessionManager::addProfile() public.  Call it automatically in SessionManager::setFavorite() if the profile is not already known to the manager.  When a profile is deleted via SessionManager::deleteProfile() mark it as hidden so that it is not recreated on disk if later changed.  Add debugging in ~Profile to track deletion of profiles.
      
      commit 7a028bac5846cd3689e3351ab139c6f372ca173e
      Author: Robert Knight <robertknight@gmail.com>
      Date:   Sat Mar 22 19:41:22 2008 +0000
      
          Fix several signal/slot connections in ManageProfilesDialog after the SessionManager changes.
      
      commit da7c7b4f939c17885cf0fbaa1fb93d2655021b83
      Author: Robert Knight <robertknight@gmail.com>
      Date:   Sat Mar 22 19:36:57 2008 +0000
      
          Use a helper class to pop elements from recursion guard stack when a call to loadProfile() returns rather than requiring a manual call to recursionGuard.pop()
      
      commit 14a993d15722ec5270de708154408896fd7418b8
      Author: Robert Knight <robertknight@gmail.com>
      Date:   Sat Mar 22 19:12:20 2008 +0000
      
          Fix profiles not being loaded properly if their parent was a profile which had already been loaded.  Profile paths were not being taken off the recursion guard stack at one exit from loadProfile().
      
      commit f946fc0cbde26cd816e3f1d172a5e5327ff3295b
      Author: Robert Knight <robertknight@gmail.com>
      Date:   Sat Mar 22 19:01:06 2008 +0000
      
          Adapt Part to the SessionManager/Profile changes.
      
      commit d3155ba0f6dc9ec0ca34a45b5787488c055dc4bf
      Author: Robert Knight <robertknight@gmail.com>
      Date:   Sat Mar 22 18:55:05 2008 +0000
      
          Update MainWindow API documentation to reflect string key -> ref counted pointer change for profiles.
      
      commit 5d546054c031ae6ee6915f2cc6bcf61dd4e03520
      Author: Robert Knight <robertknight@gmail.com>
      Date:   Sat Mar 22 18:53:16 2008 +0000
      
          Update SessionManager API documentation to reflect string key -> ref counted pointer change for profiles.
      
      commit 856fdf37a5bd81711ff0db1b307b8736ef4ae34e
      Author: Robert Knight <robertknight@gmail.com>
      Date:   Thu Mar 20 23:43:53 2008 +0000
      
          Fix assert.  Fall back to current locale's codec if a null pointer is passed to Emulation::setCodec()
      
      commit 127e894d076061b991934adf84256b651bf31724
      Author: Robert Knight <robertknight@gmail.com>
      Date:   Thu Mar 20 22:45:11 2008 +0000
      
          Replace string key for profiles with ref-counted profile pointer.
      
      commit 53246e5bd4ffcec56ca0ff94730f9ef3946e3f4c
      Author: Robert Knight <robertknight@gmail.com>
      Date:   Thu Mar 20 20:50:17 2008 +0000
      
          First step towards removing string keys as a means to reference profiles.  Change Profile base class from QObject to QSharedData and replace all usage of Profile* with KSharedPtr<Profile>
      
      svn path=/trunk/KDE/kdebase/apps/konsole/; revision=788936
      5036d8cb
  6. 09 Mar, 2008 1 commit
  7. 03 Mar, 2008 2 commits
  8. 01 Mar, 2008 1 commit
  9. 21 Feb, 2008 1 commit
  10. 17 Feb, 2008 1 commit
    • Bill Egert's avatar
      No longer use Obsolete Members for QPainter. · 8bf323e0
      Bill Egert authored
      drawRoundRect() => drawRoundedRect()  (This function was introduced in Qt 4.4)
      matrix() => worldTransform() 
      setMatrix() => setWorldTransform()
      
      svn path=/trunk/KDE/kdebase/apps/konsole/; revision=776270
      8bf323e0
  11. 15 Jan, 2008 1 commit
  12. 06 Jan, 2008 1 commit
  13. 04 Jan, 2008 1 commit
  14. 02 Jan, 2008 1 commit
    • Robert Knight's avatar
      Fix Cancel button in 'Select Font' dialog having no effect. A side-effect of... · d9cc9620
      Robert Knight authored
      Fix Cancel button in 'Select Font' dialog having no effect.  A side-effect of this commit is that the 'Select Font' dialog becomes modal.  Ensure that the font preview label's text stays in sync with its font by listening for FontChange events and setting the text in response.
      
      svn path=/trunk/KDE/kdebase/apps/konsole/; revision=755898
      d9cc9620
  15. 29 Dec, 2007 2 commits
    • Robert Knight's avatar
      · 46cfc108
      Robert Knight authored
      * Replace all usage of qDebug() with kDebug(), since kDebug() provides information about 
        which part of the code the message came from and allows filtering of output
        using kdebugdialog
      * Remove explicit creation of singleton classes SessionManager,ColorSchemeManager and
        KeyboardTranslatorManager and automate it with K_GLOBAL_STATIC.
        This ensures that the singleton destructors are called appropriately by KPart clients
        when they unload the libkonsolepart library.
      
      
      svn path=/trunk/KDE/kdebase/apps/konsole/; revision=754334
      46cfc108
    • Robert Knight's avatar
      Hide the 'Allow programs to resize terminal window' check box in the profile... · aa4d0f12
      Robert Knight authored
      Hide the 'Allow programs to resize terminal window' check box in the profile editor since the feature is not implemented yet.
      
      svn path=/trunk/KDE/kdebase/apps/konsole/; revision=754304
      aa4d0f12
  16. 18 Dec, 2007 1 commit
  17. 16 Dec, 2007 1 commit
  18. 08 Dec, 2007 1 commit
    • Robert Knight's avatar
      * Do not remove color schemes / key bindings from list if the · 8171d487
      Robert Knight authored
        call to delete the file fails.
      * Make deletion of color schemes, key bindings and profiles
        atomic operations from the point of view of outside classes.
      * Fix various warning produced by the -Woverloaded-virtual flag.
      
      
      svn path=/trunk/KDE/kdebase/apps/konsole/; revision=746168
      8171d487
  19. 07 Dec, 2007 1 commit
    • Robert Knight's avatar
      · 9863b550
      Robert Knight authored
      Bug fixes for the Appearance and Key Bindings tabs in the 
      Edit Profile dialog:
      
      * Fix selection of color schemes and key bindings not being
        remembered after the color scheme/key binding list is changed
        (eg. due to adding a new color scheme or editing an existing one).
      
        This also fixes the preview not being updated when mousing outside 
        the list after adding a new color scheme.
      
        -> After updates to the color scheme / key bindings list the model
           was being deleted and a new model was created.  This caused the
           selection model to be changed without the signal-slot connections
           from the selection model to the dialog being re-established.
      
           This commit changes that so that the model is not replaced but
           simply cleared when the color scheme / key binding list is updated.
      
      * Disable the Edit, Remove buttons on the Appearance and 
        Key Bindings tabs when there is no selection.
      * Fix crash when clicking 'New' button on the Appearance tab
        if the color scheme list is empty.
      * Fix crash when loading the Appearance tab if the color scheme
        associated with the profile does not exist
      * Fix crash when loading the Key Bindings tab if the key binding
        associated with the profile does not exist
      * Fix crash when attempting to load a color scheme with no name, 
        instead the color scheme is simply not loaded.
      * Fix all colors except one being set to black when making changes 
        to a color scheme which was based on the default fallback color scheme.
      
        -> When creating a new array inside the ColorScheme class to hold color
           entries, initialize its elements with values from the default color
           array.
      
      * Use qWarning() instead of qDebug() to print out error message if attempting
        to delete a color scheme fails.
      
      * Minor formatting changes in Session.cpp,SessionController.h
      
      
      Known bugs introduced by this commit:
          
      * Attempting to create a new keyboard translator when no existing translator
        is selected will crash because KeyboardTranslator::defaultTranslator() has
        not been implemented yet.
      
      svn path=/trunk/KDE/kdebase/apps/konsole/; revision=746071
      9863b550
  20. 23 Nov, 2007 1 commit
  21. 17 Nov, 2007 1 commit
  22. 09 Nov, 2007 1 commit
  23. 10 Oct, 2007 1 commit
  24. 13 Sep, 2007 1 commit
    • Robert Knight's avatar
      Delay the live preview of color schemes slightly. The cursor now has to hover... · 68971272
      Robert Knight authored
      Delay the live preview of color schemes slightly.  The cursor now has to hover above the same item for 300ms to make it trigger.  This (hopefully) solves the bug report about the automatic preview being inadvertantly triggered while trying to do other things in the dialog.
      
      svn path=/trunk/KDE/kdebase/apps/konsole/; revision=711856
      68971272
  25. 08 Sep, 2007 1 commit
  26. 31 Aug, 2007 1 commit
    • Robert Knight's avatar
      · 42dce037
      Robert Knight authored
      Changes:
      
      * Add a passive warning widget which is displayed when a color scheme is selected which 
        uses transparency but the system does not support transparency 
      * Always show the vertical scroll bar in the color scheme list
      * Remove quotes around links and email addresses in mouse-over tooltip
      
      Bug Fixes:
      
      * Fix a few odd behaviours with the live color scheme preview
      * Fix the 'Show in Menu' status of newly added profiles not being
        saved when Konsole exits.
      
        ( Update Profile's path property when saving the profile to 
          a new location )
      
      
      Internal: 
      
      * Removed many debugging statements and dead / commented out code
      * Fix several unused parameter warnings
      * API documentation corrections in Emulation class
      
      svn path=/trunk/KDE/kdebase/apps/konsole/; revision=706986
      42dce037
  27. 05 Aug, 2007 1 commit
  28. 21 Jul, 2007 1 commit
  29. 11 Jul, 2007 1 commit
    • Robert Knight's avatar
      Simplify changing the current color scheme and current key bindings in the... · 1c370c2d
      Robert Knight authored
      Simplify changing the current color scheme and current key bindings in the profile editor.  There is no longer a distinction between the color scheme selected for removal/editing and the color scheme selected for use by the profile.  Also select the current color scheme, current key binding when the relevant pages of the profile editor are shown.
      
      svn path=/trunk/KDE/kdebase/apps/konsole/; revision=686299
      1c370c2d
  30. 05 Jul, 2007 1 commit
    • Robert Knight's avatar
      · 37088799
      Robert Knight authored
      * Update the regular expression for the Url filter.  Anything in the form
        letters://any-non-whitespace-characters is treated as a Url
      
      * Correct the test which compares the old and new values and ranges when
        updating the terminal display's scroll bar.  
        This fixes the scroll bar being repainted unnecessarily often.  Found
        with the nifty QT_FLUSH_PAINT debugging tool.
      
      * Select the profile name (set to "New Profile" by default) and focus the 
        profile name edit area when showing the Edit Profile dialog for a new
        profile to allow the user to easily set the name.
      
      * Always use color scheme list animation, not just when the Edit Profile 
        dialog is first displayed as per richmoore's suggestion. 
      
      * Update Edit Profile dialog caption when profile name is changed.
      
      * Update favorite status icon in Manage Profiles dialog when the favorite
        status is changed by another object.
      
      * Add disabled menu item which is shown in the 'Change Profile' list
        when there are no other profiles there
      
      svn path=/trunk/KDE/kdebase/apps/konsole/; revision=683787
      37088799
  31. 03 Jul, 2007 1 commit
    • Robert Knight's avatar
      · 72241ef4
      Robert Knight authored
      * Comment out many debugging messages 
      
      * Experimental optimization, disable kerning since this is not required
        with the mono-spaced fonts which are used in the terminal.
      
      svn path=/trunk/KDE/kdebase/apps/konsole/; revision=682702
      72241ef4
  32. 27 Jun, 2007 1 commit
    • Robert Knight's avatar
      Resize color name column to fit contents in color scheme editor. Draw a... · 03587467
      Robert Knight authored
      Resize color name column to fit contents in color scheme editor.  Draw a translucent version of the selection marker around the profile's current color scheme when it is not selected.  The distinction between the color scheme being used by a profile and a color scheme selected so that it can be edited, removed or copied remains, though I am worried it might not be intuitive.
      
      svn path=/trunk/KDE/kdebase/apps/konsole/; revision=680722
      03587467
  33. 23 Jun, 2007 1 commit
    • Robert Knight's avatar
      Save and load environment variables as part of the profile. Defaults to just... · 2a110919
      Robert Knight authored
      Save and load environment variables as part of the profile.  Defaults to just 'TERM=xterm'.  Allow editing of the environment in the profile editor (not just the TERM variable).  Separate out the tab-related options into their own tab in the profile editor and rename 'Keyboard Setup' to 'Input' as that seems a more obvious name.
      
      svn path=/trunk/KDE/kdebase/apps/konsole/; revision=679103
      2a110919
  34. 20 Jun, 2007 1 commit
  35. 19 Jun, 2007 3 commits
  36. 18 Jun, 2007 1 commit