Waqar Ahmed authored Jan 22, 2022 and Tomaz Canabrava committed Jan 25, 2022

When Underline Files is enabled and you 'ls' into a big directory,
then hovering / selection becomes really slow.

Martin Tobias Holmedahl Sandsmark authored Jan 10, 2022 and Kurt Hindenburg committed Jan 12, 2022

If Qt detects a plasma session it uses kfmclient anyways (so the current
behavior), but if it detects gnome it uses gnome-open, xdg-portal dbus
call if it detects that, etc.

This is safe to change without a fallback icon explicitly specified
because if it doesn't exist in the active icon theme, it will fall back
to edit-copy, which is a standard FreeDesktop icon name present in
every icon theme ever.

CCBUG: 423937

GIT_SILENT

Also install the relevant git hook.

GIT_SILENT

Useful when removing the open-with actions from the session menu before
adding new ones.

KFileItemActions::insertOpenWithActionsTo() is from KIO, so kio_version.

Convert depreciated method in KF 5.82

- When we match child files/dirs of the current dir, either the item name
is the "filename", or if it's a child-dir/somefile, then filename starts
with "child-dir + '/'".

To test create a file foo and a dir bar with a bar-file inside it then:
  - `ls`, foo and bar should be underlined
  - `ls bar/*`, bar/bar-file should be underlined
  - type bar..., before it would be underlined, after it won't be

- Capture QString by reference in lambda.

Only '.' and '..' could be valid hotspots, but '..........' isn't. The
latter is used by some CLI tools to indicate progress ...etc.

To test, in any dir use `ls -a`, Ctrl + clicking '.' and '..' should
open the current dir and parent of the current dir respectively.

Type .......... at the prompt, before it would get underlined, after no
hotspot will be created for it.

BUG: 432779

Ahmad Samir authored Feb 09, 2021 and Kurt Hindenburg committed Feb 15, 2021

It seems there is no way around checking for the extension then falling
back to letting QMimeDataBase examine the file contents; e.g. a file
named konsolerc, doesn't have an extension, but it is still a text file.

Ahmad Samir authored Jan 14, 2021 and Kurt Hindenburg committed Jan 20, 2021

QMimeDataBase will return "application/octet-stream" as the mime type
of something like "path/to/some/textfile.txt:123:123:", because we are
using methods from it that check only the file extension. That meant
some valid text files with line/column suffixes couldn't be opened.

Instead move the mime type check _after_ the file path has been cleaned.
Also account for mime types that aren't recognized, e.g. a text file with
no extension.

BUG: 431601

When activating a file filter hot spot, everything got opened with the text
editor specified in the profile settings, which is wrong e.g. with pdf or
png files. Check the mime type of the file path, based only on the extension
so as to keep things fast.

Also rename openWithSysDefaultEditor() to openWithSysDefaultApp(), which is
more accurate.

BUG: 431496

- Handle `grep -n` output with long lines, where there is no space
  after "path/to/file:123:", we can send "path/to/file:123:bla" to
  a text editor and it seems most of them just ignore the text after
  the last ":"
- If the session pointer is null, there is nothing to do
- Guard against editorCmd not having any spaces in it, which it could
  be with the "Custom" entry (from the combobox)
- Even when the file URL doesn't match the /path/to/file:line:column
  pattern try to use the editor specified in the profile settings

The functionality to open a file at a certain line/column in a text editor
was added in commit 923f8d14. Here some preset text editors are added
to make it easier to select your preferred text editor to use; the syntax
for each editor is hard-coded, however there is a "custom" entry in the
combobox where the user can set a different text editor (or a different
syntax).

This combobox is inspired by the "Code Navigation" menu in Heaptrack.

GUI:

Konsole minimum required version is QT 5.14 and KF5 5.71, there is no
need to keep support for those deprecated functions.

Edwin Pujols authored Dec 13, 2020 and Tomaz Canabrava committed Dec 14, 2020

Allow `ColorFilter` to match all color names recognized by `QColor` (as
per the docs on `QColor::setNamedColor`).

Edwin Pujols authored Dec 05, 2020 and Kurt Hindenburg committed Dec 10, 2020

As per some of the comments, I rewrote `getCharacterPosition` to return
tuples instead of using references.

Ahmad Samir authored Nov 19, 2020 and Kurt Hindenburg committed Dec 02, 2020

Add a new function to update the regex pattern in FileFilter, rather than
recreating a FileFilter object.