Commit 3711e884 authored by Ahmad Samir's avatar Ahmad Samir Committed by Kurt Hindenburg
Browse files

SessionController: don't delete actions removed from QMenu manually

This isn't needed as QMenu takes care of deleting removed actions (that
are children of it). Confirmed with QObject::connect() call on
QObject::destroyed signal. And skimming the upstream QMenu::actionEvent()
code.
parent 8bcbe926
......@@ -1830,8 +1830,6 @@ void SessionController::showDisplayContextMenu(const QPoint& position)
for (auto *action : actList) {
if (action->text().toLower().remove(QLatin1Char('&')).contains(i18n("open with"))) {
popup->removeAction(action);
action = nullptr;
delete action;
}
}
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment