Commit d582a984 authored by Kurt Hindenburg's avatar Kurt Hindenburg

Add fixme about changing icon for favorite column

parent 647a34d4
......@@ -397,6 +397,9 @@ void ProfileSettings::updateFavoriteStatus(const Profile::Ptr &profile, bool fav
for (int i = 0; i < rowCount; i++) {
QModelIndex index = _sessionModel->index(i, FavoriteStatusColumn);
if (index.data(ProfileKeyRole).value<Profile::Ptr>() == profile) {
// FIXME: On desktops without this icon, it is impossible to
// determine if a profile is a favorite in this dialog.
// Consider changing to using QStandardItem::setCheckable
const QIcon icon = favorite ? QIcon::fromTheme(QStringLiteral("dialog-ok-apply")) : QIcon();
_sessionModel->setData(index, icon, Qt::DecorationRole);
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment