diff --git a/krusader/ActionMan/useractionlistview.cpp b/krusader/ActionMan/useractionlistview.cpp index 544f6999b69b5bebd3e7d066dcc8acf4268ec40c..71bf63540465c090eb052e03d7d25b4ea42e8725 100644 --- a/krusader/ActionMan/useractionlistview.cpp +++ b/krusader/ActionMan/useractionlistview.cpp @@ -170,7 +170,7 @@ void UserActionListView::slotCurrentItemChanged(QTreeWidgetItem* item) QDomDocument UserActionListView::dumpSelectedActions(QDomDocument* mergeDoc) const { - QList list = selectedItems(); + const QList list = selectedItems(); QDomDocument doc; if (mergeDoc) doc = *mergeDoc; @@ -188,7 +188,7 @@ QDomDocument UserActionListView::dumpSelectedActions(QDomDocument* mergeDoc) con void UserActionListView::removeSelectedActions() { - QList list = selectedItems(); + const QList list = selectedItems(); for (auto item : list) { if (auto* actionItem = dynamic_cast(item)) { diff --git a/krusader/Archive/krarchandler.cpp b/krusader/Archive/krarchandler.cpp index 5deb69b81fcb93ffd3fe2cf0ef982a1010ba95ed..c8971df6d37a2900519b285079594b58f4d5d769 100644 --- a/krusader/Archive/krarchandler.cpp +++ b/krusader/Archive/krarchandler.cpp @@ -124,7 +124,7 @@ KrArcHandler::KrArcHandler(QObject *parent) : QObject(parent) QStringLiteral("application/vnd.rar") }; #ifdef KRARC_QUERY_ENABLED - auto mimetypes = KProtocolInfo::archiveMimetypes("krarc"); + const auto mimetypes = KProtocolInfo::archiveMimetypes("krarc"); for (const auto &mimetype : mimetypes) krarcArchiveMimetypes.insert(mimetype); #endif diff --git a/krusader/BookMan/krbookmarkhandler.cpp b/krusader/BookMan/krbookmarkhandler.cpp index 761fa3d07dbf67be07ad9a181527690ec1a5fa68..6ea4be6e125f9bd2652afe295a672711675b7a5d 100644 --- a/krusader/BookMan/krbookmarkhandler.cpp +++ b/krusader/BookMan/krbookmarkhandler.cpp @@ -599,7 +599,7 @@ bool KrBookmarkHandler::eventFilter(QObject *obj, QEvent *ev) // such as Ctrl+W and accelerator keys if (eventType == QEvent::KeyPress && menu) { auto *kev = dynamic_cast(ev); - QList acts = menu->actions(); + const QList acts = menu->actions(); bool quickSearchStarted = false; bool searchInSpecialItems = KConfigGroup(krConfig, "Look&Feel").readEntry("Search in special items", false); diff --git a/krusader/Dialogs/kurllistrequester.cpp b/krusader/Dialogs/kurllistrequester.cpp index 217c6c13f7e404a1e6b0f663dd60257acf3fc193..630841311ea077611a1274dada428301697da0fa 100644 --- a/krusader/Dialogs/kurllistrequester.cpp +++ b/krusader/Dialogs/kurllistrequester.cpp @@ -124,7 +124,7 @@ void KURLListRequester::keyPressEvent(QKeyEvent *e) void KURLListRequester::deleteSelectedItems() { - QList selectedItems = urlListBox->selectedItems(); + const QList selectedItems = urlListBox->selectedItems(); for (QListWidgetItem *item : selectedItems) delete item; emit changed(); diff --git a/krusader/FileSystem/sizecalculator.cpp b/krusader/FileSystem/sizecalculator.cpp index db11ae06160378f642d16b0241fd290e90fb9943..befa15429200536faf200b075dc2d82f9aa04989 100644 --- a/krusader/FileSystem/sizecalculator.cpp +++ b/krusader/FileSystem/sizecalculator.cpp @@ -103,7 +103,8 @@ void SizeCalculator::nextUrl() nextUrl(); return; } - for (FileItem *file : fs->fileItems()) + const QList fileItems = fs->fileItems(); + for (FileItem *file : fileItems) m_nextSubUrls << file->getUrl(); delete fs; } else { diff --git a/krusader/GUI/kfnkeys.cpp b/krusader/GUI/kfnkeys.cpp index 455ee55f63358df845ebaa23258f201893662da7..7f292c665071732f04e5503b464f9b0c27f412f1 100644 --- a/krusader/GUI/kfnkeys.cpp +++ b/krusader/GUI/kfnkeys.cpp @@ -51,7 +51,7 @@ KFnKeys::KFnKeys(QWidget *parent, KrMainWindow *mainWindow) : layout->setSpacing(0); int pos = 0; - for(QPair> entry : buttonList) { + for(QPair> entry : qAsConst(buttonList)) { layout->addWidget(entry.first, 0, pos++); } layout->activate(); diff --git a/krusader/JobMan/jobman.cpp b/krusader/JobMan/jobman.cpp index 96e366eec0c016fbeaf3bcf0cab8edd1beb5321f..7fa0ce4a4f04a964c6a6a83a9ad404bbe1da63e7 100644 --- a/krusader/JobMan/jobman.cpp +++ b/krusader/JobMan/jobman.cpp @@ -248,7 +248,7 @@ bool JobMan::waitForJobs(bool waitForUserInput) m_messageBox->addButton(QMessageBox::Abort); m_messageBox->addButton(QMessageBox::Cancel); m_messageBox->setDefaultButton(QMessageBox::Cancel); - for (KrJob *job: m_jobs) + for (KrJob *job: qAsConst(m_jobs)) connect(job, &KrJob::terminated, this, &JobMan::slotUpdateMessageBox); slotUpdateMessageBox(); @@ -258,7 +258,7 @@ bool JobMan::waitForJobs(bool waitForUserInput) // accepted -> cancel all jobs if (result == QMessageBox::Abort) { - for (KrJob *job: m_jobs) { + for (KrJob *job: qAsConst(m_jobs)) { job->cancel(); } return true; @@ -314,7 +314,7 @@ void JobMan::slotControlActionTriggered() if (!anyRunning && m_queueMode) { m_jobs.first()->start(); } else { - for (KrJob *job : m_jobs) { + for (KrJob *job : qAsConst(m_jobs)) { if (anyRunning) job->pause(); else @@ -426,7 +426,7 @@ void JobMan::cleanupMenu() { void JobMan::updateUI() { int totalPercent = 0; - for (KrJob *job: m_jobs) { + for (KrJob *job: qAsConst(m_jobs)) { totalPercent += job->percent(); } const bool hasJobs = !m_jobs.isEmpty(); diff --git a/krusader/Panel/PanelView/krviewitemdelegate.cpp b/krusader/Panel/PanelView/krviewitemdelegate.cpp index af3c05d87d26510121d358cc53dabbb13a22986a..c73046b2b0e8f1fef38fb3a212f473928b93a026 100644 --- a/krusader/Panel/PanelView/krviewitemdelegate.cpp +++ b/krusader/Panel/PanelView/krviewitemdelegate.cpp @@ -237,7 +237,7 @@ void KrViewItemDelegate::cycleEditorSelection() EditorSelection currentSelection(editor->selectionStart(), editor->QLINEEDIT_SELECTIONLENGTH); auto text = editor->text(); - auto selections = generateFileNameSelections(text); + const auto selections = generateFileNameSelections(text); // try to find current selection in the list int currentIndex = 0;