Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Krusader
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
2
Issues
2
List
Boards
Labels
Service Desk
Milestones
Merge Requests
6
Merge Requests
6
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Operations
Operations
Incidents
Environments
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Utilities
Krusader
Commits
ce871144
Commit
ce871144
authored
Aug 15, 2020
by
Toni Asensi Esteve
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Avoid 'conversion may change value' cases in krarc.cpp and related files
Revision:
!26
parent
1057f224
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
6 additions
and
6 deletions
+6
-6
krArc/krarc.cpp
krArc/krarc.cpp
+3
-3
krArc/krarcbasemanager.cpp
krArc/krarcbasemanager.cpp
+1
-1
krusader/Archive/abstractthreadedjob.cpp
krusader/Archive/abstractthreadedjob.cpp
+1
-1
krusader/Archive/krarchandler.h
krusader/Archive/krarchandler.h
+1
-1
No files found.
krArc/krarc.cpp
View file @
ce871144
...
...
@@ -577,7 +577,7 @@ void kio_krarcProtocol::get(const QUrl &url, int tries)
char
buffer
[
MAX_IPC_SIZE
];
while
(
1
)
{
int
n
=
::
read
(
fd
,
buffer
,
MAX_IPC_SIZE
);
int
n
=
int
(
::
read
(
fd
,
buffer
,
MAX_IPC_SIZE
)
);
if
(
n
==
-
1
)
{
if
(
errno
==
EINTR
)
continue
;
...
...
@@ -1327,7 +1327,7 @@ void kio_krarcProtocol::parseLine(int lineNo, QString line)
// next field is md5sum, ignore it
nextWord
(
line
);
// permissions
mode
=
nextWord
(
line
).
toU
Long
(
nullptr
,
8
);
mode
=
nextWord
(
line
).
toU
Int
(
nullptr
,
8
);
// Owner & Group
owner
=
nextWord
(
line
);
group
=
nextWord
(
line
);
...
...
@@ -1863,7 +1863,7 @@ QString kio_krarcProtocol::localeEncodedString(QString str)
const
char
*
data
=
array
.
data
();
for
(
int
i
=
0
;
i
!=
size
;
i
++
)
{
unsigned
shor
t
ch
=
(((
int
)
data
[
i
])
&
0xFF
)
+
0xE000
;
// user defined character
unsigned
in
t
ch
=
(((
int
)
data
[
i
])
&
0xFF
)
+
0xE000
;
// user defined character
result
.
append
(
QChar
(
ch
));
}
return
result
;
...
...
krArc/krarcbasemanager.cpp
View file @
ce871144
...
...
@@ -213,7 +213,7 @@ QString KrArcBaseManager::detectArchive(bool &encrypted, const QString& fileName
checksum
-=
((
unsigned
char
*
)
buffer
)[
i
];
sprintf
(
chksum
,
"0%o"
,
checksum
);
if
(
!
memcmp
(
buffer
+
148
,
chksum
,
strlen
(
chksum
)))
{
int
k
=
strlen
(
chksum
);
auto
k
=
strlen
(
chksum
);
for
(;
k
<
8
;
k
++
)
if
(
buffer
[
148
+
k
]
!=
0
&&
buffer
[
148
+
k
]
!=
32
)
break
;
...
...
krusader/Archive/abstractthreadedjob.cpp
View file @
ce871144
...
...
@@ -261,7 +261,7 @@ public:
qApp
->
processEvents
();
}
void
subJobStarted
(
const
QString
&
jobTitle
,
int
count
)
override
{
void
subJobStarted
(
const
QString
&
jobTitle
,
long
count
)
override
{
_jobThread
->
sendReset
(
jobTitle
);
_jobThread
->
sendMaxProgressValue
(
count
);
}
...
...
krusader/Archive/krarchandler.h
View file @
ce871144
...
...
@@ -42,7 +42,7 @@ public:
~
KrArcObserver
()
override
=
default
;
virtual
void
processEvents
()
=
0
;
virtual
void
subJobStarted
(
const
QString
&
jobTitle
,
int
count
)
=
0
;
virtual
void
subJobStarted
(
const
QString
&
jobTitle
,
long
count
)
=
0
;
virtual
void
subJobStopped
()
=
0
;
virtual
bool
wasCancelled
()
=
0
;
virtual
void
error
(
const
QString
&
error
)
=
0
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment