1. 18 Mar, 2016 1 commit
    • Toni Asensi Esteve's avatar
      Solve the problem of Libreoffice not being launched when the user utilizes the... · d51f0d7b
      Toni Asensi Esteve authored
      Solve the problem of Libreoffice not being launched when the user utilizes the "browse archives as directories" mode and double clicks (or presses Enter) on a .odt file, other cases using other kinds of files. Solve a bug searching inside 7z files.
      REVIEW: 127369
      There was the problem of Krusader not launching e.g. Libreoffice when the user utilized the "browse archives as directories" mode and double clicked (or pressed Enter) on a .ods file (because it was really a .zip file, as it happened in other cases). The function
          // returns true if the right unpacker exist in the system
          KRarcHandler::arcSupported(QString type)
      was improved (it has to be improved anyway) and is used so e.g. an .ods file will not be browsed because KRarcHandler::arcSupported() returns false in the case of an .ods file.
      Krusader users, in the "browse archives as directories" mode, were also enabled to browse .odt, .docx, .iso, .ods, .xlsx, etc. files using:
          - in the detailed view: the right arrow key, or the "Browse" action available when pressing the secondary button of the mouse.
          - in the brief view: the "Browse" action available when pressing the secondary button of the mouse.
      Note: In the "browse archives as directories" mode the forementioned "Browse" action does not appear in the case of e.g. a zip file because there's already an "Open" action that accomplishes that objective.
      With those changes one bug was also solved: if e.g. a 7z archive contains a file named "a.txt", the user opens the search tool of Krusader, he specifies that he wants to search for the file "a.txt", he enables the "Search in archives" checkbox, and he clicks on the "Search button" -> now the "a.txt" file is found inside the 7z archive.
      Tests done: Browsed zip, rar, tar, tar.bz2, tar.gz, tar.xz, 7z, odt, docx, iso, ods and xlsx files in Krusader, and opened them externally, using combinations of: the detailed view or the brief view, the right arrow key or the primary button of the mouse (in some cases that action launched an external program) or the secondary button of the mouse (its option "Open" or its option "Browse" when it was available), and having the option "browse archives as directories" enabled or disabled.
  2. 06 Mar, 2016 1 commit
  3. 04 Sep, 2015 1 commit
    • Simon Persson's avatar
      Change many icons used from krusader-specific to system standard icons · 3801a39e
      Simon Persson authored
      Most of the work (the hard part of finding suitable alternative) was done
      by Andreas Kainz <kainz.a@gmail.com>. Thank you Andreas!
      The only change to his work was to use "user-identity" instead of
      "user-properties" as a replacement for "kr_profile". This is because the
      identity icon was already used for panel profile selection (in the Window
      menu) and I think it is suitable.
      In addition to his work I also replaced "zoom-original" with
      "document-preview" and "edit" with "document-edit" for the KrViewer.
      And then of course remove all the icon files which are no longer used.
      The remaining icons installed by krusader will have replacement icons in
      the "breeze" and "oxygen" icon set. But they are not in any standard so
      any other icon theme is unlikely to have them, we still install them as
      fallback icons.
      REVIEW: 124958
  4. 20 Jul, 2015 1 commit
  5. 23 Jun, 2015 2 commits
    • Simon Persson's avatar
      Fix copying folders out from archive files, in a different way · 5ad78473
      Simon Persson authored
      Alternative fix for commit 60cf3b1d, fix for copy/move folders from archive.
      Change two implementations of vfs_getFile() to not return a url with a slash appended for folders. The normal_vfs already did not do this. And at least one user did not work with this.
      To make things consistent the other option would be to make normal_vfs also append slash for folders. And then fix all users that did not want the slash to remove it again.
      I still don't know if there is any user that needs the slash... it can't be any common operation at least, would have noticed the breakage easily since normal_vfs is the most commonly used.
      The commit that introduced adding a slash mentioned that it was for fixing "following link in sftp", I have tested copying a symlink to a folder over sftp with and without this patch, with patch it gives error message and no file transfer. Without this patch files from within the folder pointed to are copied, which is wrong. I prefer showing error message over copying the wrong files.
    • Simon Persson's avatar
      Change VFS API to make it safer · 1c5b8394
      Simon Persson authored
      Returning a raw pointer to manually allocated memory from a function is bound to cause leaks.. And it did in this case. (Users of vfs_getFiles did not always free the result when done with it)
      Instead, use QList as return type. QList object itself is basically just a ref counting smart pointer.
      Also, this change kind of spread itself so also adapt vfs_delFiles and vfs_addFiles to take references instead of pointers.
  6. 22 Jun, 2015 2 commits
    • Simon Persson's avatar
      Move Krusader::supportedTools to KrServices · 10af0555
      Simon Persson authored
      This is an effort to untangle the big criss cross of includes across modules. So it changes some other things also. The idea was to try to reduce the number of frameworks each module needs to mention in it's target_link_libraries (in CMakeLists.txt...). Also gives benefit of not having to recompile so many other modules after changing a header file. There is still much to do, this was just a start... things that I came across today.
    • Simon Persson's avatar
      Get rid of a bunch of compilation warnings · 1ac2029a
      Simon Persson authored
      All these includes of .moc files were generating warnings about nothing being generated, so get rid of them. CMake handles things fine without these lines.
  7. 10 Jun, 2015 1 commit
    • Simon Persson's avatar
      Port from KLocale to QLocale · e5611747
      Simon Persson authored
      Also update header includes to include KLocalizedString instead.
      Since most code was only using KGlobal to get the KLocale object pointer now was also a good time to remove includes of KGlobal. That meant porting KGlobal::charsets() to KCharset::charsets()  in a few places.
  8. 31 May, 2015 1 commit
  9. 29 May, 2015 2 commits
    • Simon Persson's avatar
      Port remaining parts from KUrl to QUrl · 1da1b23f
      Simon Persson authored
      Mostly straight forward porting, using porting script and also manual labour. Either way, it follows the guidelines (doc comments) in kurl.h from KF5.
      Mostly the difficult thing is the change in constructor that takes a QString. Needed to decide for each case if KUrl(QString) construction needed to be replaces with QUrl::fromUserInput or the simpler one, QUrl::fromLocalFile. If there are any regressions that would be likely candidate.
      Also some additional changes that now made sense to do:
      - KChooseDir dialogs: code could be simplified quite a lot, KUrlRequester does everything we needed already.
      - Krusader class, constructor: making sure relative paths are resolved is now done by QUrl anyway, could remove code for that.
    • Simon Persson's avatar
      Fix some regressions from porting KUrl to QUrl · dcacb034
      Simon Persson authored
      Encountered some bugs, so after that I went through the previous porting commits to find more of the same problems.
      Also changed porting of calls to get a KIO::JobUiDelegate, same as was done in Synchronizer module.. as I believe that to be the correct way.
  10. 31 Mar, 2015 1 commit
  11. 27 Mar, 2015 1 commit
    • Davide Gianforte's avatar
      [Header Files] Changed header files to Qt5/KF5 · bbf5ddd4
      Davide Gianforte authored
      All header files should refer only to qt5 or kf5; I used full path to have a better
      view of the package containing the single header; at compile time both include flags
      should be given.
      Marked as TODO all header files from KDE4LibsSupport, many of this classes have
      deprecated methods that should be changed with the new from Qt (KUrl -> Qurl and so on).
      For a better readability, I ordered header files in system, then qt, then kde.
  12. 26 Feb, 2013 1 commit
  13. 05 Sep, 2012 1 commit
    • Pino Toscano's avatar
      i18n fixes · 34cc8d9c
      Pino Toscano authored
      - fix capitalization
      - remove contractions
      - improve wording and punctuation of some sentences
      - spell "I/O", "MIME", and "XML" correctly
      - spell "KDiff3, "KGet", "KMail", "KRename", and "Krusader" correctly
      - spell the Ctrl, Shift, and Tab keys correctly
  14. 19 Aug, 2012 1 commit
  15. 30 Mar, 2011 1 commit
  16. 27 Mar, 2011 1 commit
  17. 18 Oct, 2010 3 commits
  18. 17 Oct, 2010 1 commit
  19. 06 Aug, 2010 1 commit
  20. 12 Jun, 2010 1 commit
  21. 04 Mar, 2010 1 commit
  22. 03 Mar, 2010 2 commits
  23. 20 Jun, 2009 4 commits
  24. 16 Jun, 2009 1 commit
  25. 15 Jun, 2009 1 commit
  26. 04 Jun, 2009 2 commits
  27. 03 Jun, 2009 1 commit
  28. 19 Apr, 2009 1 commit
  29. 10 Jan, 2009 1 commit
  30. 29 Jul, 2008 1 commit