1. 18 Mar, 2016 1 commit
    • Toni Asensi Esteve's avatar
      Solve the problem of Libreoffice not being launched when the user utilizes the... · d51f0d7b
      Toni Asensi Esteve authored
      Solve the problem of Libreoffice not being launched when the user utilizes the "browse archives as directories" mode and double clicks (or presses Enter) on a .odt file, other cases using other kinds of files. Solve a bug searching inside 7z files.
      
      REVIEW: 127369
      
      There was the problem of Krusader not launching e.g. Libreoffice when the user utilized the "browse archives as directories" mode and double clicked (or pressed Enter) on a .ods file (because it was really a .zip file, as it happened in other cases). The function
          // returns true if the right unpacker exist in the system
          KRarcHandler::arcSupported(QString type)
      was improved (it has to be improved anyway) and is used so e.g. an .ods file will not be browsed because KRarcHandler::arcSupported() returns false in the case of an .ods file.
      
      Krusader users, in the "browse archives as directories" mode, were also enabled to browse .odt, .docx, .iso, .ods, .xlsx, etc. files using:
          - in the detailed view: the right arrow key, or the "Browse" action available when pressing the secondary button of the mouse.
          - in the brief view: the "Browse" action available when pressing the secondary button of the mouse.
      Note: In the "browse archives as directories" mode the forementioned "Browse" action does not appear in the case of e.g. a zip file because there's already an "Open" action that accomplishes that objective.
      
      With those changes one bug was also solved: if e.g. a 7z archive contains a file named "a.txt", the user opens the search tool of Krusader, he specifies that he wants to search for the file "a.txt", he enables the "Search in archives" checkbox, and he clicks on the "Search button" -> now the "a.txt" file is found inside the 7z archive.
      
      Tests done: Browsed zip, rar, tar, tar.bz2, tar.gz, tar.xz, 7z, odt, docx, iso, ods and xlsx files in Krusader, and opened them externally, using combinations of: the detailed view or the brief view, the right arrow key or the primary button of the mouse (in some cases that action launched an external program) or the secondary button of the mouse (its option "Open" or its option "Browse" when it was available), and having the option "browse archives as directories" enabled or disabled.
      d51f0d7b
  2. 15 Aug, 2015 1 commit
  3. 08 Jul, 2015 1 commit
    • Simon Persson's avatar
      Change what happens when executing a file · 39859e4c
      Simon Persson authored
      This rearranges the execute method (which runs when double clicking or pressing enter in a file panel) to first check if there is a registered application to open the file before checking if it is an archive file which can be listed in krusader.
      With that change, it is now possible for user to both look inside an archive file (with right arrow key) and open it with external program (enter key). There is no longer a need to disable krusader from opening an archive file.
      Also, it makes it possible for krarc to announce support for zip files under cover, like .docx and .odt, without causing a bad user experience.
      
      REVIEW: 124248
      39859e4c
  4. 05 Jul, 2015 1 commit
  5. 22 Jun, 2015 3 commits
    • Simon Persson's avatar
      Clean up some more header includes · 5dcd0a10
      Simon Persson authored
      5dcd0a10
    • Simon Persson's avatar
      Move Krusader::supportedTools to KrServices · 10af0555
      Simon Persson authored
      This is an effort to untangle the big criss cross of includes across modules. So it changes some other things also. The idea was to try to reduce the number of frameworks each module needs to mention in it's target_link_libraries (in CMakeLists.txt...). Also gives benefit of not having to recompile so many other modules after changing a header file. There is still much to do, this was just a start... things that I came across today.
      10af0555
    • Simon Persson's avatar
      Get rid of a bunch of compilation warnings · 1ac2029a
      Simon Persson authored
      All these includes of .moc files were generating warnings about nothing being generated, so get rid of them. CMake handles things fine without these lines.
      1ac2029a
  6. 20 Jun, 2015 1 commit
    • Simon Persson's avatar
      Clean up header includes · afd4434d
      Simon Persson authored
      I just noticed that so many includes were not necessary for build, so remove them. Also get rid of a compilation warning in ListPanelFunc::deleteFiles().
      afd4434d
  7. 10 Jun, 2015 1 commit
    • Simon Persson's avatar
      Port from KLocale to QLocale · e5611747
      Simon Persson authored
      Also update header includes to include KLocalizedString instead.
      Since most code was only using KGlobal to get the KLocale object pointer now was also a good time to remove includes of KGlobal. That meant porting KGlobal::charsets() to KCharset::charsets()  in a few places.
      e5611747
  8. 09 Jun, 2015 1 commit
  9. 03 Jun, 2015 2 commits
    • Simon Persson's avatar
      Port from KStandardDirs to QStandardPaths · 71987f07
      Simon Persson authored
      The porting script also ported from KGlobal::config to KSharedConfig::openConfig.
      71987f07
    • Simon Persson's avatar
      Port from KTemporaryFile to QTemporaryFile · 6b8de6f6
      Simon Persson authored
      The CreateChecksumDlg and MatchChecksumDlg constructors had memleaks of KTemporaryFile objects, corrected that by placing them on the stack instead.
      Removes some dead code that was using KTemporaryFile.
      Also adds a missing include that was causing compilation failures (sometimes...)
      6b8de6f6
  10. 31 May, 2015 1 commit
    • Simon Persson's avatar
      Add Q_DECL_OVERRIDE to all virtual method overrides · 96d03e72
      Simon Persson authored
      Well, at least all virtual method overrides that I could find, there are probably more of them.
      
      Also correct the few errors detected by this:
      - KrViewer::windowActivationChange... this one existed in Qt 3 but not 4 or 5.
      - Konfigurator::slotButtonClicked.. well, not fixed, just added a TODO comment, will be done when porting away from KDialog.
      - KonfiguratorExtension::connectNotify... signature and implementation ported to Qt 5 now.
      - KRQuery::(dis)connectNotify... signatures and implementations ported to Qt 5 now.
      96d03e72
  11. 29 May, 2015 1 commit
    • Simon Persson's avatar
      Port remaining parts from KUrl to QUrl · 1da1b23f
      Simon Persson authored
      Mostly straight forward porting, using porting script and also manual labour. Either way, it follows the guidelines (doc comments) in kurl.h from KF5.
      Mostly the difficult thing is the change in constructor that takes a QString. Needed to decide for each case if KUrl(QString) construction needed to be replaces with QUrl::fromUserInput or the simpler one, QUrl::fromLocalFile. If there are any regressions that would be likely candidate.
      Also some additional changes that now made sense to do:
      - KChooseDir dialogs: code could be simplified quite a lot, KUrlRequester does everything we needed already.
      - Krusader class, constructor: making sure relative paths are resolved is now done by QUrl anyway, could remove code for that.
      1da1b23f
  12. 21 May, 2015 1 commit
  13. 28 Mar, 2015 1 commit
  14. 27 Mar, 2015 1 commit
    • Davide Gianforte's avatar
      [Header Files] Changed header files to Qt5/KF5 · bbf5ddd4
      Davide Gianforte authored
      All header files should refer only to qt5 or kf5; I used full path to have a better
      view of the package containing the single header; at compile time both include flags
      should be given.
      
      Marked as TODO all header files from KDE4LibsSupport, many of this classes have
      deprecated methods that should be changed with the new from Qt (KUrl -> Qurl and so on).
      
      For a better readability, I ordered header files in system, then qt, then kde.
      bbf5ddd4
  15. 05 Apr, 2013 1 commit
  16. 06 Sep, 2012 1 commit
    • Pino Toscano's avatar
      i18n fixes · 6879ec43
      Pino Toscano authored
      - remove contractions
      - remove extra exclamation marks
      - chage few messages to be the same as existing equivalent messages
      - spell "URL" correctly
      6879ec43
  17. 05 Sep, 2012 1 commit
    • Pino Toscano's avatar
      i18n fixes · 34cc8d9c
      Pino Toscano authored
      - fix capitalization
      - remove contractions
      - improve wording and punctuation of some sentences
      - spell "I/O", "MIME", and "XML" correctly
      - spell "KDiff3, "KGet", "KMail", "KRename", and "Krusader" correctly
      - spell the Ctrl, Shift, and Tab keys correctly
      34cc8d9c
  18. 01 Sep, 2012 1 commit
  19. 31 Aug, 2012 1 commit
    • Pino Toscano's avatar
      i18n fixes · 4ddff3f5
      Pino Toscano authored
      - remove some string puzzles
      - fix typos
      - turn a "Ok" into "OK" (which already exists, and it is the same style as in kdelibs)
      - spell "URL" correctly
      - remove extra spaces in messages
      - add context to few "Unknown" messages
      4ddff3f5
  20. 19 Dec, 2011 1 commit
  21. 27 Jan, 2011 1 commit
  22. 01 Aug, 2010 1 commit
  23. 17 Mar, 2010 2 commits
  24. 16 Mar, 2010 1 commit
  25. 03 Mar, 2010 1 commit
  26. 20 Jun, 2009 4 commits
  27. 19 Jun, 2009 1 commit
  28. 15 Jun, 2009 1 commit
  29. 12 Jun, 2009 1 commit
  30. 05 Jun, 2009 3 commits
  31. 30 May, 2009 1 commit