GitLab

Revision: !53

Document new features, namely bound of the new tab to the current and insertion of new tabs next to the current

ADDED: New tabs start in current folder.
ADDED: New tabs can be inserted next to the current tab or at the end of the tab list.

GUI: An "Insert Tabs After Current" / "Insert new tabs to the right of the current one" option can be chosen.

Revision: !50

FIXED: [ 397041 ] Shortcut to Re-open recently closed tab
BUG: 397041

ADDED: Closing a tab can be quickly undone with a hotkey or a menu entry. A menu can reopen recently closed tabs.

Revision: !49

Separate the code that {duplicates a tab} from the code that {adds a tab without duplicating it}. Make possible to add a tab at any position

Revision: !49

GUI: New options are seen in the File menu ("Undo Close Tab"), after right-
clicking on a tab ("Undo Close Tab" is also seen) and, as in Dolphin, in
the Go menu ("Recently Closed Tabs") so the user can choose which tab to
restore (not only the last closed one) or choose "Empty Recently Closed Tabs".

Revision: !49

Task: https://phabricator.kde.org/T14518

Task: https://phabricator.kde.org/T14518

This was done using the protocoltojson utility from KIO.

Task: https://phabricator.kde.org/T14518

Revision: !45

Remove the old FAQ file because it contains old information and
not the updates that were made by Pino Toscano and reviewed by
Yuri Chornoivan
(https://invent.kde.org/utilities/krusader/-/commit/
9a584ee6).

Note: The doc/faq.docbook file has newer information.

Revision: !46

Notes:
1) A method in order to {check if the process is running} was used like the
one in <https://doc.qt.io/qt-5/qprocess.html>:
    if (!builder.waitForFinished())
        qDebug() << "Make failed:" << builder.errorString();
    else
        qDebug() << "Make output:" << builder.readAll();
2) An
    error(KIO::ERR_SLAVE_DEFINED, i18n("After [...]
line was utilized, which is analogous to the
    error(KIO::ERR_SLAVE_DEFINED, i18n("Copying to mtp slaves is still under development!"));
line in
    https://github.com/KDE/kio-stash/blob/master/src/ioslave/ioslave.cpp
3) A `proc.waitForFinished(-1);` line was used, like two similar ones
in kmountman.cpp.

GUI: A new error message can be seen by the user.

FIXED: [ 433294 ] Gibberish error when extracting large file from zip archive
BUG: 433294

Revision: !44

FIXED: [ 435557 ] Wrong dates (2106-02-07) and times after entering rar archives
BUG: 435557

Revision: !43

Scenario:
- start krusader
- close the application (alt-f4, or click the window-close button)
- SEGV, with this (edited) backtrace:
  #0  KUrlNavigator::editor (this=0x80a562400)
  #1  0x000000000031e20e in ListPanel::eventFilter (this=0x80c2309c0, watched=0x80a6980d0, e=0x7fffffffc278)
  #6  0x00000008018c3c0c in QWidget::~QWidget() () from /usr/local/lib/qt5/libQt5Widgets.so.5
  #7  0x0000000800a26c4e in KUrlComboBox::~KUrlComboBox (this=0x80a6980d0)
  #11 0x00000008005de60b in KUrlNavigator::~KUrlNavigator (this=0x80a562400)
  #13 0x000000000031d5a5 in ListPanel::~ListPanel (this=0x80c2309c0)

Analysis:
- During the destructor, events are triggered, which hit the
  event-filter function in the object that is undergoing destruction.
  Since some of the objects referred to via pointer in the event-filter
  are dead or being-destroyed, this is UB (so be glad it crashes!).
- This is very similar to the problem and backtrace in KIO commit
  a8a2c08014484145a4bd2a541a1cbeb8be856bf1.

Fix:
- Uninstall the event-filter before carrying on with destruction.
- While here, add an extra nullptr check for the combobox in
  the event-filter.

See !25 (comment 115032)

BUG: 435791

When a file is updating (e.g. downloading, slow write, ...), Krusader crashes
if the KIO::PreviewJob ends after the view is updated (no item to update).

BUG: 425528
FIXED: [ 425528 ] Crash when synching folders

* Split "Show new/close tab buttons" into two options
* Added "Expanding tabs" option
* Added "Close tab by double click" option

CHANGED: Split "Show new/close tab buttons" into two options
ADDED: "Expanding tabs" and "Close tab by double click" options
GUI: Konfigurator options for tabs has changed

Discussion: !34

Discussion: !40

New options:
- Show close tab buttons (instead "Show new/close tab buttons")
- Show new tab button (instead "Show new/close tab buttons")
- Expanding tabs
- Close tab by double click

It is not included in the build for over 10 years and will be completely
removed in KF6. The parts of the documentation were already commented
out and have now been removed entirely.

Discussion: https://phabricator.kde.org/T11603

GIT_SILENT

Most of this code has been commented out for over 10 years,
so it is time to actually remove it.

This respects the user defined settings in the
"Default Applications" KCM and also works on windows.