Commit 49928cdb authored by Nicolas Fella's avatar Nicolas Fella
Browse files

Use QIcon instead of QPixmap where possible

This avoids having to specify a size in some places.

There is a behavior change. The code clearly intends to fall back to
specific icons when the requested name is not available. However this
does not work since the first call to QIcon::fromTheme will always give
a non-null pixmap since it has a builtin fallback. The new code
correctly makes use of the fallback icons.
parent 292b2bd2
......@@ -28,21 +28,12 @@ KWalletFolderItem::KWalletFolderItem(KWallet::Wallet *w, QTreeWidget *parent, co
setText(0, QStringLiteral("%1 (%2)").arg(_name).arg(_entries));
setFlags(Qt::ItemIsSelectable | Qt::ItemIsDragEnabled | Qt::ItemIsDropEnabled | Qt::ItemIsEnabled);
setIcon(0, getFolderIcon(KIconLoader::Small));
setIcon(0, getFolderIcon());
QPixmap KWalletFolderItem::getFolderIcon(KIconLoader::Group group)
QIcon KWalletFolderItem::getFolderIcon()
const auto iconSize = KIconLoader::global()->currentSize(group);
QPixmap pix = QIcon::fromTheme(_name).pixmap(iconSize);
if (pix.isNull()) {
pix = QIcon::fromTheme(_name.toLower()).pixmap(iconSize);
if (pix.isNull())
pix = QIcon::fromTheme(QStringLiteral("folder-red")).pixmap(iconSize);
return pix;
return QIcon::fromTheme(_name, QIcon::fromTheme(_name.toLower(), QIcon::fromTheme(QStringLiteral("folder-red"))));
void KWalletFolderItem::refresh()
......@@ -9,8 +9,6 @@
#include <KWallet>
#include <KIconLoader>
#include <KIconTheme>
#include <QListWidget>
#include <QPixmap>
......@@ -77,7 +75,7 @@ public:
QString name() const;
void refresh();
KWalletContainerItem *getContainer(KWallet::Wallet::EntryType type);
QPixmap getFolderIcon(KIconLoader::Group group);
QIcon getFolderIcon();
bool contains(const QString &itemKey);
QTreeWidgetItem *getItem(const QString &itemKey);
void refreshItemsCount();
......@@ -619,7 +619,7 @@ void KWalletEditor::entrySelectionChanged(QTreeWidgetItem *item)
if (fi) {
_currentFolder = fi->name();
_entryTitle->setText(QStringLiteral("<font size=\"+1\">%1</font>").arg(fi->text(0)));
_displayedItem = item;
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment