1. 01 Apr, 2020 1 commit
    • Harald Sitter's avatar
      use httpAssembleURI not httpAssembleURIf · 1d30388f
      Harald Sitter authored
      Summary:
      the latter is for when the last argument is a format string. which I
      believe is not the case here. or perhaps more importantly if it was a
      format string it'd be an invalid call because we pass no values in
      
      Test Plan:
      - make two printers
      - pause them
      - print job to one printer
      - open printer queue
      - right click job to move to other printer
      - job is now on other printer
      
      Reviewers: dantti
      
      Reviewed By: dantti
      
      Subscribers: kde-utils-devel
      
      Differential Revision: https://phabricator.kde.org/D28479
      1d30388f
  2. 28 Mar, 2020 1 commit
  3. 23 Mar, 2020 1 commit
  4. 21 Mar, 2020 1 commit
  5. 15 Mar, 2020 1 commit
  6. 12 Mar, 2020 2 commits
    • Nicolas Fella's avatar
      Fix authentication · 9a11a1f4
      Nicolas Fella authored
      Summary:
      According to the CUPS code (https://github.com/apple/cups/blob/master/cups/auth.c#L105) cupsDoAuthentication returns 0 on success and -1 on error. The code was assuming the opposite
      
      Now the CUPS password dialog is shown when needed. This is quite often, e.g directly at startup due to getServerSettings() so it might be worth checking if that's really necessary.
      
      BUG: 408512
      
      Test Plan: Open print-manager with a user that is not in a CUPS system group. Privileged operations work after entering a password
      
      Reviewers: dantti, broulik
      
      Reviewed By: dantti
      
      Subscribers: ognarb, rdieter, kde-utils-devel
      
      Differential Revision: https://phabricator.kde.org/D23403
      9a11a1f4
    • Nate Graham's avatar
      [Applet] Fix list item margins · faea0b12
      Nate Graham authored
      Summary:
      BUG: 360199
      BUG: 398681
      FIXED-IN: 20.04.0
      
      This is a minimal change needed to fix the aforementioned bugs. Ultimately I would like to
      make a re-usable component to implement this "expandable list item" paradigm (which is
      also used in the Networks, Bluetooth, Vaults, and Device Notifier applets) so we don't
      have to maintain five versions of the code. See T12812.
      
      Test Plan:
      Before: {F8171128}
      
      After: {F8171127}
      
      Reviewers: #plasma, dantti, cblack, ndavis
      
      Reviewed By: cblack, ndavis
      
      Subscribers: cblack, sefaeyeoglu, kde-utils-devel
      
      Differential Revision: https://phabricator.kde.org/D27995
      faea0b12
  7. 11 Mar, 2020 2 commits
  8. 10 Mar, 2020 1 commit
  9. 09 Mar, 2020 1 commit
  10. 01 Mar, 2020 1 commit
  11. 29 Feb, 2020 1 commit
  12. 27 Feb, 2020 3 commits
  13. 23 Feb, 2020 1 commit
  14. 17 Feb, 2020 3 commits
  15. 12 Feb, 2020 1 commit
  16. 08 Feb, 2020 1 commit
  17. 04 Feb, 2020 1 commit
  18. 03 Feb, 2020 1 commit
  19. 02 Feb, 2020 1 commit
  20. 30 Jan, 2020 3 commits
  21. 28 Jan, 2020 1 commit
  22. 17 Jan, 2020 1 commit
  23. 09 Jan, 2020 3 commits
  24. 06 Jan, 2020 1 commit
  25. 05 Jan, 2020 1 commit
  26. 03 Jan, 2020 1 commit
  27. 01 Jan, 2020 1 commit
  28. 19 Dec, 2019 1 commit
  29. 10 Dec, 2019 1 commit
  30. 06 Dec, 2019 1 commit