1. 13 Jun, 2020 1 commit
    • Maximilian Schiller's avatar
      Reraise the active sesson after renaming a session · dd60b75c
      Maximilian Schiller authored
      This patch gives focus back to the currently active terminal after
      renaming a session with either the context menu or the shortcut.
      
      Whenever a tab title is edited signal to the sessionstack to raise the
      active session.
      
      BUG: 408374
      dd60b75c
  2. 10 Jun, 2020 1 commit
  3. 09 Jun, 2020 1 commit
    • Maximilian Schiller's avatar
      Fix yakuake not opening on multimonitor setups · df1e7230
      Maximilian Schiller authored
      Fixes yakuake not opening on one monitor when the panel is located on an edge
      between two monitors.
      
      This patch corrects the ExtendedStruct calculations and then checks if
      not only the strut intersects with the current monitor but also the
      window frame. If the strut intersects but the window frame does not that
      window is most likely some king of panel located on an edge between the current
      and the next screen. With this patch those struts and windows will now be
      ignored.
      df1e7230
  4. 02 Jun, 2020 1 commit
    • Maximilian Schiller's avatar
      Prevent incorrect terminal switching · fc6236b2
      Maximilian Schiller authored
      This should prevent shift+tab of switching the terminal. If no
      keybinding is set to shift+tab it gets correctly forwarded to the
      shell/terminal.
      
      The old behavior can easily restored by remapping "Next terminal" to
      shift+tab.
      
      BUG: 421632
      fc6236b2
  5. 01 Jun, 2020 1 commit
    • Axel Navarro's avatar
      Add default shortcuts to switch-to-session actions · 90ef8e96
      Axel Navarro authored
      Copy the default switch-to-tab-%i action shortcuts from Konsole to
      Yakuake switch-to-session-%i action.
      Also, remove the -1 logic in the handleSwitchToAction to reduce
      coupling with the actions generator code.
      90ef8e96
  6. 10 Mar, 2020 2 commits
    • Ryan McCoskrie's avatar
      Add support for resizing by dragging the title bar · f4fbc98b
      Ryan McCoskrie authored
      Summary:
      This is for the benefit of users who find changing the window height
      through the configuration window overly tedious.
      
      This may cause slight flickering during resizing.
      
      FEATURE: 154686
      FIXED-IN: 20.04.0
      
      Test Plan:
      Run patched Yakuake.
      Drag Titlebar up and down the screen.
      
      Yakuake should automatically update its height configuration while being dragged.
      
      Reviewers: #yakuake, hein, mweepigeon, ngraham
      
      Reviewed By: mweepigeon, ngraham
      
      Subscribers: mweepigeon, ngraham
      
      Tags: #yakuake
      
      Differential Revision: https://phabricator.kde.org/D22227
      f4fbc98b
    • Christian Muehlhaeuser's avatar
      Support opening new sessions in current working dir · aa5306c4
      Christian Muehlhaeuser authored
      Summary:
      When a Konsole profile has the "Start in same directory as current session"
      setting enabled, Yakuake now respects the setting and opens new sessions
      in the current working dir, just like Konsole would.
      
      BUG: 396472
      FIXED-IN: 20.04.0
      
      Reviewers: hein, #yakuake, #konsole, tcanabrava, hindenburg, mweepigeon, ngraham
      
      Reviewed By: mweepigeon, ngraham
      
      Subscribers: ngraham, mweepigeon, ryanmccoskrie
      
      Differential Revision: https://phabricator.kde.org/D26744
      aa5306c4
  7. 12 Jan, 2020 1 commit
  8. 30 Nov, 2019 1 commit
  9. 24 Nov, 2019 1 commit
  10. 21 Nov, 2019 1 commit
    • Nicolas Höft's avatar
      Enable high DPI pixmaps · 0134f68c
      Nicolas Höft authored
      Summary:
      Enable High DPI pixmaps to make icons in dialogs looks nice
      if High DPI is enabled.
      
      BUG: 407726
      
      Test Plan: Checked manually in high DPI environment.
      
      Reviewers: hein, cfeck, ngraham
      
      Reviewed By: cfeck, ngraham
      
      Subscribers: ngraham
      
      Differential Revision: https://phabricator.kde.org/D25038
      0134f68c
  11. 13 Nov, 2019 1 commit
  12. 18 Sep, 2019 1 commit
  13. 16 Aug, 2019 1 commit
  14. 09 Jul, 2019 1 commit
  15. 26 Apr, 2019 1 commit
    • Maximilian Schiller's avatar
      Remove forcing the initial dir to QDir::homePath() · 8f9844b8
      Maximilian Schiller authored
      Summary:
      This removes setting the current working dir to the home directory.
      Without this patch the KPart's initial directory setting has no effect.
      Also the KPart already defaults back to the home directory if nothing has been set.
      
      BUG: 396036
      
      Test Plan:
      1. Edit Current profile
      2. change initial directory to something other than ~
      3. restart yakuake / open new tab
      4. The shells working dir should be equal to as specified in step 2
      
      Reviewers: hein, #kde_applications
      
      Reviewed By: hein
      
      Differential Revision: https://phabricator.kde.org/D20117
      8f9844b8
  16. 24 Mar, 2019 1 commit
    • Lionel Chauvin's avatar
      [Yakuake] Improve customization · 1f8e9fbc
      Lionel Chauvin authored
      Summary:
      This patch increases Yakuake customization possibilities without break existing skins.
      The new features are:
      - new tab button can be positionned at the end of tabs
      - selected tab text can be not bold
      - titlebar's title can be centered
      - titlebar's icons can be anchored at left
      - a compact mode that superposes title and tabbar
      
      Here examples of what can be achieved with these changes:
      
      {F6698444}
      
      {F6711610}
      
      Test Plan:
      Install skins:
      
      {F6711608}
      {F6711609}
      
      Reviewers: hein, #yakuake
      
      Reviewed By: hein
      
      Tags: #yakuake
      
      Differential Revision: https://phabricator.kde.org/D19835
      1f8e9fbc
  17. 18 Mar, 2019 1 commit
  18. 10 Mar, 2019 1 commit
    • Lionel Chauvin's avatar
      Fix Skin validation when installed from KNS · d9537fcb
      Lionel Chauvin authored
      Summary:
      When a Skin is downloaded from KNS, Yakuake fails to validate the presence of title.skin and tabs.skin files.
      The skin is then uninstalled even if these files exist.
      
      This is due to this optimization of KNS: https://phabricator.kde.org/D6104
      Files are not listed anymore by entry.installedFiles().
      They are replaced by paths that end with /*
      
      In order to fix this bug I changed the validateSkin method so that it checks the presence of files in the filesystem instead of in a list of entries returned by KNS.
      
      BUG: 395012
      
      Test Plan:
      Download a Skin from KNS:  It should not complain about missing files.
      Install a correct skin from local: it should not  complain about missing files;
      Install a wrong skin from local: it should  complain about missing files;
      Install a correct skin already installed from local: it should ask for overwrite existing skin.
      
      Reviewers: hein, apol, #yakuake
      
      Reviewed By: hein
      
      Subscribers: Zren, hein, apol, chauvin
      
      Tags: #yakuake
      
      Differential Revision: https://phabricator.kde.org/D13335
      d9537fcb
  19. 25 Feb, 2019 1 commit
  20. 04 Feb, 2019 1 commit
  21. 24 Jan, 2019 1 commit
    • Maximilian Schiller's avatar
      Add shortcuts as default shortcuts · fb5a395b
      Maximilian Schiller authored
      Summary:
      Add the shortcuts a the default shortcuts to the actionCollection()
      When resetting to the default shortcuts this no longers clears them.
      BUG: 401244
      
      Test Plan: Open yakuake and confige shortcuts. Hit the "Defaults" button. The shortcuts should no longer be cleared.
      
      Reviewers: hein
      
      Reviewed By: hein
      
      Differential Revision: https://phabricator.kde.org/D18500
      fb5a395b
  22. 09 Dec, 2018 1 commit
  23. 30 Oct, 2018 1 commit
    • Kai Uwe Broulik's avatar
      Fix KIcon -> QIcon porting bug · 3219dc4c
      Kai Uwe Broulik authored
      Use QIcon::fromTheme (which loads named icons from icon theme) rather than
      QIcon constructor (which loads an icon from a given path).
      
      Fixes missing icons in e.g. tab bar context menu, first run wizard, and others
      
      Reviewed By: hein
      3219dc4c
  24. 22 Oct, 2018 1 commit
    • Maximilian Schiller's avatar
      Use KMainWindow instead of QMainWindow · 0c0eb086
      Maximilian Schiller authored
      Summary:
      MainWindow should inherit from KMainWindow and not from QMainWindow
      because QMainWindow does not call the queryClose function upon closing.
      This disabled the "really quit?" dialog which should come up if more than one session
      is currently open.
      Furthermore makes Yakuake properly quit when requested via the "Quit" action or the dialog by
      making the QApplication quit if the last Window Closes.
      
      BUG:  398425
      
      Test Plan:
      1. open yakuake
      2. press ctrl + shift + q
      
      without the patch yakuake just hides again (press F12 to confirm) with the patch it properly quits.
      
      1. open yakuake
      2. open multiple (>1) sessions (bottom left "+" symbol)
      3. press ctrl + shift + q
      
      without the patch yakuake just hides with the patch a dialog comes up and asks "really quit?"
      on pressing "quit" yakuake properly quits.
      
      Reviewers: hein, alexeymin, #kde_applications
      
      Reviewed By: hein
      
      Subscribers: tcanabrava
      
      Differential Revision: https://phabricator.kde.org/D15535
      0c0eb086
  25. 26 Sep, 2018 1 commit
  26. 15 Sep, 2018 1 commit
  27. 24 Aug, 2018 1 commit
  28. 28 Mar, 2018 2 commits
  29. 29 Nov, 2017 2 commits
  30. 24 Oct, 2017 1 commit
    • Eike Hein's avatar
      Suppress yakuake "Unregister input type" warning when using qdbus · ca460bf5
      Eike Hein authored
      Summary:
      When using the qdbus interface of yakuake, the following warning is constantly printed in the terminal:
      
      `Skipped method "addSession" : Unregistered input type in parameter list: Session::SessionType`
      
      That's because the `enum Session::SessionType` is the type of parameter that is accepted by the `addSession` function that is exposed through the dbus interface, and this `enum` hasn't been registered (with a `Q_DECLARE_METATYPE`?).
      
      As I see, registering a new metatype can be a bit tricky, and I guess this might be one reason why the additional functions `addSessionTwoHorizontal()`, `addSessionTwoVertical()` and `addSessionQuad()` exist: simplified code. After all, these functions are just one-line-code wrappers of the existing `addSession()` function (they call the addSession() with different session type parameter).
      
      This patch renames the existing `int SessionStack::addSession(Session::SessionType type)` function to `SessionStack::addSessionImpl(Session::SessionType type)`, and creates a yet-another-wrapper function `int SessionStack::addSession()` without any parameters to make it available through the QDBus interface in order to suppress these warnings without breaking the DBus API. The newly added `addSession()` behaves exactly as the old addSession() behaved; just creates a new `Session::Single` type session.
      
      Test Plan:
      Start yakuake from a shell, and:
      
      1) (optional) If your system supports auto completion, type the following in a second shell:
      
      `qdbus org.kde.yakuake /` <- start pressing the tab key here to see the available functions.
      
      2) Execute the command `qdbus org.kde.yakuake /yakuake/sessions org.kde.yakuake.addSession`
      
      Both for 1 and 2 check the shell that you started yakuake from, and you should see `Skipped method "addSession" : Unregistered input type in parameter list: Session::SessionType` messages appearing each time you press the tab key or calling the function `org.kde.yakuake.addSession`.
      
      Reviewers: hein, #kde_applications, alexeymin
      
      Reviewed By: alexeymin
      
      Subscribers: alexeymin
      
      Differential Revision: https://phabricator.kde.org/D7813
      ca460bf5
  31. 12 Oct, 2017 1 commit
  32. 16 Sep, 2017 1 commit
    • Vangelis Tasoulas's avatar
      Fixes a yakuake "index out of range" crash produced by QDBus exposed function... · 09abe657
      Vangelis Tasoulas authored
      Fixes a yakuake "index out of range" crash produced by QDBus exposed function TabBar::sessionAtTab(int)
      
      Summary:
      The function `TabBar::sessionAtTab(int index)` is exposed through QDBus and if a user/script passes a negative number, yakuake crashes with `index out of range`.
      
      This patch fixes that behaviour with a sanity check. If the user passes a negative number, return -1.
      
      Test Plan:
      Run the command `qdbus org.kde.yakuake /yakuake/tabs org.kde.yakuake.sessionAtTab -1`
      Yakuake will crash.
      
      Apply the patch and re-run the above `qdbus` command. It shouldn't be crashing now.
      
      Reviewers: #kde_applications, hein, alexeymin
      
      Reviewed By: #kde_applications, hein, alexeymin
      
      Subscribers: alexeymin
      
      Differential Revision: https://phabricator.kde.org/D7812
      09abe657
  33. 06 Sep, 2017 1 commit
    • Martin Flöser's avatar
      Make Yakuake work on Wayland with Qt 5.9 · 7534df21
      Martin Flöser authored
      Summary:
      Yakuake is also affected by the common problem that the integration
      breaks once a window gets hidden, which is a very common feature of
      Yakuake.
      
      This change tracks the PlasmaShellSurface, destroys it on hide and
      recreates on show. Thus it's alwyas positioned as expected.
      
      Test Plan:
      This commit was created using a yakuake which is positioned
      correctly, although I pressed F12 a few times.
      
      Differential Revision: https://phabricator.kde.org/D7709
      7534df21
  34. 02 Aug, 2017 1 commit
  35. 27 Jun, 2017 1 commit
  36. 01 Jun, 2017 1 commit
  37. 03 Apr, 2017 1 commit